Skip to contentSkip to conversation

TTY fix for 2.6.32-git

PATCH New Greg KH 2 participants 5 messages Oct 30, 2009 – Nov 3, 2009

Subsystems (2)
lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 TTY fix for 2.6.32-git

Here is one tty bugfix for your kernel tree.

Please pull from:

	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/tty-2.6.git/

The full patch will be sent to the linux-kernel mailing list, if anyone wants to see it.

thanks,

greg k-h

------------

 arch/m68k/Kconfig    |    6 +++---
 drivers/char/Kconfig |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

---------------

Alan Cox (1):
tty: Mark generic_serial users as BROKEN

#1 lore raw

PATCH 1/1 tty: Mark generic_serial users as BROKEN

From: Alan Cox <[email protected]>

There isn't much else I can do with these. I can find no hardware for any of them and no users. The code is broken.

---
 arch/m68k/Kconfig    |    6 +++---
 drivers/char/Kconfig |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/m68k/Kconfig +3 -3
index 29dd848..ecdc19a 100644
@@ -561,7 +561,7 @@ config HPAPCI
 
 config MVME147_SCC
 	bool "SCC support for MVME147 serial ports"
-	depends on MVME147
+	depends on MVME147 && BROKEN
 	help
 	  This is the driver for the serial ports on the Motorola MVME147
 	  boards.  Everyone using one of these boards should say Y here.
@@ -576,14 +576,14 @@ config SERIAL167
 
 config MVME162_SCC
 	bool "SCC support for MVME162 serial ports"
-	depends on MVME16x
+	depends on MVME16x && BROKEN
 	help
 	  This is the driver for the serial ports on the Motorola MVME162 and
 	  172 boards.  Everyone using one of these boards should say Y here.
 
 config BVME6000_SCC
 	bool "SCC support for BVME6000 serial ports"
-	depends on BVME6000
+	depends on BVME6000 && BROKEN
 	help
 	  This is the driver for the serial ports on the BVME4000 and BVME6000
 	  boards from BVM Ltd.  Everyone using one of these boards should say
drivers/char/Kconfig +3 -3
index 08a6f50..6aad99e 100644
@@ -323,7 +323,7 @@ config SPECIALIX
 
 config SX
 	tristate "Specialix SX (and SI) card support"
-	depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
+	depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) && BROKEN
 	help
 	  This is a driver for the SX and SI multiport serial cards.
 	  Please read the file <file:Documentation/serial/sx.txt> for details.
@@ -334,7 +334,7 @@ config SX
 
 config RIO
 	tristate "Specialix RIO system support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && BROKEN
 	help
 	  This is a driver for the Specialix RIO, a smart serial card which
 	  drives an outboard box that can support up to 128 ports.  Product
@@ -395,7 +395,7 @@ config NOZOMI
 
 config A2232
 	tristate "Commodore A2232 serial support (EXPERIMENTAL)"
-	depends on EXPERIMENTAL && ZORRO && BROKEN_ON_SMP
+	depends on EXPERIMENTAL && ZORRO && BROKEN
 	---help---
 	  This option supports the 2232 7-port serial card shipped with the
 	  Amiga 2000 and other Zorro-bus machines, dating from 1989.  At
Signature · 1 line
1.6.4.2
#2 lore raw

PATCH 1/1 tty: Mark generic_serial users as BROKEN

---------- Forwarded message ----------
From: Greg Kroah-Hartman <[email protected]>
Date: Fri, Oct 30, 2009 at 23:13
Subject: [PATCH 1/1] tty: Mark generic_serial users as BROKEN
To: [email protected]
Cc: Alan Cox <[email protected]>, stable <[email protected]>, Greg Kroah-Hartman <[email protected]>

From: Alan Cox <[email protected]>

There isn't much else I can do with these. I can find no hardware for any of them and no users. The code is broken.

---
 arch/m68k/Kconfig    |    6 +++---
 drivers/char/Kconfig |    6 +++---

 2 files changed, 6 insertions(+), 6 deletions(-)
arch/m68k/Kconfig +0 -0
index 29dd848..ecdc19a 100644
@@ -561,7 +561,7 @@ config HPAPCI
 

 config MVME147_SCC
       bool "SCC support for MVME147 serial ports"
-       depends on MVME147
+       depends on MVME147 && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME147 boards.  Everyone using one of these boards should say Y here. @@ -576,14 +576,14 @@ config SERIAL167

 config MVME162_SCC
       bool "SCC support for MVME162 serial ports"
-       depends on MVME16x
+       depends on MVME16x && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME162 and 172 boards.  Everyone using one of these boards should say Y here.

 config BVME6000_SCC
       bool "SCC support for BVME6000 serial ports"
-       depends on BVME6000
+       depends on BVME6000 && BROKEN
       help
         This is the driver for the serial ports on the BVME4000 and BVME6000 boards from BVM Ltd.  Everyone using one of these boards should say

drivers/char/Kconfig +0 -0
index 08a6f50..6aad99e 100644
@@ -323,7 +323,7 @@ config SPECIALIX
 

 config SX
       tristate "Specialix SX (and SI) card support"

-       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
+       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) && BROKEN

       help
         This is a driver for the SX and SI multiport serial cards. Please read the file <file:Documentation/serial/sx.txt> for details. @@ -334,7 +334,7 @@ config SX

 config RIO
       tristate "Specialix RIO system support"
-       depends on SERIAL_NONSTANDARD
+       depends on SERIAL_NONSTANDARD && BROKEN
       help
         This is a driver for the Specialix RIO, a smart serial card which drives an outboard box that can support up to 128 ports.  Product @@ -395,7 +395,7 @@ config NOZOMI

 config A2232
       tristate "Commodore A2232 serial support (EXPERIMENTAL)"
-       depends on EXPERIMENTAL && ZORRO && BROKEN_ON_SMP
+       depends on EXPERIMENTAL && ZORRO && BROKEN
       ---help---
         This option supports the 2232 7-port serial card shipped with the Amiga 2000 and other Zorro-bus machines, dating from 1989.  At --
1.6.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Signature · 10 lines
Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#3 lore raw

Re: [PATCH 1/1] tty: Mark generic_serial users as BROKEN

In reply to Greg Kroah-Hartman
Quoted 4 lines · Greg Kroah-Hartman

From: Alan Cox <[email protected]>

There isn't much else I can do with these. I can find no hardware for any of them and no users. The code is broken.

Can you please also mention in the changelog what exactly is broken?

BTW, in response to your patch I received (private) email from people who actually
have m68k MVME boards in active use. So marking it broken may be called a regression...

Thanks!

Quoted 62 lines

---
 arch/m68k/Kconfig    |    6 +++---
 drivers/char/Kconfig |    6 +++---

 2 files changed, 6 insertions(+), 6 deletions(-)
arch/m68k/Kconfig +0 -0
index 29dd848..ecdc19a 100644
@@ -561,7 +561,7 @@ config HPAPCI
 

 config MVME147_SCC
       bool "SCC support for MVME147 serial ports"
-       depends on MVME147
+       depends on MVME147 && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME147 boards.  Everyone using one of these boards should say Y here.

arch/m68k/Kconfig +0 -0
@@ -576,14 +576,14 @@ config SERIAL167
 

 config MVME162_SCC
       bool "SCC support for MVME162 serial ports"
-       depends on MVME16x
+       depends on MVME16x && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME162 and 172 boards.  Everyone using one of these boards should say Y here.

 config BVME6000_SCC
       bool "SCC support for BVME6000 serial ports"
-       depends on BVME6000
+       depends on BVME6000 && BROKEN
       help
         This is the driver for the serial ports on the BVME4000 and BVME6000 boards from BVM Ltd.  Everyone using one of these boards should say

drivers/char/Kconfig +0 -0
index 08a6f50..6aad99e 100644
@@ -323,7 +323,7 @@ config SPECIALIX
 

 config SX
       tristate "Specialix SX (and SI) card support"

-       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
+       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) && BROKEN

       help
         This is a driver for the SX and SI multiport serial cards. Please read the file <file:Documentation/serial/sx.txt> for details.

drivers/char/Kconfig +0 -0
@@ -334,7 +334,7 @@ config SX
 

 config RIO
       tristate "Specialix RIO system support"
-       depends on SERIAL_NONSTANDARD
+       depends on SERIAL_NONSTANDARD && BROKEN
       help
         This is a driver for the Specialix RIO, a smart serial card which drives an outboard box that can support up to 128 ports.  Product

drivers/char/Kconfig +0 -0
@@ -395,7 +395,7 @@ config NOZOMI
 
Quoted 7 lines

 config A2232
       tristate "Commodore A2232 serial support (EXPERIMENTAL)"
-       depends on EXPERIMENTAL && ZORRO && BROKEN_ON_SMP
+       depends on EXPERIMENTAL && ZORRO && BROKEN
       ---help---
         This option supports the 2232 7-port serial card shipped with the Amiga 2000 and other Zorro-bus machines, dating from 1989.  At

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw

Re: [PATCH 1/1] tty: Mark generic_serial users as BROKEN

In reply to Greg Kroah-Hartman
Quoted 4 lines · Greg Kroah-Hartman

From: Alan Cox <[email protected]>

There isn't much else I can do with these. I can find no hardware for any of them and no users. The code is broken.

Can you please also mention in the changelog what exactly is broken?

BTW, in response to your patch I received (private) email from people who actually
have m68k MVME boards in active use. So marking it broken may be called a regression...

Thanks!

Quoted 62 lines

---
 arch/m68k/Kconfig    |    6 +++---
 drivers/char/Kconfig |    6 +++---

 2 files changed, 6 insertions(+), 6 deletions(-)
arch/m68k/Kconfig +0 -0
index 29dd848..ecdc19a 100644
@@ -561,7 +561,7 @@ config HPAPCI
 

 config MVME147_SCC
       bool "SCC support for MVME147 serial ports"
-       depends on MVME147
+       depends on MVME147 && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME147 boards.  Everyone using one of these boards should say Y here.

arch/m68k/Kconfig +0 -0
@@ -576,14 +576,14 @@ config SERIAL167
 

 config MVME162_SCC
       bool "SCC support for MVME162 serial ports"
-       depends on MVME16x
+       depends on MVME16x && BROKEN
       help
         This is the driver for the serial ports on the Motorola MVME162 and 172 boards.  Everyone using one of these boards should say Y here.

 config BVME6000_SCC
       bool "SCC support for BVME6000 serial ports"
-       depends on BVME6000
+       depends on BVME6000 && BROKEN
       help
         This is the driver for the serial ports on the BVME4000 and BVME6000 boards from BVM Ltd.  Everyone using one of these boards should say

drivers/char/Kconfig +0 -0
index 08a6f50..6aad99e 100644
@@ -323,7 +323,7 @@ config SPECIALIX
 

 config SX
       tristate "Specialix SX (and SI) card support"

-       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA)
+       depends on SERIAL_NONSTANDARD && (PCI || EISA || ISA) && BROKEN

       help
         This is a driver for the SX and SI multiport serial cards. Please read the file <file:Documentation/serial/sx.txt> for details.

drivers/char/Kconfig +0 -0
@@ -334,7 +334,7 @@ config SX
 

 config RIO
       tristate "Specialix RIO system support"
-       depends on SERIAL_NONSTANDARD
+       depends on SERIAL_NONSTANDARD && BROKEN
       help
         This is a driver for the Specialix RIO, a smart serial card which drives an outboard box that can support up to 128 ports.  Product

drivers/char/Kconfig +0 -0
@@ -395,7 +395,7 @@ config NOZOMI
 
Quoted 7 lines

 config A2232
       tristate "Commodore A2232 serial support (EXPERIMENTAL)"
-       depends on EXPERIMENTAL && ZORRO && BROKEN_ON_SMP
+       depends on EXPERIMENTAL && ZORRO && BROKEN
       ---help---
         This option supports the 2232 7-port serial card shipped with the Amiga 2000 and other Zorro-bus machines, dating from 1989.  At

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds