Skip to contentSkip to conversation

bluetooth/btmrl_sdio.c: Fix compile warning

PATCH In review Javier Martinez Canillas 2 participants 2 messages Oct 31, 2009 – Nov 3, 2009

Subsystems (2)
Bluetooth drivers Kernel janitors
lore
Share & tools
lore

Javier Martinez Canillas

author
#0 lore raw

PATCH 1/1 bluetooth/btmrl_sdio.c: Fix compile warning

In linux-next 20091030 I got this compile warning:

drivers/bluetooth/btmrvl_sdio.c: In function ‘btmrvl_sdio_verify_fw_download’:
drivers/bluetooth/btmrvl_sdio.c:79: warning: ‘fws1’ may be used uninitialized in this function drivers/bluetooth/btmrvl_sdio.c:79: note: ‘fws1’ was declared here

This patch solves the issue.

Signed-off-by Javier Martinez Canillas <[email protected]>
---
 drivers/bluetooth/btmrvl_sdio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/bluetooth/btmrvl_sdio.c +1 -1
index 5b33b85..41d64fd 100644
@@ -76,7 +76,7 @@ static int btmrvl_sdio_get_rx_unit(struct btmrvl_sdio_card *card)
 
 static int btmrvl_sdio_read_fw_status(struct btmrvl_sdio_card *card, u16 *dat)
 {
-	u8 fws0, fws1;
+	u8 fws0, fws1 = 0;
 	int ret;
 
 	*dat = 0;
Signature · 1 line
1.6.0.4
#1 lore raw

Hi Javier,

Quoted 7 lines

-----Original Message-----
From: Javier Martinez Canillas [mailto:[email protected]]
Sent: Friday, October 30, 2009 10:49 PM
To: Marcel Holtmann; Bing Zhao; Rahul Tank; Julia Lawall; [email protected]; kernel- [email protected]
Subject: [PATCH] bluetooth/btmrl_sdio.c: Fix compile warning

Quoted 7 lines

In linux-next 20091030 I got this compile warning:

drivers/bluetooth/btmrvl_sdio.c: In function ‘btmrvl_sdio_verify_fw_download’:
drivers/bluetooth/btmrvl_sdio.c:79: warning: ‘fws1’ may be used uninitialized in this function drivers/bluetooth/btmrvl_sdio.c:79: note: ‘fws1’ was declared here

This patch solves the issue.

Your patch is valid.

Thanks,

Bing

Quoted 20 lines
Signed-off-by Javier Martinez Canillas <[email protected]>
---
 drivers/bluetooth/btmrvl_sdio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/bluetooth/btmrvl_sdio.c +1 -2
index 5b33b85..41d64fd 100644
@@ -76,7 +76,7 @@ static int btmrvl_sdio_get_rx_unit(struct btmrvl_sdio_card *card)
 
 static int btmrvl_sdio_read_fw_status(struct btmrvl_sdio_card *card, u16 *dat)
 {
-	u8 fws0, fws1;
+	u8 fws0, fws1 = 0;
 	int ret;
 
 	*dat = 0;
--
Quoted 3 lines

1.6.0.4

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¤z¹Ş—øÚ�+h®Ïâ�Ø^n‡r¡ö¦zË�ëh™¨è­Ú&£ûàz¿äz¹Ş—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï�êÿ‘êçz_è®æj:+v‰¨ş)ߣøm