Skip to contentSkip to conversation

mkconfig: deny messed up ARCH definition

PATCH New Nishanth Menon 2 participants 2 messages Nov 2, 2009 – Nov 24, 2009

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mkconfig: deny messed up ARCH definition

Refuse to setup a platform if the command line ARCH= is not the same as the one required for the board. This prevents any user with prehistoric aliases from messing up their builds.

Reported in thread:
http://old.nabble.com/-U-Boot--Build-breaks-on-some-OMAP3-configs-to26132721.html

Inputs from: Mike Frysinger and Wolfgang Denk:
http://lists.denx.de/pipermail/u-boot/2009-November/063642.html

Cc Wolfgang Denk <[email protected]>
Cc Mike Frysinger <[email protected]>
Cc Anand Gadiyar <[email protected]>
Cc Dirk Behme <[email protected]>
---
 mkconfig |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
mkconfig +5 -0
index 4c5675b..1075510 100755
@@ -27,6 +27,11 @@ done
 [ $# -lt 4 ] && exit 1
 [ $# -gt 6 ] && exit 1
 
+if [ "${ARCH}" -a "${ARCH}" != "$2" ]; then
+	echo "Failed: \$ARCH=${ARCH}, should be '$2' for ${BOARD_NAME}" 1>&2
+	exit 1
+fi
+
 echo "Configuring for ${BOARD_NAME} board..."
 
 #
Signature · 1 line
1.6.3.3
#1 lore raw

PATCH v2 1/1 mkconfig: deny messed up ARCH definition

Dear Nishanth Menon,

Quoted 10 lines · In message <[email protected]> you wrote:

Refuse to setup a platform if the command line ARCH= is not the same as the one required for the board. This prevents any user with prehistoric aliases from messing up their builds.

Reported in thread:
http://old.nabble.com/-U-Boot--Build-breaks-on-some-OMAP3-configs-to26132721.html

Inputs from: Mike Frysinger and Wolfgang Denk:
http://lists.denx.de/pipermail/u-boot/2009-November/063642.html

Quoted 8 lines
Cc Wolfgang Denk <[email protected]>
Cc Mike Frysinger <[email protected]>
Cc Anand Gadiyar <[email protected]>
Cc Dirk Behme <[email protected]>
---
 mkconfig |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 9 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  How do you tell if you're making  love  to  a  nurse,  a  school-
    teacher, or an airline stewardess?
A:  A nurse says: "This won't hurt  a  bit."  A  schoolteacher  says:
    "We're  going to have to do this over and over again until we get
    it right." An airline stewardess says: "Just hold this over  your
    mouth and nose, and breath normally."