Skip to contentSkip to conversation

arch/powerpc: Improve _memcpy

PATCH New Dirk Eibach 1 participant 1 message Nov 3, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/powerpc: Improve _memcpy

The implementation of _memcpy_fromio and _memcpy_toio seems to be suboptimal for size 4.

---
 arch/powerpc/kernel/io.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/kernel/io.c +2 -2
index 1882bf4..8dc7547 100644
@@ -161,7 +161,7 @@ void _memcpy_fromio(void *dest, const volatile void __iomem *src,
 		dest++;
 		n--;
 	}
-	while(n > 4) {
+	while(n >= 4) {
 		*((u32 *)dest) = *((volatile u32 *)vsrc);
 		eieio();
 		vsrc += 4;
@@ -190,7 +190,7 @@ void _memcpy_toio(volatile void __iomem *dest, const void *src, unsigned long n)
 		vdest++;
 		n--;
 	}
-	while(n > 4) {
+	while(n >= 4) {
 		*((volatile u32 *)vdest) = *((volatile u32 *)src);
 		src += 4;
 		vdest += 4;
Signature · 1 line
1.5.6.5