Skip to contentSkip to conversation

powerpc/mm: Remove debug context clamping from nohash code

PATCH In review Benjamin Herrenschmidt 2 participants 3 messages Nov 4, 2009 – Nov 5, 2009 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/mm: Remove debug context clamping from nohash code

I inadvertently left that debug code enabled, causing the number of contexts to be clamped to 31 which is going to slow things down on 4xx and just plain breaks 8xx

---
 arch/powerpc/mm/mmu_context_nohash.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/mm/mmu_context_nohash.c +2 -2
index c2f93dc..be4f34c 100644
@@ -25,8 +25,8 @@
  *     also clear mm->cpu_vm_mask bits when processes are migrated
  */
 
-#define DEBUG_MAP_CONSISTENCY
-#define DEBUG_CLAMP_LAST_CONTEXT   31
+//#define DEBUG_MAP_CONSISTENCY
+//#define DEBUG_CLAMP_LAST_CONTEXT   31
 //#define DEBUG_HARDER
 
 /* We don't use DEBUG because it tends to be compiled in always nowadays
#1 lore raw
Quoted 14 lines · Benjamin Herrenschmidt

I inadvertently left that debug code enabled, causing the number of contexts to be clamped to 31 which is going to slow things down on 4xx and just plain breaks 8xx

---
arch/powerpc/mm/mmu_context_nohash.c | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/mm/mmu_context_nohash.c +0 -0
index c2f93dc..be4f34c 100644

arch/powerpc/mm/mmu_context_nohash.c line 32

Quoted 10 lines
arch/powerpc/mm/mmu_context_nohash.c +2 -2
@@ -25,8 +25,8 @@
 *     also clear mm->cpu_vm_mask bits when processes are migrated
 */
 
-#define DEBUG_MAP_CONSISTENCY
-#define DEBUG_CLAMP_LAST_CONTEXT   31
+//#define DEBUG_MAP_CONSISTENCY
+//#define DEBUG_CLAMP_LAST_CONTEXT   31
 //#define DEBUG_HARDER
 
 /* We don't use DEBUG because it tends to be compiled in always nowadays

Can you send this to stable.

- k

#2 lore raw
Quoted 26 lines · Kumar Gala
Quoted 24 lines · Benjamin Herrenschmidt

I inadvertently left that debug code enabled, causing the number of contexts to be clamped to 31 which is going to slow things down on 4xx and just plain breaks 8xx

---
arch/powerpc/mm/mmu_context_nohash.c | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/mm/ renamed from arch/powerpc/mm/mmu_context_nohash.c +0 -0

mmu_context_nohash.c
index c2f93dc..be4f34c 100644

arch/powerpc/mm/mmu_context_nohash.c +2 -2
@@ -25,8 +25,8 @@
 *     also clear mm->cpu_vm_mask bits when processes are migrated
 */
 
-#define DEBUG_MAP_CONSISTENCY
-#define DEBUG_CLAMP_LAST_CONTEXT   31
+//#define DEBUG_MAP_CONSISTENCY
+//#define DEBUG_CLAMP_LAST_CONTEXT   31
 //#define DEBUG_HARDER
 
Quoted 4 lines
Quoted 2 lines
arch/powerpc/mm/mmu_context_nohash.c +0 -0
 /* We don't use DEBUG because it tends to be compiled in always  

nowadays

Can you send this to stable.

No need. .31 doesn't have the clamp, it went in afterward afaik (my bad) though stable does have DEBUG_MAP_CONSISTENCY which you may want to remove for perfs.

Cheers,
Ben.