NET: cassini, fix lock imbalance
Subsystems (2)
PATCH 1/1 NET: cassini, fix lock imbalance
Stanse found that one error path in cas_open omits to unlock pm_mutex. Fix that.
Signed-off-by Jiri Slaby <[email protected]>
--- drivers/net/cassini.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/net/cassini.c +3 -2
@@ -4342,11 +4342,11 @@ static int cas_open(struct net_device *dev)cas_unlock_all_restore (cp, flags); } + err = -ENOMEM ;if (cas_tx_tiny_alloc (cp) <0 ) -return -ENOMEM ; + goto err_unlock;/* alloc rx descriptors */ - err = -ENOMEM ;if (cas_alloc_rxds (cp) <0 ) goto err_tx_tiny;
@@ -4386,6 +4386,7 @@ err_spare:cas_free_rxds (cp); err_tx_tiny:cas_tx_tiny_free (cp); +err_unlock:mutex_unlock (&cp->pm_mutex);return err; }
Signature · 1 line
1.6.4.2
From: Jiri Slaby <[email protected]>
Date: Fri, 6 Nov 2009 10:14:29 +0100
Quoted 4 lines
Stanse found that one error path in
cas_openomits to unlockpm_mutex. Fix that.Signed-off-by Jiri Slaby <[email protected]>
Applied to net-2.6