Skip to contentSkip to conversation

rt2x00: Fix typo in rf programming of rt2800lib.

PATCH In review Gertjan van Wingerde 1 participant 2 messages Nov 9, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 6/9 rt2x00: Fix typo in rf programming of rt2800lib.

From: Gertjan van Wingerde <[email protected]>

Fix a type in rt2800_config_channel_rt3x. The second write to RF register 2 should be to RF register 3. This is confirmed by the legacy Ralink code.

---
 drivers/net/wireless/rt2x00/rt2800lib.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/rt2x00/rt2800lib.c +1 -1
index 24b3af4..2c91c44 100644
@@ -774,7 +774,7 @@ static void rt2800_config_channel_rt3x(struct rt2x00_dev *rt2x00dev,
 	u8 rfcsr;
 
 	rt2800_rfcsr_write(rt2x00dev, 2, rf->rf1);
-	rt2800_rfcsr_write(rt2x00dev, 2, rf->rf3);
+	rt2800_rfcsr_write(rt2x00dev, 3, rf->rf3);
 
 	rt2800_rfcsr_read(rt2x00dev, 6, &rfcsr);
 	rt2x00_set_field8(&rfcsr, RFCSR6_R, rf->rf2);
Signature · 1 line
1.6.5.2
#1 lore raw
Quoted 15 lines · Gertjan van Wingerde

From: Gertjan van Wingerde <[email protected]>

Fix a type in rt2800_config_channel_rt3x. The second write to RF register 2 should be to RF register 3. This is confirmed by the legacy Ralink code.

---
 drivers/net/wireless/rt2x00/rt2800lib.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/rt2x00/rt2800lib.c +0 -0
index 24b3af4..2c91c44 100644

drivers/net/wireless/rt2x00/rt2800lib.c static void rt2800_config_channel_rt3x(struct rt2x00_dev *rt2x00dev, · line 780

Quoted 8 lines
drivers/net/wireless/rt2x00/rt2800lib.c +1 -1
@@ -774,7 +774,7 @@ static void rt2800_config_channel_rt3x(struct rt2x00_dev *rt2x00dev,
 	u8 rfcsr;
 
 	rt2800_rfcsr_write(rt2x00dev, 2, rf->rf1);
-	rt2800_rfcsr_write(rt2x00dev, 2, rf->rf3);
+	rt2800_rfcsr_write(rt2x00dev, 3, rf->rf3);
 
 	rt2800_rfcsr_read(rt2x00dev, 6, &rfcsr);
 	rt2x00_set_field8(&rfcsr, RFCSR6_R, rf->rf2);

Please disregard this one. I goofed up the subject of the email again. Will resubmit as a single patch.

---
Gertjan.