Skip to contentSkip to conversation

drm/radeon/kms: Add default 800x600 mode when getting bad EDID

PATCH In review Jerome Glisse 2 participants 2 messages Nov 12, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon/kms: Add default 800x600 mode when getting bad EDID

Adding default 800x600 mode should be a safe fail solution in front of broken EDID, user can then add new mode to fit its needs.

---
 drivers/gpu/drm/radeon/radeon_connectors.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_connectors.c +6 -2
index 292b170..4dec82e 100644
@@ -566,8 +566,10 @@ static enum drm_connector_status radeon_vga_detect(struct drm_connector *connect
 		radeon_i2c_do_lock(radeon_connector, 0);
 
 		if (!radeon_connector->edid) {
-			DRM_ERROR("DDC responded but not EDID found for %s\n",
+			DRM_ERROR("DDC responded but not EDID found for %s, adding default mode\n",
 				  drm_get_connector_name(connector));
+			if (!drm_add_modes_noedid(&radeon_connector->base, 800, 600))
+				ret = connector_status_connected;
 		} else {
 			radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
 
@@ -720,8 +722,10 @@ static enum drm_connector_status radeon_dvi_detect(struct drm_connector *connect
 		radeon_i2c_do_lock(radeon_connector, 0);
 
 		if (!radeon_connector->edid) {
-			DRM_ERROR("DDC responded but not EDID found for %s\n",
+			DRM_ERROR("DDC responded but not EDID found for %s, adding default mode\n",
 				  drm_get_connector_name(connector));
+			if (!drm_add_modes_noedid(&radeon_connector->base, 800, 600))
+				ret = connector_status_connected;
 		} else {
 			radeon_connector->use_digital = !!(radeon_connector->edid->input & DRM_EDID_INPUT_DIGITAL);
 
Signature · 1 line
1.6.5.2
#1 lore raw
Quoted 4 lines · Jerome Glisse

Adding default 800x600 mode should be a safe fail solution in front of broken EDID, user can then add new mode to fit its needs.

Forget this patch a better one is coming.

Cheers,
Jerome Glisse