smsc911x: Fix Console Hang when bringing the interface down.
Subsystems (2)
PATCH 1/1 smsc911x: Fix Console Hang when bringing the interface down.
In the NAPI poll function, check for netif_running() is unnecassary. In addition to associated runtime overhead, it also results in continuous softirq loop when the interface is brought down under heavy traffic(tested with Traffic Generator).Once the interface is disabled, the poll function always returns zero(with the check for netif_running) and napi_complete() would never get called resulting in softirq loop.
---
Fix has been validated on OMAP3EVM. Similar issue found with TI Davinci EMAC driver for which a patch has been posted to this list.
drivers/net/smsc911x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/smsc911x.c +1 -1
@@ -986,7 +986,7 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)struct net_device *dev = pdata->dev;int npackets =0 ; -while (likely (netif_running (dev)) && (npackets < budget)) { +while (npackets < budget) {unsigned int pktlength;unsigned int pktwords;struct sk_buff *skb;
Signature · 1 line
1.6.2.4
From: Sriramakrishnan <[email protected]>
Date: Thu, 12 Nov 2009 17:44:38 +0530
Quoted 8 lines
In the NAPI poll function, check for
netif_running()is unnecassary. In addition to associated runtime overhead, it also results in continuous softirq loop when the interface is brought down under heavy traffic(tested with Traffic Generator).Once the interface is disabled, the poll function always returnszero(with the check for netif_running)andnapi_complete()would never get called resulting in softirq loop.Signed-off-by Sriramakrishnan <[email protected]>
Applied to net-2.6