Skip to contentSkip to conversation

smsc911x: Fix Console Hang when bringing the interface down.

PATCH Applied Sriramakrishnan 2 participants 2 messages Nov 12, 2009 – Nov 16, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smsc911x: Fix Console Hang when bringing the interface down.

In the NAPI poll function, check for netif_running() is unnecassary. In addition to associated runtime overhead, it also results in continuous softirq loop when the interface is brought down under heavy traffic(tested with Traffic Generator).Once the interface is disabled, the poll function always returns zero(with the check for netif_running) and napi_complete() would never get called resulting in softirq loop.

---
Fix has been validated on OMAP3EVM. Similar issue found with TI Davinci EMAC driver for which a patch has been posted to this list.

 drivers/net/smsc911x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/smsc911x.c +1 -1
index ccdd196..f9cdcbc 100644
@@ -986,7 +986,7 @@ static int smsc911x_poll(struct napi_struct *napi, int budget)
 	struct net_device *dev = pdata->dev;
 	int npackets = 0;
 
-	while (likely(netif_running(dev)) && (npackets < budget)) {
+	while (npackets < budget) {
 		unsigned int pktlength;
 		unsigned int pktwords;
 		struct sk_buff *skb;
Signature · 1 line
1.6.2.4
maintainer Applied
#1 lore raw

From: Sriramakrishnan <[email protected]>
Date: Thu, 12 Nov 2009 17:44:38 +0530

Quoted 8 lines

In the NAPI poll function, check for netif_running() is unnecassary. In addition to associated runtime overhead, it also results in continuous softirq loop when the interface is brought down under heavy traffic(tested with Traffic Generator).Once the interface is disabled, the poll function always returns zero(with the check for netif_running) and napi_complete() would never get called resulting in softirq loop.

Applied to net-2.6