gst-plugins-bad dependencies fix
The following patches fix dependencies problems I had seen when compiling the gst-plugins-bad package.
The thing is that the configure script did not raised any error on missing librairies (libcdaudio, libdvdread, libdvdnav and openssl), I just got error at compilation/link time (missing headers, missing library at link). I guess there is something wrong with the check of those packages (there are probably not using pkg-config), because they are installed on my host system and detected when cross compiling. Anyway, those patches still fix a real problem.
Here the patch list :
[PATCH 1/6] Added libcdaudio package (dependency of gst-plugins-bad) [PATCH 2/6] Fix gst-plugins-bad dependency on libcdaudio
[PATCH 3/6] Fix gst-plugins-bad dependency on openssl through the apexsink element [PATCH 4/6] Added libdvdread package (dependency of gst-plugins-bad) [PATCH 5/6] Added libdvdnav package (dependency of gst-plugins-bad) [PATCH 6/6] Fix gst-plugins-bad dependency on libdvdnav
--
Lionel Landwerlin <[email protected]>
PATCH 1/6 Added libcdaudio package (dependency of gst-plugins-bad)
From: Lionel Landwerlin <[email protected]>
--- package/multimedia/Config.in | 1 + package/multimedia/libcdaudio/Config.in | 6 ++++++ package/multimedia/libcdaudio/libcdaudio.mk | 15 +++++++++++++++ 3 files changed, 22 insertions(+), 0 deletions(-) create mode 100644 package/multimedia/libcdaudio/Config.in create mode 100644 package/multimedia/libcdaudio/libcdaudio.mk
package/multimedia/Config.in +1 -0
@@ -9,6 +9,7 @@ source "package/multimedia/gst-plugins-base/Config.in" source "package/multimedia/gst-plugins-good/Config.in" source "package/multimedia/gst-plugins-bad/Config.in" source "package/multimedia/gst-plugins-ugly/Config.in" +source "package/multimedia/libcdaudio/Config.in" source "package/multimedia/libid3tag/Config.in" source "package/multimedia/libmad/Config.in" source "package/multimedia/libmms/Config.in"
package/multimedia/libcdaudio/Config.in new file +6 -0
@@ -0,0 +1,6 @@ +config BR2_PACKAGE_LIBCDAUDIO + bool "libcdaudio" + help + libcdaudio is a library designed to provide functions to + control operation of a CD-ROM when playing audio CDs. It + also contains functions for CDDB and CD Index lookup.
package/multimedia/libcdaudio/libcdaudio.mk new file +15 -0
@@ -0,0 +1,15 @@ +############################################################# +# +# libcdaudio +# +############################################################# + +LIBCDAUDIO_VERSION = 0.99.12p2 +LIBCDAUDIO_SOURCE = libcdaudio-$(LIBCDAUDIO_VERSION).tar.gz +LIBCDAUDIO_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/libcdaudio/libcdaudio/$(LIBCDAUDIO_VERSION)/ +LIBCDAUDIO_AUTORECONF = YES +LIBCDAUDIO_LIBTOOL_PATCH = YES +LIBCDAUDIO_INSTALL_STAGING = YES +LIBCDAUDIO_INSTALL_TARGET = YES + +$(eval $(call AUTOTARGETS,package,libcdaudio))
Signature · 1 line
1.6.5.2
PATCH 1/6 Added libcdaudio package (dependency of gst-plugins-bad)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
Committed with minor changes, thanks!
llandwerlin> +config BR2_PACKAGE_LIBCDAUDIO
llandwerlin> + bool "libcdaudio"
llandwerlin> + help
llandwerlin> + libcdaudio is a library designed to provide functions to llandwerlin> + control operation of a CD-ROM when playing audio CDs. It llandwerlin> + also contains functions for CDDB and CD Index lookup.
We normally add the upstream URL here.
llandwerlin> diff --git a/package/multimedia/libcdaudio/libcdaudio.mk b/package/multimedia/libcdaudio/libcdaudio.mk llandwerlin> new file mode 100644
llandwerlin> index 0000000..f05b532
llandwerlin> --- /dev/null
llandwerlin> +++ b/package/multimedia/libcdaudio/libcdaudio.mk
llandwerlin> @@ -0,0 +1,15 @@
llandwerlin> +#############################################################
llandwerlin> +#
llandwerlin> +# libcdaudio
llandwerlin> +#
llandwerlin> +#############################################################
llandwerlin> +
llandwerlin> +LIBCDAUDIO_VERSION = 0.99.12p2
llandwerlin> +LIBCDAUDIO_SOURCE = libcdaudio-$(LIBCDAUDIO_VERSION).tar.gz
llandwerlin> +LIBCDAUDIO_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/libcdaudio/libcdaudio/$(LIBCDAUDIO_VERSION)/
llandwerlin> +LIBCDAUDIO_AUTORECONF = YES
llandwerlin> +LIBCDAUDIO_LIBTOOL_PATCH = YES
llandwerlin> +LIBCDAUDIO_INSTALL_STAGING = YES
llandwerlin> +LIBCDAUDIO_INSTALL_TARGET = YES
llandwerlin> +
llandwerlin> +$(eval $(call AUTOTARGETS,package,libcdaudio))
The package directory you're using is package/multimedia.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 2/6 Fix gst-plugins-bad dependency on libcdaudio
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/gst-plugins-bad/Config.in | 4 ++++ .../multimedia/gst-plugins-bad/gst-plugins-bad.mk | 7 +++++++ 2 files changed, 11 insertions(+), 0 deletions(-)
package/multimedia/gst-plugins-bad/Config.in +4 -0
@@ -33,6 +33,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_LEGACYRESAMPLE config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_BAYER bool "bayer" +config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDAUDIO + bool "cdaudio" + select BR2_PACKAGE_LIBCDAUDIO + config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDXAPARSE bool "cdxaparse"
package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +7 -0
@@ -63,6 +63,13 @@ else GST_PLUGINS_BAD_CONF_OPT += --disable-cdxaparse endif +ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDAUDIO),y) +GST_PLUGINS_BAD_CONF_OPT += --enable-cdaudio +GST_PLUGINS_BAD_DEPENDENCIES += libcdaudio +else +GST_PLUGINS_BAD_CONF_OPT += --disable-cdaudio +endif + ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DCCP),y) GST_PLUGINS_BAD_CONF_OPT += --enable-dccp else
Signature · 1 line
1.6.5.2
PATCH 3/6 Fix gst-plugins-bad dependency on openssl through the apexsink element
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/gst-plugins-bad/Config.in | 4 ++++ .../multimedia/gst-plugins-bad/gst-plugins-bad.mk | 7 +++++++ 2 files changed, 11 insertions(+), 0 deletions(-)
package/multimedia/gst-plugins-bad/Config.in +4 -0
@@ -21,6 +21,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AIFFPARSE config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AMRPARSE bool "amrparse" +config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK + bool "apexsink" + select BR2_PACKAGE_OPENSSL + config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AUTOCONVERT bool "autoconvert"
package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +7 -0
@@ -33,6 +33,13 @@ else GST_PLUGINS_BAD_CONF_OPT += --disable-amrparse endif +ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK),y) +GST_PLUGINS_BAD_CONF_OPT += --enable-apexsink +GST_PLUGINS_BAD_DEPENDENCIES += openssl +else +GST_PLUGINS_BAD_CONF_OPT += --disable-apexsink +endif + ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AUTOCONVERT),y) GST_PLUGINS_BAD_CONF_OPT += --enable-autoconvert else
Signature · 1 line
1.6.5.2
PATCH 4/6 Added libdvdread package (dependency of gst-plugins-bad)
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/Config.in | 1 + package/multimedia/libdvdread/Config.in | 5 +++++ package/multimedia/libdvdread/libdvdread.mk | 15 +++++++++++++++ 3 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 package/multimedia/libdvdread/Config.in create mode 100644 package/multimedia/libdvdread/libdvdread.mk
package/multimedia/Config.in +1 -0
@@ -10,6 +10,7 @@ source "package/multimedia/gst-plugins-good/Config.in" source "package/multimedia/gst-plugins-bad/Config.in" source "package/multimedia/gst-plugins-ugly/Config.in" source "package/multimedia/libcdaudio/Config.in" +source "package/multimedia/libdvdread/Config.in" source "package/multimedia/libid3tag/Config.in" source "package/multimedia/libmad/Config.in" source "package/multimedia/libmms/Config.in"
package/multimedia/libdvdread/Config.in new file +5 -0
@@ -0,0 +1,5 @@ +config BR2_PACKAGE_LIBDVDREAD + bool "libdvdread" + help + libdvdread provides a simple foundation for reading + DVD-Video images.
package/multimedia/libdvdread/libdvdread.mk new file +15 -0
@@ -0,0 +1,15 @@ +############################################################# +# +# libdvdread +# +############################################################# + +LIBDVDREAD_VERSION = 4.1.3 +LIBDVDREAD_SOURCE = libdvdread_$(LIBDVDREAD_VERSION).orig.tar.gz +LIBDVDREAD_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdread/ +LIBDVDREAD_AUTORECONF = YES +LIBDVDREAD_LIBTOOL_PATCH = YES +LIBDVDREAD_INSTALL_STAGING = YES +LIBDVDREAD_INSTALL_TARGET = YES + +$(eval $(call AUTOTARGETS,package,libdvdread))
Signature · 1 line
1.6.5.2
PATCH 5/6 Added libdvdnav package (dependency of gst-plugins-bad)
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/Config.in | 1 + package/multimedia/libdvdnav/Config.in | 7 +++++++ package/multimedia/libdvdnav/libdvdnav.mk | 21 +++++++++++++++++++++ 3 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 package/multimedia/libdvdnav/Config.in create mode 100644 package/multimedia/libdvdnav/libdvdnav.mk
package/multimedia/Config.in +1 -0
@@ -11,6 +11,7 @@ source "package/multimedia/gst-plugins-bad/Config.in" source "package/multimedia/gst-plugins-ugly/Config.in" source "package/multimedia/libcdaudio/Config.in" source "package/multimedia/libdvdread/Config.in" +source "package/multimedia/libdvdnav/Config.in" source "package/multimedia/libid3tag/Config.in" source "package/multimedia/libmad/Config.in" source "package/multimedia/libmms/Config.in"
package/multimedia/libdvdnav/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_LIBDVDNAV + bool "libdvdnav" + select BR2_PACKAGE_LIBDVDREAD + help + libdvdnav is a library that allows easy use of sophisticated + DVD navigation features such as DVD menus, multiangle + playback and even interactive DVD games.
package/multimedia/libdvdnav/libdvdnav.mk new file +21 -0
@@ -0,0 +1,21 @@ +############################################################# +# +# libdvdnav +# +############################################################# + +LIBDVDNAV_VERSION = 4.1.3 +LIBDVDNAV_SOURCE = libdvdnav_$(LIBDVDNAV_VERSION).orig.tar.gz +LIBDVDNAV_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdnav/ +LIBDVDNAV_AUTORECONF = YES +LIBDVDNAV_LIBTOOL_PATCH = YES +LIBDVDNAV_INSTALL_STAGING = YES +LIBDVDNAV_INSTALL_TARGET = YES + +LIBDVDNAV_DEPENDENCIES = libdvdread + +# By default libdvdnav tries to find dvdread-config in $PATH. Because +# of cross compilation, we prefer using pkg-config. +LIBDVDNAV_CONF_OPT = --with-dvdread-config="$(PKG_CONFIG_HOST_BINARY) dvdread" + +$(eval $(call AUTOTARGETS,package,libdvdnav))
Signature · 1 line
1.6.5.2
PATCH 5/6 Added libdvdnav package (dependency of gst-plugins-bad)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> +++ b/package/multimedia/libdvdnav/Config.in llandwerlin> @@ -0,0 +1,7 @@
llandwerlin> +config BR2_PACKAGE_LIBDVDNAV
llandwerlin> + bool "libdvdnav"
llandwerlin> + select BR2_PACKAGE_LIBDVDREAD
llandwerlin> + help
llandwerlin> + libdvdnav is a library that allows easy use of sophisticated llandwerlin> + DVD navigation features such as DVD menus, multiangle llandwerlin> + playback and even interactive DVD games.
Same issues as with cdaudio, but I've fixed that myself - Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 5/6 Added libdvdnav package (dependency of gst-plugins-bad)
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
"Peter" == Peter Korsgaard <[email protected]> writes:
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> +++ b/package/multimedia/libdvdnav/Config.in llandwerlin> @@ -0,0 +1,7 @@
llandwerlin> +config BR2_PACKAGE_LIBDVDNAV
llandwerlin> + bool "libdvdnav"
llandwerlin> + select BR2_PACKAGE_LIBDVDREAD
llandwerlin> + help
llandwerlin> + libdvdnav is a library that allows easy use of sophisticated llandwerlin> + DVD navigation features such as DVD menus, multiangle llandwerlin> + playback and even interactive DVD games.
Peter> Same issues as with cdaudio, but I've fixed that myself - Committed, Peter> thanks.
Ups, that comment was for libdvdread (but applies here as well).
Signature · 1 line
Bye, Peter Korsgaard
PATCH 6/6 Fix gst-plugins-bad dependency on libdvdnav
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/gst-plugins-bad/Config.in | 4 ++++ .../multimedia/gst-plugins-bad/gst-plugins-bad.mk | 7 +++++++ 2 files changed, 11 insertions(+), 0 deletions(-)
package/multimedia/gst-plugins-bad/Config.in +4 -0
@@ -53,6 +53,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DEBUGUTILS config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DTMF bool "dtmf" +config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV + bool "dvdnav" + select BR2_PACKAGE_LIBDVDNAV + config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU bool "dvdspu"
package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +7 -0
@@ -95,6 +95,13 @@ else GST_PLUGINS_BAD_CONF_OPT += --disable-dtmf endif +ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV),y) +GST_PLUGINS_BAD_CONF_OPT += --enable-dvdnav +GST_PLUGINS_BAD_DEPENDENCIES += libdvdnav +else +GST_PLUGINS_BAD_CONF_OPT += --disable-dvdnav +endif + ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU),y) GST_PLUGINS_BAD_CONF_OPT += --enable-dvdspu else
Signature · 1 line
1.6.5.2
PATCH 6/6 Fix gst-plugins-bad dependency on libdvdnav
Hi Peter,
Didn't you forgot this patch ?
Regards,
Le jeudi 12 novembre 2009 ? 23:33 +0100, llandwerlin at gmail.com a ?crit :
Quoted 41 lines
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>--- package/multimedia/gst-plugins-bad/Config.in | 4 ++++ .../multimedia/gst-plugins-bad/gst-plugins-bad.mk | 7 +++++++ 2 files changed, 11 insertions(+), 0 deletions(-)package/multimedia/gst-plugins-bad/Config.in +4
-0@@ -53,6 +53,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DEBUGUTILS config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DTMF bool "dtmf" +config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV + bool "dvdnav" + select BR2_PACKAGE_LIBDVDNAV + config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU bool "dvdspu"package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +7
-0@@ -95,6 +95,13 @@ else GST_PLUGINS_BAD_CONF_OPT += --disable-dtmf endif +ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV),y) +GST_PLUGINS_BAD_CONF_OPT += --enable-dvdnav +GST_PLUGINS_BAD_DEPENDENCIES += libdvdnav +else +GST_PLUGINS_BAD_CONF_OPT += --disable-dvdnav +endif + ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU),y) GST_PLUGINS_BAD_CONF_OPT += --enable-dvdspu else
Signature · 1 line
Lionel Landwerlin
PATCH 6/6 Fix gst-plugins-bad dependency on libdvdnav
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == Lionel Landwerlin <[email protected]> writes:
Lionel> Hi Peter,
Lionel> Didn't you forgot this patch ?
It indeed seems I did - Sorry about that, comitted now.
Signature · 1 line
Bye, Peter Korsgaard
Quoted 2 lines · llandwerlin at gmail.com
The following patches fix dependencies problems I had seen when compiling the gst-plugins-bad package.
I have reviewed your patches once more and this looks good to me. Peter, can you please incorporate this patchset?
Thanks,
Sven
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sven" == Sven Neumann <[email protected]> writes:
Quoted 2 lines · llandwerlin at gmail.com
Quoted 2 lines
The following patches fix dependencies problems I had seen when compiling the gst-plugins-bad package.
Sven> I have reviewed your patches once more and this looks good to me. Peter, Sven> can you please incorporate this patchset?
Yes, I'll hopefully get around to do so tomorrow.
Thanks for the review.
Signature · 1 line
Bye, Peter Korsgaard
Thx guys.
Quoted 16 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Sven" == Sven Neumann <[email protected]> writes:
?Sven> On Thu, 2009-11-12 at 23:33 +0100, llandwerlin at gmail.com wrote:
?>> The following patches fix dependencies problems I had seen when ?>> compiling the gst-plugins-bad package.?Sven> I have reviewed your patches once more and this looks good to me. Peter, ?Sven> can you please incorporate this patchset?
Yes, I'll hopefully get around to do so tomorrow.
Thanks for the review.
--
Bye, Peter Korsgaard