nilfs2: trivial cleanups
cover nilfs2: trivial cleanups
Hi,
This is trival cleanup patch series.
First patch deleted unused struct nilfs_dat_group_desc.
Second patch deleted inconsistent comment.
fs/nilfs2/inode.c | 1 - include/linux/nilfs2_fs.h | 9 --------- 2 files changed, 0 insertions(+), 10 deletions(-)
A message that is not in the archive (sent off-list or not yet received): 1258260585-3479-1-git-send-email-jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org
PATCH 1/2 nilfs2: deleted struct nilfs_dat_group_desc
struct nilfs_dat_group_desc is not used both in kernel and user spaces. struct nilfs_palloc_group_desc is used instead.
--- include/linux/nilfs2_fs.h | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-)
include/linux/nilfs2_fs.h +0 -9
@@ -425,15 +425,6 @@ struct nilfs_dat_entry { };/** -* struct nilfs_dat_group_desc - block group descriptor -* @dg_nfrees: number of free virtual block numbers in block group -*/ -struct nilfs_dat_group_desc { -__le32 dg_nfrees; -}; - - -/** * struct nilfs_snapshot_list - snapshot list * @ssl_next: next checkpoint number on snapshot list * @ssl_prev: previous checkpoint number on snapshot list
Signature · 1 line
1.5.6.5
PATCH 2/2 nilfs2: deleted inconsistent comment in nilfs_load_inode_block()
In reply to a message not in the archiveThe comment says, "Caller of this function MUST lock s_inode_lock", however just above the comment, it locks s_inode_lock in the function.
--- fs/nilfs2/inode.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
fs/nilfs2/inode.c +0 -1
@@ -664,7 +664,6 @@ int nilfs_load_inode_block(struct nilfs_sb_info *sbi, struct inode *inode,int err;spin_lock (&sbi->s_inode_lock); -/* Caller of this function MUST lock s_inode_lock */ if (ii->i_bh ==NULL ) {spin_unlock (&sbi->s_inode_lock); err = nilfs_ifile_get_inode_block(sbi->s_ifile, inode->i_ino,
Signature · 1 line
1.5.6.5
Ryusuke Konishi
AppliedQuoted 4 lines · Jiro SEKIBA
Hi,
This is trival cleanup patch series.
Quoted 8 lines
First patch deleted unused struct
nilfs_dat_group_desc.Second patch deleted inconsistent comment.
fs/nilfs2/inode.c | 1 - include/linux/nilfs2_fs.h | 9 --------- 2 files changed, 0 insertions(+), 10 deletions(-)
Applied. Thank you!
Ryusuke Konishi