giantec,gt24c04a eeproms for qnap ts433
Heiko Stuebner
maintainercover giantec,gt24c04a eeproms for qnap ts433
Add the binding and dt-nodes for the product-data eeproms on the TS433.
Heiko Stuebner (2):
dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
arm64: dts: rockchip: add product-data eeproms to QNAP TS433
.../devicetree/bindings/eeprom/at24.yaml | 1 + .../boot/dts/rockchip/rk3568-qnap-ts433.dts | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+)
Signature · 1 line
2.39.2
Heiko Stuebner
maintainerPATCH 1/2 dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
The gt24c04a is just yet another 2404 compatible eeprom, and does not follow the generic naming matching, so add a separate compatible for it.
--- Documentation/devicetree/bindings/eeprom/at24.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at24.yaml +1 -0
@@ -116,6 +116,7 @@ properties: - const: atmel,24c02 - items: - enum: + - giantec,gt24c04a - onnn,cat24c04 - onnn,cat24c05 - rohm,br24g04
Signature · 1 line
2.39.2
Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
Quoted 6 lines · Heiko Stuebner
The gt24c04a is just yet another 2404 compatible eeprom, and does not follow the generic naming matching, so add a separate compatible for it.
Signed-off-by Heiko Stuebner <[email protected]>--- Documentation/devicetree/bindings/eeprom/at24.yaml | 1 +
Best regards,
Krzysztof
Bartosz Golaszewski
AppliedRe: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
In reply to Heiko StuebnerFrom: Bartosz Golaszewski <[email protected]>
Quoted 4 lines · Heiko Stuebner
The gt24c04a is just yet another 2404 compatible eeprom, and does not follow the generic naming matching, so add a separate compatible for it.
Applied, thanks!
[1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>
Heiko Stübner
maintainerRe: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
Hi,
Am Sonntag, 11. August 2024, 21:27:13 CEST schrieb Bartosz Golaszewski:
Quoted 9 lines
From: Bartosz Golaszewski <[email protected]>
Quoted 4 lines · Heiko Stuebner
The gt24c04a is just yet another 2404 compatible eeprom, and does not follow the generic naming matching, so add a separate compatible for it.
Quoted 4 lines
Applied, thanks!
[1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89
just for my understanding, where is this commit living now?
Because linux next seems to know it [0], but also says that "Notice: this object is not reachable from any branch."
Thanks
Heiko
Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
Quoted 20 lines · Heiko Stübner
Hi,
Am Sonntag, 11. August 2024, 21:27:13 CEST schrieb Bartosz Golaszewski:
Quoted 9 lines
From: Bartosz Golaszewski <[email protected]>
Quoted 4 lines · Heiko Stuebner
The gt24c04a is just yet another 2404 compatible eeprom, and does not follow the generic naming matching, so add a separate compatible for it.
Quoted 4 lines
Applied, thanks!
[1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89just for my understanding, where is this commit living now?
Quoted 10 lines
Because linux next seems to know it [0], but also says that "Notice: this object is not reachable from any branch."
Thanks
Heiko
It lives in my kernel.org tree[1]. You can get that information from the MAINTAINERS file.
Bart
[1] https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git/log/?h=at24/for-next
Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
Quoted 15 lines · Bartosz Golaszewski
Quoted 15 lines
Quoted 5 lines
Applied, thanks!
[1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89just for my understanding, where is this commit living now?
Because linux next seems to know it [0], but also says that "Notice: this object is not reachable from any branch."
Thanks
Heiko
Quoted 6 lines
Quoted 3 lines
It lives in my kernel.org tree[1]. You can get that information from the
MAINTAINERSfile.
Or use simple template - only one entry needed:
b4.thanks-commit-url-mask = https://git.kernel.org/MR_FOO/linux/c/%s
page 44 of PDF:
https://lpc.events/event/17/contributions/1498/#preview:2452
Best regards,
Krzysztof
Heiko Stuebner
maintainerPATCH 2/2 arm64: dts: rockchip: add product-data eeproms to QNAP TS433
In reply to Heiko StuebnerThe device contains two i2c-connected eeproms holding some product- specific values. One sitting on the mainboard and one on the statically connected backplane.
While the eeprom chips themself have a size of 512 byte, the eeprom data only uses 256 byte each, probably to stay compatible with other models.
--- .../boot/dts/rockchip/rk3568-qnap-ts433.dts | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts +20 -0
@@ -458,6 +458,26 @@ rtc_rv8263: rtc@51 { reg = <0x51>; wakeup-source; }; + + /* eeprom for vital-product-data on the mainboard */ + eeprom@54 { + compatible = "giantec,gt24c04a", "atmel,24c04"; + reg = <0x54>; + label = "VPD_MB"; + num-addresses = <2>; + pagesize = <16>; + read-only; + }; + + /* eeprom for vital-product-data on the backplane */ + eeprom@56 { + compatible = "giantec,gt24c04a", "atmel,24c04"; + reg = <0x56>; + label = "VPD_BP"; + num-addresses = <2>; + pagesize = <16>; + read-only; + }; }; &mdio0 {
Signature · 1 line
2.39.2
Re: (subset) [PATCH 0/2] giantec,gt24c04a eeproms for qnap ts433
In reply to Heiko StuebnerQuoted 11 lines · Heiko Stuebner
Add the binding and dt-nodes for the product-data eeproms on the TS433.
Heiko Stuebner (2):
dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
arm64: dts: rockchip: add product-data eeproms to QNAP TS433
.../devicetree/bindings/eeprom/at24.yaml| 1 +.../boot/dts/rockchip/rk3568-qnap-ts433.dts | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+)[...]
Applied, thanks!
[2/2] arm64: dts: rockchip: add product-data eeproms to QNAP TS433
commit: da6f4130234448122fe3e66c8116f7d9eea8a5c7
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>