Skip to contentSkip to conversation

net: PPP buffer too small for higher speed connections

PATCH Applied fangxiaozhi 00110321 4 participants 5 messages Nov 17, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 net: PPP buffer too small for higher speed connections

From: fangxiaozhi <[email protected]>
1. This patch is based on the kernel of 2.6.32-rc7
2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.

-----------------------------------------------------------------------------------------

drivers/net/ppp_async.c +1 -1
@@ -36,7 +36,7 @@
 
 #define PPP_VERSION	"2.4.2"
 
-#define OBUFSIZE	256
+#define OBUFSIZE	4096
 
 /* Structure for storing local state. */
 struct asyncppp {

******************************************************************************************
This email and its attachments contain confidential information from HUAWEI, which is intended only for the person or entity whose address is listed above. Any use of the information contained here in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it!
*****************************************************************************************

maintainer Applied
#1 lore raw

From: fangxiaozhi 00110321 <[email protected]>
Date: Tue, 17 Nov 2009 19:59:05 +0800

Quoted 4 lines

From: fangxiaozhi <[email protected]>
1. This patch is based on the kernel of 2.6.32-rc7
2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.

Applied to net-next-2.6, thanks.

#2 lore raw

Well, that's great.

Thanks very much for your help.
----- Original Message -----
From: "David Miller" <[email protected]>
To: <[email protected]>
Cc: <[email protected]>; <[email protected]>; <[email protected]>; <[email protected]>
Sent: Tuesday, November 17, 2009 8:02 PM
Subject: Re: [PATCH 1/5]net: PPP buffer too small for higher speed connections

Quoted 9 lines

From: fangxiaozhi 00110321 <[email protected]>
Date: Tue, 17 Nov 2009 19:59:05 +0800

Quoted 4 lines

From: fangxiaozhi <[email protected]>
1. This patch is based on the kernel of 2.6.32-rc7
2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.

Applied to net-next-2.6, thanks.

#3 lore raw
In reply to fangxiaozhi 00110321
Quoted 8 lines · On Tue, Nov 17, 2009 at 07:59:05PM +0800, fangxiaozhi 00110321 wrote:

From: fangxiaozhi <[email protected]>
1. This patch is based on the kernel of 2.6.32-rc7
2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.

-----------------------------------------------------------------------------------------

drivers/net/ppp_async.c line 42

Quoted 8 lines
drivers/net/ppp_async.c +1 -1
@@ -36,7 +36,7 @@
 
 #define PPP_VERSION	"2.4.2"
 
-#define OBUFSIZE	256
+#define OBUFSIZE	4096
 
 /* Structure for storing local state. */
 struct asyncppp {

I don't know what an HSUPA connection is, so what kind of speed is that? I am just wondering if this would affect ppp on other connections that are async (in a positive manner that is).

Signature · 1 line
Len Sorensen
#4 lore raw
Quoted 12 lines · Lennart Sorensen
Quoted 11 lines · On Tue, Nov 17, 2009 at 07:59:05PM +0800, fangxiaozhi 00110321 wrote:

From: fangxiaozhi <[email protected]>
1. This patch is based on the kernel of 2.6.32-rc7
2. In this patch, we enlarge the out buffer size to optimize the upload speed for the ppp connection. Then it can support the upload of HSUPA data cards.

-----------------------------------------------------------------------------------------

drivers/net/ppp_async.c +0 -0
@@ -36,7 +36,7 @@
 
 #define PPP_VERSION	"2.4.2"
 
Quoted 7 lines

drivers/net/ppp_async.c line 42

Quoted 5 lines
drivers/net/ppp_async.c +1 -1
-#define OBUFSIZE	256
+#define OBUFSIZE	4096
 
 /* Structure for storing local state. */
 struct asyncppp {

I don't know what an HSUPA connection is, so what kind of speed is that?

(Google and Wikipedia know everything and are only a click away...)

High-Speed Uplink Packet Access is a enhancement for around 5.7Mbps uplinks on mobile broadband networks based on GSM/UMTS standards.

In the end, what all the mobile manufacturers like Huawei should already be doing is converting their devices to use an AT-based control port and a netdev-based data port like Option (hso) and Ericsson (cdc-acm and cdc-ether) already have. Then we don't need to do the useless PPP session between the host and the card. With GSM/UMTS/HSPA, PPP never goes over the air, it's purely between the card and the host. And thus is pointless and a netdev-type architecture would work a lot better.

Dan

Quoted 3 lines

I am just wondering if this would affect ppp on other connections that are async (in a positive manner that is).