Skip to contentSkip to conversation

kernel.bbclass: Move do_menuconfigure after do_configure.

PATCH In review Leon Woestenberg 3 participants 4 messages Nov 18, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel.bbclass: Move do_menuconfigure after do_configure.

Currently, menuconfigure comes after the patch task and before the configure task. If someone runs the menuconfigure task, then builds the kernel, the configure task will overwrite the configuration just edited. This is unexpected and/or unwanted behaviour.

Rather moved menuconfigure past configure, so that the OpenEmbedded supplied defconfig can be edited afterwards.

---
 classes/kernel.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
classes/kernel.bbclass +1 -1
index 9c1f637..cf7cc4f 100644
@@ -218,7 +218,7 @@ do_menuconfig() {
 	fi
 }
 do_menuconfig[nostamp] = "1"
-addtask menuconfig after do_patch
+addtask menuconfig after do_configure
 
 pkg_postinst_kernel () {
 	cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
Signature · 1 line
1.6.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 36 lines · Leon Woestenberg

Currently, menuconfigure comes after the patch task and before the configure task. If someone runs the menuconfigure task, then builds the kernel, the configure task will overwrite the configuration just edited. This is unexpected and/or unwanted behaviour.

Rather moved menuconfigure past configure, so that the OpenEmbedded supplied defconfig can be edited afterwards.

---
 classes/kernel.bbclass |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
classes/kernel.bbclass +0 -0
index 9c1f637..cf7cc4f 100644
@@ -218,7 +218,7 @@ do_menuconfig() {

       fi
 }
 do_menuconfig[nostamp] = "1"

classes/kernel.bbclass +1 -1
-addtask menuconfig after do_patch
+addtask menuconfig after do_configure

 pkg_postinst_kernel () {
       cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true --
1.6.0.4

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 3 lines
Otavio Salvador                  O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br
#3 lore raw

Hello,

Quoted 5 lines · Przemyslaw Wesolek
Quoted 1 line · Otavio Salvador

For not to make a confusion: this was already commited from the other patch.

Indeed, I removed both entries from the patchwork queue.

Thanks for bringing it up.

Regards,

Signature · 1 line
Leon