Skip to contentSkip to conversation

MIPS: Add a high precision sched_clock() via cnt32_to_63().

PATCH In review Wu Zhangjin 1 participant 2 messages Nov 20, 2009 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: Add a high precision sched_clock() via cnt32_to_63().

From: Wu Zhangjin <[email protected]>

MIPS uses the jiffies based sched_clock(), the precision is very low(about 10ms with 1000 HZ), which is not enough for some places. a very obvious example is Ftracer.

Ftracer is originally designed for real time tracing, but without a high precision sched_clock(), the timestamp information will be totally garbage. So, we need to find a high precision sched_clock().

In the past series of patchset of "ftrace for MIPS", I have implemented such a sched_clock(), which is based on the 32-bit long MIPS c0 count and the timecounter/cyclecounter stuff in include/linux/clocksource.h.

That sched_clock() did work well for Ftracer, but touched several places of the core of Ftracer. and also, that one is only enabled for Ftracer.

In the v8 revision of "ftrace for MIPS", Thomas Gleixner recommended to enable sched_clock() for the whole system and re-implement it via the cnt32_to_63() stuff in include/linux/cnt32_to_63.h.

Just had a look at the cnt32_to_64() and some implementations in arch/arm/, and then cloned one for MIPS from arch/arm/plat-orion/time.c.

Of course, this is a "rude" version, perhaps we need to consider more for different MIPSs(something like what have been done in arch/arm/plat-orion/time.c). and also, the overhead is needed to be measured. Herein just list the difference between the old jiffes based one and this new one:

1. jiffies-based:

unsigned long long __attribute__((weak)) sched_clock(void) {
return (unsigned long long)(jiffies - INITIAL_JIFFIES)
* (NSEC_PER_SEC / HZ);
}

2. cnt32_to_63() and read_c0_count() based one:

unsigned long long notrace sched_clock(void)

{
	unsigned long long v = cnt32_to_63(read_c0_count());
	return (v * tclk2ns_scale) >> tclk2ns_scale_factor;
}

#define cnt32_to_63(cnt_lo) \

({ \
	static u32 __m_cnt_hi; \
	union cnt32_to_63 __x; \
	__x.hi = __m_cnt_hi; \
 	smp_rmb(); \
	__x.lo = (cnt_lo); \
	if (unlikely((s32)(__x.hi ^ __x.lo) < 0)) \
		__m_cnt_hi = __x.hi = (__x.hi ^ 0x80000000) + (__x.hi >> 31); \
	__x.val; \
})

#define read_c0_count() __read_32bit_c0_register($9, 0)
#define __read_32bit_c0_register(source, sel) \

({ int __res;								\
	if (sel == 0)							\
		__asm__ __volatile__(					\
			"mfc0\t%0, " #source "\n\t"			\
			: "=r" (__res));				\
	else								\
		__asm__ __volatile__(					\
			".set\tmips32\n\t"				\
			"mfc0\t%0, " #source ", " #sel "\n\t"		\
			".set\tmips0\n\t"				\
			: "=r" (__res));				\
	__res;								\
})

NOTE: An exisiting problem is with this new sched_clock(), we can not always get tracing result(no result of "cat /debug/tracing/trace") of function graph tracer. Not sure whether it is relative to this sched_clock()!

(I will split this patch out of the patchset "ftrace for MIPS" and
resend the patchset as v9 later for this one is really different from the other patches)

---
 arch/mips/kernel/csrc-r4k.c |   37 +++++++++++++++++++++++++++++++++++++
 1 files changed, 37 insertions(+), 0 deletions(-)
arch/mips/kernel/csrc-r4k.c +37 -0
index e95a3cd..865035d 100644
@@ -6,10 +6,45 @@
  * Copyright (C) 2007 by Ralf Baechle
  */
 #include <linux/clocksource.h>
+#include <linux/cnt32_to_63.h>
+#include <linux/timer.h>
 #include <linux/init.h>
 
 #include <asm/time.h>
 
+/*
+ * MIPS' sched_clock implementation.
+ *
+ * NOTE: because cnt32_to_63() needs to be called at least once per half period
+ * to work properly, and some of the MIPS' frequency is very low, perhaps a
+ * kernel timer is needed to be set up to ensure this requirement is always
+ * met. please refer to  arch/arm/plat-orion/time.c and
+ * include/linux/cnt32_to_63.h
+ */
+static unsigned long tclk2ns_scale, tclk2ns_scale_factor;
+
+unsigned long long notrace sched_clock(void)
+{
+	unsigned long long v = cnt32_to_63(read_c0_count());
+	return (v * tclk2ns_scale) >> tclk2ns_scale_factor;
+}
+
+static void __init setup_sched_clock(struct clocksource *cs, unsigned long tclk)
+{
+	unsigned long long v;
+
+	v = cs->mult;
+	/*
+	 * We want an even value to automatically clear the top bit
+	 * returned by cnt32_to_63() without an additional run time
+	 * instruction. So if the LSB is 1 then round it up.
+	 */
+	if (v & 1)
+		v++;
+	tclk2ns_scale = v;
+	tclk2ns_scale_factor = cs->shift;
+}
+
 static cycle_t c0_hpt_read(struct clocksource *cs)
 {
 	return read_c0_count();
@@ -32,6 +67,8 @@ int __init init_r4k_clocksource(void)
 
 	clocksource_set_clock(&clocksource_mips, mips_hpt_frequency);
 
+	setup_sched_clock(&clocksource_mips, mips_hpt_frequency);
+
 	clocksource_register(&clocksource_mips);
 
 	return 0;
Signature · 1 line
1.6.2.1
#1 lore raw

[...]

Quoted 9 lines
---
 arch/mips/kernel/csrc-r4k.c |   37 +++++++++++++++++++++++++++++++++++++
 1 files changed, 37 insertions(+), 0 deletions(-)
arch/mips/kernel/csrc-r4k.c +0 -0
index e95a3cd..865035d 100644

arch/mips/kernel/csrc-r4k.c line 10

Quoted 5 lines
arch/mips/kernel/csrc-r4k.c +2 -0
@@ -6,10 +6,45 @@
  * Copyright (C) 2007 by Ralf Baechle
  */
 #include <linux/clocksource.h>
+#include <linux/cnt32_to_63.h>
+#include <linux/timer.h>

Sorry, <linux/timer.h> is not needed here, I have used it in the old version with setup_timer()/mod_timer().

Quoted 12 lines
arch/mips/kernel/csrc-r4k.c +8 -0
 #include <linux/init.h>
 
 #include <asm/time.h>
 
+/*
+ * MIPS' sched_clock implementation.
+ *
+ * NOTE: because cnt32_to_63() needs to be called at least once per half period
+ * to work properly, and some of the MIPS' frequency is very low, perhaps a
+ * kernel timer is needed to be set up to ensure this requirement is always
+ * met. please refer to  arch/arm/plat-orion/time.c and
+ * include/linux/cnt32_to_63.h

arch/mips/kernel/csrc-r4k.c line 32

Quoted 10 lines
arch/mips/kernel/csrc-r4k.c +10 -0
+ */
+static unsigned long tclk2ns_scale, tclk2ns_scale_factor;
+
+unsigned long long notrace sched_clock(void)
+{
+	unsigned long long v = cnt32_to_63(read_c0_count());
+	return (v * tclk2ns_scale) >> tclk2ns_scale_factor;
+}
+
+static void __init setup_sched_clock(struct clocksource *cs, unsigned long tclk)

the tclk is not used, I have also used it in the old version with setup_timer()/mod_timer(). so, we can remove it for this version.

Quoted 19 lines
arch/mips/kernel/csrc-r4k.c +15 -0
+{
+	unsigned long long v;
+
+	v = cs->mult;
+	/*
+	 * We want an even value to automatically clear the top bit
+	 * returned by cnt32_to_63() without an additional run time
+	 * instruction. So if the LSB is 1 then round it up.
+	 */
+	if (v & 1)
+		v++;
+	tclk2ns_scale = v;
+	tclk2ns_scale_factor = cs->shift;
+}
+
 static cycle_t c0_hpt_read(struct clocksource *cs)
 {
 	return read_c0_count();

arch/mips/kernel/csrc-r4k.c int __init init_r4k_clocksource(void) · line 71

Quoted 5 lines
arch/mips/kernel/csrc-r4k.c +2 -0
@@ -32,6 +67,8 @@ int __init init_r4k_clocksource(void)
 
 	clocksource_set_clock(&clocksource_mips, mips_hpt_frequency);
 
+	setup_sched_clock(&clocksource_mips, mips_hpt_frequency);
+

And here should be setup_sched_clock(&clocksource_mips);

Regards,
Wu Zhangjin