Skip to contentSkip to conversation

USB: ftdi_sio: fix initialisation of latency timeout

PATCH New Johan Hovold 1 participant 1 message Nov 22, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: ftdi_sio: fix initialisation of latency timeout

Latency timeout was read but never stored on port probe. When ASYNC_LOW_LATENCY was cleared the device timeout would get set to 0 rather than the default 16ms.

---
 drivers/usb/serial/ftdi_sio.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
drivers/usb/serial/ftdi_sio.c +5 -4
index 9c60d6d..dd130f7 100644
@@ -1150,7 +1150,6 @@ static int read_latency_timer(struct usb_serial_port *port)
 	unsigned short latency = 0;
 	int rv = 0;
 
-
 	dbg("%s", __func__);
 
 	rv = usb_control_msg(udev,
@@ -1163,8 +1162,9 @@ static int read_latency_timer(struct usb_serial_port *port)
 	if (rv < 0) {
 		dev_err(&port->dev, "Unable to read latency timer: %i\n", rv);
 		return -EIO;
-	}
-	return latency;
+	} else
+		priv->latency = latency;
+	return rv;
 }
 
 static int get_serial_info(struct usb_serial_port *port,
@@ -1551,7 +1551,8 @@ static int ftdi_sio_port_probe(struct usb_serial_port *port)
 
 	ftdi_determine_type(port);
 	ftdi_set_max_packet_size(port);
-	read_latency_timer(port);
+	if (read_latency_timer(port) < 0)
+		priv->latency = 16;
 	create_sysfs_attrs(port);
 	return 0;
 }
Signature · 1 line
1.6.5.3