Skip to contentSkip to conversation

can: Free I/O region when unloading the xeno_can_isa.ko driver

PATCH In review Sebastian Smolorz 4 participants 5 messages Nov 23, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 can: Free I/O region when unloading the xeno_can_isa.ko driver

can: Free I/O region when unloading the xeno_can_isa.ko driver

ksrc/drivers/can/sja1000/rtcan_isa.c +3 -2
index 6debb16..ec32393 100644
@@ -1,8 +1,8 @@
 /*
  * Copyright (C) 2006 Wolfgang Grandegger <[email protected]>
  *
- * Copyright (C) 2005, 2006 Sebastian Smolorz
- *                          <[email protected]>
+ * Copyright (C) 2005, 2006, 2009 Sebastian Smolorz
+ *                               <[email protected]>
  *
  *
  * This program is free software; you can redistribute it and/or modify it
@@ -189,6 +189,7 @@ static void rtcan_isa_exit(void)
 		if (!dev)
 			continue;
 		rtcan_sja1000_unregister(dev);
+		release_region(io[i], RTCAN_ISA_PORT_SIZE);
 		rtcan_dev_free(dev);
 	}
 }
#2 lore raw
Quoted 7 lines · Wolfgang Grandegger
Quoted 3 lines · Sebastian Smolorz

can: Free I/O region when unloading the xeno_can_isa.ko driver

Philippe, should I apply the patch?

Do you have write access to the head git? Even if, this is not how that tree is operated today. Either send pull request from a personal tree or wait for Philippe to pick it up directly.

But I can also pick up Sebastian's patch and push it through my tree (along with the other RTDM-related commit I've queued).

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
#3 lore raw
Quoted 4 lines · Jan Kiszka
Quoted 3 lines · Wolfgang Grandegger
Quoted 2 lines · Sebastian Smolorz

can: Free I/O region when unloading the xeno_can_isa.ko driver

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Philippe, should I apply the patch?

Do you have write access to the head git? Even if, this is not how that tree is operated today. Either send pull request from a personal tree or wait for Philippe to pick it up directly.

Well, you are right. I actually never tried.

Quoted 2 lines

But I can also pick up Sebastian's patch and push it through my tree (along with the other RTDM-related commit I've queued).

You are welcome.

Thanks,

Wolfgang.