Skip to contentSkip to conversation

sfc: Remove redundant gotos from __efx_rx_packet()

PATCH In review Ben Hutchings 1 participant 1 message Nov 24, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/17 sfc: Remove redundant gotos from __efx_rx_packet()

This function no longer has any common cleanup code.

---
 drivers/net/sfc/rx.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
drivers/net/sfc/rx.c +2 -5
index a60c718..32cfe40 100644
@@ -564,7 +564,7 @@ void __efx_rx_packet(struct efx_channel *channel,
 	if (unlikely(efx->loopback_selftest)) {
 		efx_loopback_rx_packet(efx, rx_buf->data, rx_buf->len);
 		efx_free_rx_buffer(efx, rx_buf);
-		goto done;
+		return;
 	}
 
 	if (rx_buf->skb) {
@@ -580,7 +580,7 @@ void __efx_rx_packet(struct efx_channel *channel,
 
 	if (likely(checksummed || rx_buf->page)) {
 		efx_rx_packet_lro(channel, rx_buf, checksummed);
-		goto done;
+		return;
 	}
 
 	/* We now own the SKB */
@@ -601,9 +601,6 @@ void __efx_rx_packet(struct efx_channel *channel,
 
 	/* Update allocation strategy method */
 	channel->rx_alloc_level += RX_ALLOC_FACTOR_SKB;
-
-done:
-	;
 }
 
 void efx_rx_strategy(struct efx_channel *channel)
Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.