Skip to contentSkip to conversation

8250 extend OF compatible list ns16550a

PATCH In review [email protected] 3 participants 7 messages Nov 24, 2009 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

Hi,

I need to extend OF compatible list for ns16550a. I added this patch to microblaze next branch that's why you can find it in next tree tomorrow.

Please add it to serial tree.

Could you please add this patch to stable tree too? We would like to start to use stable tree.

Thanks,
Michal

#1 lore raw

PATCH 1/1 serial: 8250: Add ns16550a to OF compatible list

From: Michal Simek <[email protected]>

---
 drivers/serial/of_serial.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/serial/of_serial.c +1 -0
index 02406ba..b047c38 100644
@@ -161,6 +161,7 @@ static int of_platform_serial_remove(struct of_device *ofdev)
 static struct of_device_id __devinitdata of_platform_serial_table[] = {
 	{ .type = "serial", .compatible = "ns8250",   .data = (void *)PORT_8250, },
 	{ .type = "serial", .compatible = "ns16450",  .data = (void *)PORT_16450, },
+	{ .type = "serial", .compatible = "ns16550a",  .data = (void *)PORT_16550A, },
 	{ .type = "serial", .compatible = "ns16550",  .data = (void *)PORT_16550, },
 	{ .type = "serial", .compatible = "ns16750",  .data = (void *)PORT_16750, },
 	{ .type = "serial", .compatible = "ns16850",  .data = (void *)PORT_16850, },
Signature · 1 line
1.5.5.1
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH] serial: 8250: Add ns16550a to OF compatible list

Quoted 3 lines · On Tuesday 24 November 2009 09:21:42 [email protected] wrote:

From: Michal Simek <[email protected]>

I was holding off on that patch to make sure the discussion had ended, but this part certainly looks good.

Some points on form though:

* The patch is missing a changelog, which is always required, but especially important if you're changing code that you want in -stable!

* You did not cc me. Ok, I just noticed I'm missing an entry in the MAINTAINERS file, but scripts/get_maintainer.pl would have given you a good indication of who feels responsible. You also didn't cc Alon, who submitted a similar patch
[1] just days ago, which I assume prompted you to send this. If you didn't see his patch, nevermind.

* Patches go into mainline first, then into stable [2]. Asking for inclusion into -stable for a patch that is still being discussed for inclusion in -next is the wrong order, no matter how obvious and trivial the patch is.

Anyway, thanks for the patch. I'll follow up with a new version with a better changelog for the tty tree. Any suggestions about what to do on 2.6.32? Should it go in there now, or would this go into a -stable release since it's not a regression?

[1] http://www.mail-archive.com/[email protected]/msg39015.html
[2] http://lkml.indiana.edu/hypermail/linux/kernel/0504.3/1369.html

Quoted 17 lines
---
 drivers/serial/of_serial.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/serial/of_serial.c +1 -0
index 02406ba..b047c38 100644
@@ -161,6 +161,7 @@ static int of_platform_serial_remove(struct of_device *ofdev)
 static struct of_device_id __devinitdata of_platform_serial_table[] = {
 	{ .type = "serial", .compatible = "ns8250",   .data = (void *)PORT_8250, },
 	{ .type = "serial", .compatible = "ns16450",  .data = (void *)PORT_16450, },
+	{ .type = "serial", .compatible = "ns16550a",  .data = (void *)PORT_16550A, },
 	{ .type = "serial", .compatible = "ns16550",  .data = (void *)PORT_16550, },
 	{ .type = "serial", .compatible = "ns16750",  .data = (void *)PORT_16750, },
 	{ .type = "serial", .compatible = "ns16850",  .data = (void *)PORT_16850, },
#3 lore raw

Re: [PATCH] serial: 8250: Add ns16550a to OF compatible list

Quoted 7 lines · Arnd Bergmann
Quoted 3 lines · On Tuesday 24 November 2009 09:21:42 [email protected] wrote:

From: Michal Simek <[email protected]>

I was holding off on that patch to make sure the discussion had ended, but this part certainly looks good.

:-) it is my next branch - I don't want to propose this patch through my tree.

Quoted 5 lines

Some points on form though:

* The patch is missing a changelog, which is always required, but especially important if you're changing code that you want in -stable!

it is simple almost trivial patch but if you like I can write there some background.

Quoted 6 lines

* You did not cc me. Ok, I just noticed I'm missing an entry in the MAINTAINERS file, but scripts/get_maintainer.pl would have given you a good indication of who feels responsible. You also didn't cc Alon, who submitted a similar patch
[1] just days ago, which I assume prompted you to send this. If you didn't see his patch, nevermind.

you are not there. I have never used get_maintainer.pl script - will do.

I haven't seen his patch in LKML. Which subject?

$ ./scripts/get_maintainer.pl -f drivers/serial/8250.c
Alan Cox <[email protected]>
Andrew Morton <[email protected]>
David Daney <[email protected]>
Tomaso Paoletti <[email protected]>
Greg Kroah-Hartman <[email protected]>
[email protected]
[email protected]
Quoted 4 lines

* Patches go into mainline first, then into stable [2]. Asking for inclusion into -stable for a patch that is still being discussed for inclusion in -next is the wrong order, no matter how obvious and trivial the patch is.

ok - sorry.

Quoted 5 lines

Anyway, thanks for the patch. I'll follow up with a new version with a better changelog for the tty tree. Any suggestions about what to do on 2.6.32? Should it go in there now, or would this go into a -stable release since it's not a regression?

cool thanks.

Michal

Quoted 23 lines

[1] http://www.mail-archive.com/[email protected]/msg39015.html
[2] http://lkml.indiana.edu/hypermail/linux/kernel/0504.3/1369.html

Quoted 17 lines
---
 drivers/serial/of_serial.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/serial/of_serial.c +1 -0
index 02406ba..b047c38 100644
@@ -161,6 +161,7 @@ static int of_platform_serial_remove(struct of_device *ofdev)
 static struct of_device_id __devinitdata of_platform_serial_table[] = {
 	{ .type = "serial", .compatible = "ns8250",   .data = (void *)PORT_8250, },
 	{ .type = "serial", .compatible = "ns16450",  .data = (void *)PORT_16450, },
+	{ .type = "serial", .compatible = "ns16550a",  .data = (void *)PORT_16550A, },
 	{ .type = "serial", .compatible = "ns16550",  .data = (void *)PORT_16550, },
 	{ .type = "serial", .compatible = "ns16750",  .data = (void *)PORT_16750, },
 	{ .type = "serial", .compatible = "ns16850",  .data = (void *)PORT_16850, },
Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#4 lore raw

Re: [PATCH] serial: 8250: Add ns16550a to OF compatible list

Quoted 4 lines · On Tuesday 24 November 2009 10:21:07 Michal Simek wrote:

Arnd Bergmann wrote:

it is simple almost trivial patch but if you like I can write there some background.

Already submitted again with some text

Quoted 10 lines
Quoted 6 lines

* You did not cc me. Ok, I just noticed I'm missing an entry in the MAINTAINERS file, but scripts/get_maintainer.pl would have given you a good indication of who feels responsible. You also didn't cc Alon, who submitted a similar patch
[1] just days ago, which I assume prompted you to send this. If you didn't see his patch, nevermind.

you are not there. I have never used get_maintainer.pl script - will do.

I haven't seen his patch in LKML. Which subject?

see the link at the bottom of my mail, referenced through "[1]" above. It was cross-posted on some mailing lists, but unfortunately not on lkml.

Quoted 8 lines
$ ./scripts/get_maintainer.pl -f drivers/serial/8250.c
Alan Cox <[email protected]>
Andrew Morton <[email protected]>
David Daney <[email protected]>
Tomaso Paoletti <[email protected]>
Greg Kroah-Hartman <[email protected]>
[email protected]
[email protected]

wrong file:
./scripts/get_maintainer.pl -f drivers/serial/of_serial.c Benjamin Herrenschmidt <[email protected]> Arnd Bergmann <[email protected]>
Matthias Fuchs <[email protected]>
Dave Mitchell <[email protected]>
Andrew Morton <[email protected]>
Grant Likely <[email protected]> [email protected] [email protected]

Quoted 2 lines
Quoted 2 lines

[1] http://www.mail-archive.com/[email protected]/msg39015.html
[2] http://lkml.indiana.edu/hypermail/linux/kernel/0504.3/1369.html

	Arnd <>< 
#5 lore raw

Re: [PATCH] serial: 8250: Add ns16550a to OF compatible list

Quoted 12 lines · Arnd Bergmann
Quoted 3 lines · On Tuesday 24 November 2009 10:21:07 Michal Simek wrote:

Arnd Bergmann wrote:

it is simple almost trivial patch but if you like I can write there some background.

Already submitted again with some text

Quoted 5 lines
Quoted 5 lines

* You did not cc me. Ok, I just noticed I'm missing an entry in the MAINTAINERS file, but scripts/get_maintainer.pl would have given you a good indication of who feels responsible. You also didn't cc Alon, who submitted a similar patch
[1] just days ago, which I assume prompted you to send this. If you didn't see his patch, nevermind.

Quoted 6 lines
Quoted 3 lines

you are not there. I have never used get_maintainer.pl script - will do.

I haven't seen his patch in LKML. Which subject?

see the link at the bottom of my mail, referenced through "[1]" above. It was cross-posted on some mailing lists, but unfortunately not on lkml.

:-)

Quoted 10 lines
Quoted 9 lines
$ ./scripts/get_maintainer.pl -f drivers/serial/8250.c
Alan Cox <[email protected]>
Andrew Morton <[email protected]>
David Daney <[email protected]>
Tomaso Paoletti <[email protected]>
Greg Kroah-Hartman <[email protected]>
[email protected]
[email protected]
Quoted 9 lines

wrong file: ./scripts/get_maintainer.pl -f drivers/serial/of_serial.c Benjamin Herrenschmidt <[email protected]>
Arnd Bergmann <[email protected]>
Matthias Fuchs <[email protected]>
Dave Mitchell <[email protected]>
Andrew Morton <[email protected]>
Grant Likely <[email protected]> [email protected] [email protected]

aaa. Anyway - you forget cc me. :-)

Michal

Quoted 5 lines
Quoted 3 lines
Quoted 3 lines

[1] http://www.mail-archive.com/[email protected]/msg39015.html
[2] http://lkml.indiana.edu/hypermail/linux/kernel/0504.3/1369.html

	Arnd <>< 
Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#6 lore raw

Re: [stable] [PATCH] serial: 8250: Add ns16550a to OF compatible list

In reply to Arnd Bergmann
Quoted 19 lines · Arnd Bergmann
Quoted 3 lines · On Tuesday 24 November 2009 09:21:42 [email protected] wrote:

From: Michal Simek <[email protected]>

I was holding off on that patch to make sure the discussion had ended, but this part certainly looks good.

Some points on form though:

* The patch is missing a changelog, which is always required, but especially important if you're changing code that you want in -stable!

* You did not cc me. Ok, I just noticed I'm missing an entry in the MAINTAINERS file, but scripts/get_maintainer.pl would have given you a good indication of who feels responsible. You also didn't cc Alon, who submitted a similar patch
[1] just days ago, which I assume prompted you to send this. If you didn't see his patch, nevermind.

Quoted 3 lines

* Patches go into mainline first, then into stable [2]. Asking for inclusion into -stable for a patch that is still being discussed for inclusion in -next is the wrong order, no matter how obvious and trivial the patch is.

The easiest way to do this is to add:
cc: stable <[email protected]>
to the signed-off-by area of the patch. Then, when it goes into Linus's tree the stable developers will be automatically notified of it and suck it into their tree as well, no additional work needs to be done by you at all.

thanks,

greg k-h