Skip to contentSkip to conversation

qemu-kvm: Fix INTx assigned device can't work bug

PATCH Applied Sheng Yang 2 participants 2 messages Nov 24, 2009 – Nov 25, 2009 KVM

lore
Share & tools
lore

Sheng Yang

author
#0 lore raw

PATCH 1/1 qemu-kvm: Fix INTx assigned device can't work bug

Commit 6b5bbd04 "qdev-ify device assignment" forgot to put assigned devices to "devs" list. So when IRQ routing changed in pci configure space, calling to assigned_dev_update_irqs() won't update device guest IRQ, then assigned INTx devices fail to work.

(OK, I am now aware of the fact that people don't use INTx these days...)

CC Gerd Hoffmann <[email protected]>
---
 hw/device-assignment.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
hw/device-assignment.c +1 -0
index 516cf14..64f3dc2 100644
@@ -1180,6 +1180,7 @@ static int assigned_initfn(struct PCIDevice *pci_dev)
             goto assigned_out;
 
     assigned_dev_load_option_rom(dev);
+    QLIST_INSERT_HEAD(&devs, dev, next);
     return 0;
 
 assigned_out:
Signature · 1 line
1.5.4.5
#1 lore raw
Quoted 6 lines · Sheng Yang

Commit 6b5bbd04 "qdev-ify device assignment" forgot to put assigned devices to "devs" list. So when IRQ routing changed in pci configure space, calling to assigned_dev_update_irqs() won't update device guest IRQ, then assigned INTx devices fail to work.

(OK, I am now aware of the fact that people don't use INTx these days...)

Applied, thanks.