Make OLPC camera driver depend on x86.
drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +1 -1
@@ -668,7 +668,7 @@ config VIDEO_M32R_AR_M64278 config VIDEO_CAFE_CCIC tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support" - depends on I2C && VIDEO_V4L2 + depends on I2C && VIDEO_V4L2 && X86_32 select VIDEO_OV7670 ---help--- This is a video4linux2 driver for the Marvell 88ALP01 integrated
Signature · 1 line
http://www.codemonkey.org.uk
drivers/media/video/Kconfig config VIDEO_M32R_AR_M64278 · line 671
Quoted 2 lines · Dave Jones
drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +1
-1- depends on I2C && VIDEO_V4L2 + depends on I2C && VIDEO_V4L2 && X86_32
Any particular reason why? I wouldn't be surprised to see Cafe used with other processors in the future. And I happen to know the driver works on x86-64 systems...or at least it did a few iterations back.
In any case, x86 for now is fine, I guess; we can always change it later if need be.
jon
Quoted 6 lines · Jonathan Corbet
drivers/media/video/Kconfig config VIDEO_M32R_AR_M64278 · line 671
Quoted 2 lines · Dave Jones
drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +1
-1- depends on I2C && VIDEO_V4L2 + depends on I2C && VIDEO_V4L2 && X86_32Any particular reason why?
Just seemed odd to be offered the option when I was building an ia64 kernel given its extremely unlikely to ever appear there.
[gads, an ia64 olpc, what a thought...]
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Alan
NAKQuoted 10 lines · On Tue, 12 Dec 2006 10:39:56 -0500 Dave Jones <[email protected]> wrote:
Quoted 6 lines · Jonathan Corbet
drivers/media/video/Kconfig config VIDEO_M32R_AR_M64278 · line 671
Quoted 2 lines · Dave Jones
drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +1
-1- depends on I2C && VIDEO_V4L2 + depends on I2C && VIDEO_V4L2 && X86_32Any particular reason why?
Just seemed odd to be offered the option when I was building an ia64 kernel given its extremely unlikely to ever appear there.
It means we catch portability bugs early and people changing core code catch problems even if their platform is not X86_32. The practice for almost all out drivers is thus not to put in arch dependancies unless they genuinely do not build on arbitary platforms.
NAK
Quoted 8 lines · Alan Cox
Quoted 7 lines
Quoted 4 lines
drivers/media/video/Kconfig config VIDEO_M32R_AR_M64278 · line 671
Quoted 2 lines
drivers/media/video/Kconfig renamed from drivers/media/video/Kconfig~ +1
-1- depends on I2C && VIDEO_V4L2 + depends on I2C && VIDEO_V4L2 && X86_32Any particular reason why?
Just seemed odd to be offered the option when I was building an ia64 kernel given its extremely unlikely to ever appear there.
Quoted 6 lines
It means we catch portability bugs early and people changing core code catch problems even if their platform is not
X86_32. The practice for almost all out drivers is thus not to put in arch dependancies unless they genuinely do not build on arbitary platforms.NAK
Given this could in theory turn up in USB form one day, and some lunatic may actually plug one into an ia64, I see your point. Unlikely, but feasible.
Dave
Signature · 1 line
http://www.codemonkey.org.uk