Skip to contentSkip to conversation

TSOv6 broken in atl1e

PATCH Ben Hutchings 2 participants 3 messages Dec 1, 2009 – Dec 2, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

I received a bug report <http://bugs.debian.org/558426> that shows atl1e corrupting IPv6 packets. I have reproduced this on an Eee PC 901 and found that it is linked to TSO. The most obvious thing wrong with the driver code is that it calculates the super-packet length incorrectly. However, fixing that:

drivers/net/atl1e/atl1e_main.c +1 -0
@@ -1667,6 +1667,7 @@ static int atl1e_tso_csum(struct atl1e_adapter *adapter,
 
 		if (offload_type & SKB_GSO_TCPV6) {
 			real_len = (((unsigned char *)ipv6_hdr(skb) - skb->data)
+					+ sizeof(struct ipv6hdr)
 					+ ntohs(ipv6_hdr(skb)->payload_len));
 			if (real_len < skb->len)
 				pskb_trim(skb, real_len);

--- END ---

does not solve the problem. Presumably this function is not constructing correct DMA descriptors for TSOv6.

Please fix this, or I will submit a patch to remove this feature from the driver.

Ben.

Signature · 2 lines
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.
#1 lore raw

On Tuesday, December 01, 2009 11:20 AM
Ben Hutchings <[email protected]>

Quoted 23 lines

I received a bug report <http://bugs.debian.org/558426> that shows atl1e corrupting IPv6 packets. I have reproduced this on an Eee PC 901 and found that it is linked to TSO. The most obvious thing wrong with the driver code is that it calculates the super-packet length incorrectly. However, fixing that:

drivers/net/atl1e/atl1e_main.c +1 -0
@@ -1667,6 +1667,7 @@ static int atl1e_tso_csum(struct
 atl1e_adapter *adapter,
 
              if (offload_type & SKB_GSO_TCPV6) {
                      real_len = (((unsigned char
 *)ipv6_hdr(skb) - skb->data)
+                                     + sizeof(struct ipv6hdr)
                                      +

ntohs(ipv6_hdr(skb)->payload_len));
                      if (real_len < skb->len)
                              pskb_trim(skb, real_len);

--- END ---

Quoted 8 lines

does not solve the problem. Presumably this function is not constructing correct DMA descriptors for TSOv6.

Please fix this, or I will submit a patch to remove this feature from the driver.

Ben.

ok, I will try to reproduce it.

Best wishes
jie

#2 lore raw
In reply to Ben Hutchings
Quoted 21 lines · Ben Hutchings

I received a bug report <http://bugs.debian.org/558426> that shows atl1e corrupting IPv6 packets. I have reproduced this on an Eee PC 901 and found that it is linked to TSO. The most obvious thing wrong with the driver code is that it calculates the super-packet length incorrectly. However, fixing that:

drivers/net/atl1e/atl1e_main.c +1 -0
@@ -1667,6 +1667,7 @@ static int atl1e_tso_csum(struct
 atl1e_adapter *adapter,
 
              if (offload_type & SKB_GSO_TCPV6) {
                      real_len = (((unsigned char
 *)ipv6_hdr(skb) - skb->data)
+                                     + sizeof(struct ipv6hdr)
                                      +

ntohs(ipv6_hdr(skb)->payload_len));
                      if (real_len < skb->len)
                              pskb_trim(skb, real_len);
Quoted 8 lines

--- END ---

does not solve the problem. Presumably this function is not constructing correct DMA descriptors for TSOv6.

Please fix this, or I will submit a patch to remove this feature from the driver.

ou, there is hareware limit to support TSOv6, just disable it.

Best wishes
jie