param: don't complain about unused module parameters.
PATCH 1/1 param: don't complain about unused module parameters.
Jon confirms that recent modprobe will look in /proc/cmdline, so these cmdline options can still be used.
See http://bugzilla.kernel.org/show_bug.cgi?id=14164
Reported-by Adam Williamson <[email protected]>
Signed-off-by Rusty Russell <[email protected]>
--- init/main.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
init/main.c +3 -8
@@ -251,7 +251,7 @@ early_param("loglevel", loglevel);/* * Unknown boot options get handed to init, unless they look like -* failed parameters +* unused parameters (modprobe will find them in /proc/cmdline). */ static int __init unknown_bootoption (char *param,char *val) {
@@ -272,14 +272,9 @@ static int __init unknown_bootoption(chaif (obsolete_checksetup (param))return 0 ; -/* -* Preemptive maintenance for "why didn't my misspelled command -* line work?" -*/ -if (strchr (param,'.' ) && (!val ||strchr (param,'.' ) < val)) { -printk (KERN_ERR "Unknown boot option `%s': ignoring\n" , param); +/* Unused module parameter. */ +if (strchr (param,'.' ) && (!val ||strchr (param,'.' ) < val))return 0 ; - }if (panic_later)return 0 ;
Quoted 2 lines · Rusty Russell
Jon confirms that recent modprobe will look in
/proc/cmdline, so these cmdline options can still be used.
Yup. Thanks for that.
Jon.
Quoted 4 lines · Rusty Russell
Jon confirms that recent modprobe will look in
/proc/cmdline, so these cmdline options can still be used.
Thanks for the fix, Rusty. This'll save a lot of confusion :)
Signature · 4 lines
Adam Williamson Fedora QA Community Monkey IRC: adamw | Fedora Talk: adamwill AT fedoraproject DOT org http://www.happyassassin.net