Skip to contentSkip to conversation

some recent scheduler patches

DISCUSSION Nick Piggin 2 participants 2 messages Dec 2, 2009

lore
Share & tools
lore
#0 lore raw

Hi,

I'm just been looking through some of the recent scheduler patches while bisecting something...

83f54960c11a14942ab00b54c51e91906b9d8235: sched: for_each_domain() vs RCU I don't see what is the step that causes FAIL? sched-domains code is using synchronize_sched(), so that part should be safe.

And b8a543ea5a5896830a9969bacfd047f9d15940b2... This changelog is not correct to start with. The _idx stuff does not just shift the time that balancing decisions are made, it damps balancing choices to be more conservative if they might have been wrong over more than a single instant sample.

And secondly there is no reason give for the change. Ditto for a lot of other tuning changes really. Not that there was always exact reasons for every single one of the defaults I found, but they a) always tried to get reasonable performance with as conservative balancing as possible (ie. so 2 different tunings with no distinguishable difference then tuning that result in fewer task movements would be preferred). And b) they were relatively well tested.

Are people really not reporting enough regressions against CFS that it is time to just tweak things?

#1 lore raw
Quoted 5 lines · Nick Piggin

83f54960c11a14942ab00b54c51e91906b9d8235: sched: for_each_domain() vs RCU I don't see what is the step that causes FAIL? sched-domains code is using synchronize_sched(), so that part should be safe.

Yeah, I got myself properly confused there. I was meaning to remove that rcu_read_lock() there again.