Skip to contentSkip to conversation

Fix setting of readahead in lvcreate, add tests.

PATCH New Dave Wysochanski 2 participants 4 messages Dec 2, 2009 – Dec 3, 2009

lore
Share & tools
lore
#0 lore raw

cover Fix setting of readahead in lvcreate, add tests.

These two patches fix lvcreate to honor --readahead and add some tests. Not sure but somewhere along the line this got broken and default was all you ever got. Second patch adds some tests to prevent this in the future. Found this problem while reviewing replicator patches.

#1 lore raw

PATCH 1/2 Fix setting of readahead in lvcreate.

The default comes from the configuration settings, with possible commandline override.

---
 lib/metadata/lv_manip.c |    2 +-
 tools/lvcreate.c        |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
lib/metadata/lv_manip.c +1 -1
index 38dcbf3..c440278 100644
@@ -3019,7 +3019,7 @@ int lv_create_single(struct volume_group *vg,
 				   status, lp->alloc, vg)))
 		return_0;
 
-	if (lp->read_ahead) {
+	if (lp->read_ahead != lv->read_ahead) {
 		log_verbose("Setting read ahead sectors");
 		lv->read_ahead = lp->read_ahead;
 	}
tools/lvcreate.c +2 -1
index 2b2d135..06f3478 100644
@@ -509,7 +509,8 @@ static int _lvcreate_params(struct lvcreate_params *lp,
 	/*
 	 * Read ahead.
 	 */
-	lp->read_ahead = arg_uint_value(cmd, readahead_ARG, DM_READ_AHEAD_NONE);
+	lp->read_ahead = arg_uint_value(cmd, readahead_ARG,
+					cmd->default_settings.read_ahead);
 	pagesize = lvm_getpagesize() >> SECTOR_SHIFT;
 	if (lp->read_ahead != DM_READ_AHEAD_AUTO &&
 	    lp->read_ahead != DM_READ_AHEAD_NONE &&
Signature · 1 line
1.6.0.6
#2 lore raw

PATCH 2/2 Add tests to check for readahead value in lvcreate.

---
 test/t-lvcreate-usage.sh |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
test/t-lvcreate-usage.sh +15 -0
index 14b6ecb..62cf151 100755
@@ -125,3 +125,18 @@ lvcreate -s --virtualoriginsize 64m -L 32m -n $lv1 $vg
 lvchange -a n $vg/$lv1
 lvremove $vg/$lv1
 lvremove -ff $vg
+
+# readahead default (auto), none, #, auto
+lvcreate -L 32m -n $lv $vg
+check_lv_field_ $vg/$lv lv_read_ahead "auto"
+lvremove -ff $vg
+lvcreate -L 32m -n $lv --readahead none $vg
+check_lv_field_ $vg/$lv lv_read_ahead "0"
+lvremove -ff $vg
+lvcreate -L 32m -n $lv --readahead 8k $vg
+check_lv_field_ $vg/$lv lv_read_ahead "8.00k"
+lvremove -ff $vg
+lvcreate -L 32m -n $lv --readahead auto $vg
+check_lv_field_ $vg/$lv lv_read_ahead "auto"
+lvremove -ff $vg
+
Signature · 1 line
1.6.0.6