Skip to contentSkip to conversation

iproute2 skbedit: Fix help message

PATCH Applied jamal 2 participants 3 messages Dec 3, 2009 – Dec 26, 2009

Subsystems (2)
lore
Share & tools
lore

jamal

author
#0 lore raw

PATCH 1/2 iproute2 skbedit: Fix help message

Currently the help text for skbedit implies you can either pass queue mapping or priority. Truth is you can pass both

cheers,
jamal

commit ca50bc332fc8f2cba0468fe133d41d78a0be7b71

Author: Jamal Hadi Salim <[email protected]>
Date:   Thu Dec 3 08:14:11 2009 -0500

skbedit: Fix help message

Currently the help text implies you can either pass queue mapping or priority. Truth is you can pass both

tc/m_skbedit.c +3 -2
index 9044353..ecb1f2d 100644
@@ -31,8 +31,9 @@
 static void
 explain(void)
 {
-	fprintf(stderr, "Usage: ... skbedit "
-			"queue_mapping QUEUE_MAPPING | priority PRIORITY \n"
+	fprintf(stderr, "Usage: ... skbedit <[QM] [PM]>\n"
+			"QM = queue_mapping QUEUE_MAPPING\n"
+			"PM = priority PRIORITY \n"
 			"QUEUE_MAPPING = device transmit queue to use\n"
 			"PRIORITY = classID to assign to priority field\n");
 }
#1 lore raw
Quoted 7 lines · On Thu, 03 Dec 2009 08:27:24 -0500 jamal <[email protected]> wrote:

Currently the help text for skbedit implies you can either pass queue mapping or priority. Truth is you can pass both

cheers,
jamal

applied to 2.6.32 version

author
#2 lore raw
Quoted 11 lines · Stephen Hemminger
Quoted 7 lines · On Thu, 03 Dec 2009 08:27:24 -0500 jamal <[email protected]> wrote:

Currently the help text for skbedit implies you can either pass queue mapping or priority. Truth is you can pass both

cheers,
jamal

applied to 2.6.32 version

It is not in the 2.6.32 release - but seems harmless enough it can stay in later versions.

cheers,
jamal