Skip to contentSkip to conversation

perf events: Remove unused struct perf_event::event_callback

PATCH In review Frederic Weisbecker 2 participants 3 messages Dec 3, 2009 – Dec 4, 2009 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf events: Remove unused struct perf_event::event_callback

This field might result from an older manual rebasing mistake. We don't use it.

Cc Peter Zijlstra <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Paul Mackerras <[email protected]>
---
 include/linux/perf_event.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
include/linux/perf_event.h +0 -2
index d045e6e..c7f6502 100644
@@ -671,8 +671,6 @@ struct perf_event {
 
 	perf_callback_t			callback;
 
-	perf_callback_t			event_callback;
-
 #endif /* CONFIG_PERF_EVENTS */
 };
 
Signature · 1 line
1.6.2.3
maintainer
#1 lore raw

include/linux/perf_event.h struct perf_event { · line 672

Quoted 3 lines · Frederic Weisbecker
include/linux/perf_event.h +0 -0
@@ -671,8 +671,6 @@ struct perf_event {
 
 	perf_callback_t			callback;

Any chance we can get all of that perf_callback_t ugly gone?

#2 lore raw
Quoted 7 lines · Peter Zijlstra

include/linux/perf_event.h struct perf_event { · line 672

Quoted 3 lines · Frederic Weisbecker
include/linux/perf_event.h +0 -0
@@ -671,8 +671,6 @@ struct perf_event {
 
 	perf_callback_t			callback;

Any chance we can get all of that perf_callback_t ugly gone?

Sure. We had callback and event_callback. event_callback is removed in this patch and overflow_handler will soon replace the callback field.