microblaze: nommu: Don't clobber R11 on syscalls
PATCH 1/1 microblaze: nommu: Don't clobber R11 on syscalls
The noMMU syscall trap has a bug that causes R11 to be zero on return to userland. Remove the extra "save" of R11 responsible for the bug.
Signed-off-by Steven J. Magnani <[email protected]>
---
arch/microblaze/kernel/entry-nommu.S +0 -1
@@ -208,7 +208,6 @@ ENTRY(_user_exception) lwi r1, r1, TS_THREAD_INFO /* get the thread info */ /* calculate kernel stack pointer */ addik r1, r1, THREAD_SIZE - PT_SIZE - swi r11, r0, PER_CPU(R11_SAVE) /* temporarily save r11 */ lwi r11, r0, PER_CPU(KM) /* load mode indicator */ 2: swi r11, r1, PT_MODE /* store the mode */
Michal Simek
maintainerHi Steve,
Quoted 1 line · [email protected] wrote:
The noMMU syscall trap has a bug that causes R11 to be zero on return to userland. Remove the extra "save" of R11 responsible for the bug.
Can you please look if is even possible to remove that one line below?
( I mean line 212 - lwi r11, r0, PER_CPU(KM) */
Interrupt rutine don't have it too. I am pretty sure that we can remove that line too.
Thanks for testing,
Michal
Quoted 15 lines
Signed-off-by Steven J. Magnani <[email protected]>---
diff -uprNa/arch/microblaze/kernel/entry-nommu.Sb/arch/microblaze/kernel/entry-nommu.Sarch/microblaze/kernel/entry-nommu.S +0
-1@@ -208,7 +208,6 @@ ENTRY(_user_exception) lwi r1, r1, TS_THREAD_INFO /* get the thread info */ /* calculate kernel stack pointer */ addik r1, r1, THREAD_SIZE - PT_SIZE - swi r11, r0, PER_CPU(R11_SAVE) /* temporarily save r11 */ lwi r11, r0, PER_CPU(KM) /* load mode indicator */ 2: swi r11, r1, PT_MODE /* store the mode */
Signature · 4 lines
Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian