gst-plugins-bad dependencies fix v2
cover gst-plugins-bad dependencies fix v2
The following patches fix dependencies problems I had seen when compiling the gst-plugins-bad package.
The thing is that the configure script did not raised any error on missing librairies (libcdaudio, libdvdread, libdvdnav and openssl), I just got error at compilation/link time (missing headers, missing library at link). I guess there is something wrong with the check of those packages (there are probably not using pkg-config), because they are installed on my host system and detected when cross compiling. Anyway, those patches still fix a real problem.
Here the patch list updated upon Peter's feedback :
[PATCH 1/6] package: Added libcdaudio package (dependency of gst-plugins-bad) [PATCH 2/6] gst-plugins-bad: Fix dependency on libcdaudio
[PATCH 3/6] gst-plugins-bad: Fix dependency on openssl through the apexsink element [PATCH 4/6] package: Added libdvdread package (dependency of gst-plugins-bad) [PATCH 5/6] package: Added libdvdnav package (dependency of gst-plugins-bad) [PATCH 6/6] gst-plugins-bad: Fix dependency on libdvdnav
--
Lionel Landwerlin
PATCH 1/6 package: Added libcdaudio package (dependency of gst-plugins-bad)
From: Lionel Landwerlin <[email protected]>
--- package/multimedia/Config.in | 1 + package/multimedia/libcdaudio/Config.in | 8 ++++++++ package/multimedia/libcdaudio/libcdaudio.mk | 13 +++++++++++++ 3 files changed, 22 insertions(+), 0 deletions(-) create mode 100644 package/multimedia/libcdaudio/Config.in create mode 100644 package/multimedia/libcdaudio/libcdaudio.mk
package/multimedia/Config.in +1 -0
@@ -9,6 +9,7 @@ source "package/multimedia/gst-plugins-base/Config.in" source "package/multimedia/gst-plugins-good/Config.in" source "package/multimedia/gst-plugins-bad/Config.in" source "package/multimedia/gst-plugins-ugly/Config.in" +source "package/multimedia/libcdaudio/Config.in" source "package/multimedia/libid3tag/Config.in" source "package/multimedia/libmad/Config.in" source "package/multimedia/libmms/Config.in"
package/multimedia/libcdaudio/Config.in new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_LIBCDAUDIO + bool "libcdaudio" + help + libcdaudio is a library designed to provide functions to + control operation of a CD-ROM when playing audio CDs. It + also contains functions for CDDB and CD Index lookup. + + http://libcdaudio.sourceforge.net/
package/multimedia/libcdaudio/libcdaudio.mk new file +13 -0
@@ -0,0 +1,13 @@ +############################################################# +# +# libcdaudio +# +############################################################# + +LIBCDAUDIO_VERSION = 0.99.12p2 +LIBCDAUDIO_SOURCE = libcdaudio-$(LIBCDAUDIO_VERSION).tar.gz +LIBCDAUDIO_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/libcdaudio/libcdaudio/$(LIBCDAUDIO_VERSION)/ +LIBCDAUDIO_INSTALL_STAGING = YES +LIBCDAUDIO_INSTALL_TARGET = YES + +$(eval $(call AUTOTARGETS,package/multimedia,libcdaudio))
Signature · 1 line
1.6.5.4
PATCH 2/6 gst-plugins-bad: Fix dependency on libcdaudio
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/gst-plugins-bad/Config.in | 4 ++++ .../multimedia/gst-plugins-bad/gst-plugins-bad.mk | 7 +++++++ 2 files changed, 11 insertions(+), 0 deletions(-)
package/multimedia/gst-plugins-bad/Config.in +4 -0
@@ -33,6 +33,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_LEGACYRESAMPLE config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_BAYER bool "bayer" +config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDAUDIO + bool "cdaudio" + select BR2_PACKAGE_LIBCDAUDIO + config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDXAPARSE bool "cdxaparse"
package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +7 -0
@@ -63,6 +63,13 @@ else GST_PLUGINS_BAD_CONF_OPT += --disable-cdxaparse endif +ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_CDAUDIO),y) +GST_PLUGINS_BAD_CONF_OPT += --enable-cdaudio +GST_PLUGINS_BAD_DEPENDENCIES += libcdaudio +else +GST_PLUGINS_BAD_CONF_OPT += --disable-cdaudio +endif + ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DCCP),y) GST_PLUGINS_BAD_CONF_OPT += --enable-dccp else
Signature · 1 line
1.6.5.4
PATCH 3/6 gst-plugins-bad: Fix dependency on openssl through the apexsink element
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/gst-plugins-bad/Config.in | 4 ++++ .../multimedia/gst-plugins-bad/gst-plugins-bad.mk | 7 +++++++ 2 files changed, 11 insertions(+), 0 deletions(-)
package/multimedia/gst-plugins-bad/Config.in +4 -0
@@ -21,6 +21,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AIFFPARSE config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AMRPARSE bool "amrparse" +config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK + bool "apexsink" + select BR2_PACKAGE_OPENSSL + config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AUTOCONVERT bool "autoconvert"
package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +7 -0
@@ -33,6 +33,13 @@ else GST_PLUGINS_BAD_CONF_OPT += --disable-amrparse endif +ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_APEXSINK),y) +GST_PLUGINS_BAD_CONF_OPT += --enable-apexsink +GST_PLUGINS_BAD_DEPENDENCIES += openssl +else +GST_PLUGINS_BAD_CONF_OPT += --disable-apexsink +endif + ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_AUTOCONVERT),y) GST_PLUGINS_BAD_CONF_OPT += --enable-autoconvert else
Signature · 1 line
1.6.5.4
PATCH 4/6 package: Added libdvdread package (dependency of gst-plugins-bad)
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/Config.in | 1 + package/multimedia/libdvdread/Config.in | 7 +++++++ package/multimedia/libdvdread/libdvdread.mk | 13 +++++++++++++ 3 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 package/multimedia/libdvdread/Config.in create mode 100644 package/multimedia/libdvdread/libdvdread.mk
package/multimedia/Config.in +1 -0
@@ -10,6 +10,7 @@ source "package/multimedia/gst-plugins-good/Config.in" source "package/multimedia/gst-plugins-bad/Config.in" source "package/multimedia/gst-plugins-ugly/Config.in" source "package/multimedia/libcdaudio/Config.in" +source "package/multimedia/libdvdread/Config.in" source "package/multimedia/libid3tag/Config.in" source "package/multimedia/libmad/Config.in" source "package/multimedia/libmms/Config.in"
package/multimedia/libdvdread/Config.in new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_LIBDVDREAD + bool "libdvdread" + help + libdvdread provides a simple foundation for reading + DVD-Video images. + + http://www.mplayerhq.hu
package/multimedia/libdvdread/libdvdread.mk new file +13 -0
@@ -0,0 +1,13 @@ +############################################################# +# +# libdvdread +# +############################################################# + +LIBDVDREAD_VERSION = 4.1.3 +LIBDVDREAD_SOURCE = libdvdread_$(LIBDVDREAD_VERSION).orig.tar.gz +LIBDVDREAD_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdread/ +LIBDVDREAD_INSTALL_STAGING = YES +LIBDVDREAD_INSTALL_TARGET = YES + +$(eval $(call AUTOTARGETS,package/multimedia,libdvdread))
Signature · 1 line
1.6.5.4
PATCH 4/6 package: Added libdvdread package (dependency of gst-plugins-bad)
Le vendredi 11 d?cembre 2009 ? 00:31 +0100, llandwerlin at gmail.com a ?crit :
Quoted 13 lines
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>--- package/multimedia/Config.in | 1 + package/multimedia/libdvdread/Config.in | 7 +++++++ package/multimedia/libdvdread/libdvdread.mk | 13 +++++++++++++ 3 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 package/multimedia/libdvdread/Config.in create mode 100644 package/multimedia/libdvdread/libdvdread.mkpackage/multimedia/Config.in +0
-0
package/multimedia/Config.in
Quoted 9 lines
package/multimedia/Config.in +8
-0+ +LIBDVDREAD_VERSION = 4.1.3 +LIBDVDREAD_SOURCE = libdvdread_$(LIBDVDREAD_VERSION).orig.tar.gz +LIBDVDREAD_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdread/ +LIBDVDREAD_INSTALL_STAGING = YES +LIBDVDREAD_INSTALL_TARGET = YES + +$(eval $(call AUTOTARGETS,package/multimedia,libdvdread))
This one was broken too...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-package-Added-libdvdread-package-dependency-of-gst-p.patch
Type: text/x-patch
Size: 2364 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20091212/32055ee0/attachment.bin>
PATCH 4/6 package: Added libdvdread package (dependency of gst-plugins-bad)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == Lionel Landwerlin <[email protected]> writes:
Lionel> This one was broken too...
It was? It built ok here. From what I can see, the only difference between what I committed and this (besides the upstream URL) is that you now turned off the libtool patching - Why?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 4/6 package: Added libdvdread package (dependency of gst-plugins-bad)
Le samedi 12 d?cembre 2009 ? 09:02 +0100, Peter Korsgaard a ?crit :
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == Lionel Landwerlin <[email protected]> writes:
Lionel> This one was broken too...
It was? It built ok here. From what I can see, the only difference between what I committed and this (besides the upstream URL) is that you now turned off the libtool patching - Why?
There 3 versions of the patch :
- the first one, you had committed and which works, even if the libtool patch is probably useless.
- the second, which is broken because the autoreconf & libtool was removed.
- the third, which only use autoreconf and which works.
I said the second was broken, but you probably haven't tested it, because you already committed the first.
Thx a lot for your patience.
Signature · 1 line
Lionel Landwerlin
PATCH 4/6 package: Added libdvdread package (dependency of gst-plugins-bad)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == Lionel Landwerlin <[email protected]> writes:
Hi,
Lionel> Thx a lot for your patience.
You too.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 5/6 package: Added libdvdnav package (dependency of gst-plugins-bad)
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/Config.in | 1 + package/multimedia/libdvdnav/Config.in | 9 +++++++++ package/multimedia/libdvdnav/libdvdnav.mk | 19 +++++++++++++++++++ 3 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 package/multimedia/libdvdnav/Config.in create mode 100644 package/multimedia/libdvdnav/libdvdnav.mk
package/multimedia/Config.in +1 -0
@@ -11,6 +11,7 @@ source "package/multimedia/gst-plugins-bad/Config.in" source "package/multimedia/gst-plugins-ugly/Config.in" source "package/multimedia/libcdaudio/Config.in" source "package/multimedia/libdvdread/Config.in" +source "package/multimedia/libdvdnav/Config.in" source "package/multimedia/libid3tag/Config.in" source "package/multimedia/libmad/Config.in" source "package/multimedia/libmms/Config.in"
package/multimedia/libdvdnav/Config.in new file +9 -0
@@ -0,0 +1,9 @@ +config BR2_PACKAGE_LIBDVDNAV + bool "libdvdnav" + select BR2_PACKAGE_LIBDVDREAD + help + libdvdnav is a library that allows easy use of sophisticated + DVD navigation features such as DVD menus, multiangle + playback and even interactive DVD games. + + http://www.mplayerhq.hu
package/multimedia/libdvdnav/libdvdnav.mk new file +19 -0
@@ -0,0 +1,19 @@ +############################################################# +# +# libdvdnav +# +############################################################# + +LIBDVDNAV_VERSION = 4.1.3 +LIBDVDNAV_SOURCE = libdvdnav_$(LIBDVDNAV_VERSION).orig.tar.gz +LIBDVDNAV_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdnav/ +LIBDVDNAV_INSTALL_STAGING = YES +LIBDVDNAV_INSTALL_TARGET = YES + +LIBDVDNAV_DEPENDENCIES = libdvdread + +# By default libdvdnav tries to find dvdread-config in $PATH. Because +# of cross compilation, we prefer using pkg-config. +LIBDVDNAV_CONF_OPT = --with-dvdread-config="$(PKG_CONFIG_HOST_BINARY) dvdread" + +$(eval $(call AUTOTARGETS,package/multimedia,libdvdnav))
Signature · 1 line
1.6.5.4
PATCH 5/6 package: Added libdvdnav package (dependency of gst-plugins-bad)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == llandwerlin <[email protected]> writes:
Lionel> From: Lionel Landwerlin <[email protected]> Lionel> Signed-off-by: Lionel Landwerlin <[email protected]>
Hmm, this seems pretty broken - Does it really build for you? First of all, there's no configure script in the tarball. There is a configure2 script, and adding a symlink gets us to the build step where it dies trying to find the libdvdread headers:
make[1]: Entering directory `/tmp/br/build/libdvdnav-4.1.3'
sh "/tmp/br/build/libdvdnav-4.1.3"/version.sh "/tmp/br/build/libdvdnav-4.1.3" "4.1.3"
cd obj && gcc -fPIC -DPIC -MD -O3 -g -Wall -funsigned-char -I/tmp/br/build/libdvdnav-4.1.3 -I"/tmp/br/build/libdvdnav-4.1.3"/src -I"/tmp/br/build/libdvdnav-4.1.3"/src/vm -DDVDNAV_COMPILE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DHAVE_CONFIG_H -DHAVE_DLFCN_H -c -o dvdnav.so /tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c /tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c:40:32: error: dvdread/dvd_reader.h: No such file or directory
Also notice that it uses the host compiler.
Lionel> +config BR2_PACKAGE_LIBDVDNAV
Lionel> + bool "libdvdnav"
Lionel> + select BR2_PACKAGE_LIBDVDREAD
Lionel> + help
Lionel> + libdvdnav is a library that allows easy use of sophisticated Lionel> + DVD navigation features such as DVD menus, multiangle Lionel> + playback and even interactive DVD games.
Lionel> +
Lionel> + http://www.mplayerhq.hu
Indentation is off here.
Lionel> +++ b/package/multimedia/libdvdnav/libdvdnav.mk
Lionel> @@ -0,0 +1,19 @@
Lionel> +############################################################# Lionel> +#
Lionel> +# libdvdnav
Lionel> +#
Lionel> +############################################################# Lionel> +
Lionel> +LIBDVDNAV_VERSION = 4.1.3
Lionel> +LIBDVDNAV_SOURCE = libdvdnav_$(LIBDVDNAV_VERSION).orig.tar.gz Lionel> +LIBDVDNAV_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdnav/
The official upstream location is afaik
http://www.mplayerhq.hu/MPlayer/releases/dvdnav/
Signature · 1 line
Bye, Peter Korsgaard
PATCH 5/6 package: Added libdvdnav package (dependency of gst-plugins-bad)
Le vendredi 11 d?cembre 2009 ? 23:07 +0100, Peter Korsgaard a ?crit :
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == llandwerlin <[email protected]> writes:
Lionel> From: Lionel Landwerlin <[email protected]> Lionel> Signed-off-by: Lionel Landwerlin <[email protected]>
Hmm, this seems pretty broken - Does it really build for you? First of all, there's no configure script in the tarball. There is a configure2 script, and adding a symlink gets us to the build step where it dies trying to find the libdvdread headers:
Quoted 6 lines
make[1]: Entering directory `/tmp/br/build/libdvdnav-4.1.3'
sh "/tmp/br/build/libdvdnav-4.1.3"/version.sh "/tmp/br/build/libdvdnav-4.1.3" "4.1.3"
cd obj && gcc -fPIC -DPIC -MD -O3 -g -Wall -funsigned-char -I/tmp/br/build/libdvdnav-4.1.3 -I"/tmp/br/build/libdvdnav-4.1.3"/src -I"/tmp/br/build/libdvdnav-4.1.3"/src/vm -DDVDNAV_COMPILE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DHAVE_CONFIG_H -DHAVE_DLFCN_H -c -o dvdnav.so/tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c/tmp/br/build/libdvdnav-4.1.3/src/dvdnav.c:40:32: error:dvdread/dvd_reader.h: No such file or directoryAlso notice that it uses the host compiler.
Arg...
I'm sorry, I removed the AUTORECONF option...
I used to set autoreconf & libtool patching by default on almost every package I compiled otherwise it broke compilation with my cross sh4 toolchain.
When rebasing my patchs I removed them all, forgetting this was usefull for libdvdread & libdvdnav packages...
Please find a corrected patch as attachment.
Quoted 25 lines
Lionel> +config
BR2_PACKAGE_LIBDVDNAV
Lionel> + bool "libdvdnav"
Lionel> + selectBR2_PACKAGE_LIBDVDREAD
Lionel> + helpLionel> + libdvdnav is a library that allows easy use of sophisticated Lionel> + DVD navigation features such as DVD menus, multiangle Lionel> + playback and even interactive DVD games.Lionel> +
Lionel> + http://www.mplayerhq.huIndentation is off here.
Lionel> +++
b/package/multimedia/libdvdnav/libdvdnav.mk
Lionel> @@ -0,0 +1,19 @@
Lionel> +############################################################# Lionel> +#
Lionel> +# libdvdnav
Lionel> +#
Lionel> +############################################################# Lionel> +
Lionel> +LIBDVDNAV_VERSION = 4.1.3
Lionel> +LIBDVDNAV_SOURCE = libdvdnav_$(LIBDVDNAV_VERSION).orig.tar.gz Lionel> +LIBDVDNAV_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libd/libdvdnav/
Quoted 3 lines
The official upstream location is afaik
http://www.mplayerhq.hu/MPlayer/releases/dvdnav/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-package-Added-libdvdnav-package-dependency-of-gst-pl.patch
Type: text/x-patch
Size: 2690 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20091212/498f4815/attachment.bin>
PATCH 5/6 package: Added libdvdnav package (dependency of gst-plugins-bad)
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == Lionel Landwerlin <[email protected]> writes:
Hi,
Lionel> I'm sorry, I removed the AUTORECONF option... Lionel> I used to set autoreconf & libtool patching by default on Lionel> almost every package I compiled otherwise it broke compilation Lionel> with my cross sh4 toolchain.
Lionel> When rebasing my patchs I removed them all, forgetting this was Lionel> usefull for libdvdread & libdvdnav packages...
Lionel> Please find a corrected patch as attachment.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 6/6 gst-plugins-bad: Fix dependency on libdvdnav
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/multimedia/gst-plugins-bad/Config.in | 4 ++++ .../multimedia/gst-plugins-bad/gst-plugins-bad.mk | 7 +++++++ 2 files changed, 11 insertions(+), 0 deletions(-)
package/multimedia/gst-plugins-bad/Config.in +4 -0
@@ -53,6 +53,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DEBUGUTILS config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DTMF bool "dtmf" +config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV + bool "dvdnav" + select BR2_PACKAGE_LIBDVDNAV + config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU bool "dvdspu"
package/multimedia/gst-plugins-bad/gst-plugins-bad.mk +7 -0
@@ -95,6 +95,13 @@ else GST_PLUGINS_BAD_CONF_OPT += --disable-dtmf endif +ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDNAV),y) +GST_PLUGINS_BAD_CONF_OPT += --enable-dvdnav +GST_PLUGINS_BAD_DEPENDENCIES += libdvdnav +else +GST_PLUGINS_BAD_CONF_OPT += --disable-dvdnav +endif + ifeq ($(BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_DVDSPU),y) GST_PLUGINS_BAD_CONF_OPT += --enable-dvdspu else
Signature · 1 line
1.6.5.4