ftrace.h: Use common pr_info fmt string
PATCH 1/1 ftrace.h: Use common pr_info fmt string
Reduces fmt string space a bit
include/trace/ftrace.h +1 -1
@@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ ret = register_trace_##call(ftrace_raw_event_##call); \ if (ret) \ pr_info("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \ return ret; \ } \ \
Commit-ID: 4819568f23a8bef0ca99b740ca60fe2450ab0aac Gitweb: http://git.kernel.org/tip/4819568f23a8bef0ca99b740ca60fe2450ab0aac Author: Joe Perches <[email protected]> AuthorDate: Sat, 12 Dec 2009 13:06:13 -0800 Committer: Ingo Molnar <[email protected]> CommitDate: Sun, 13 Dec 2009 08:14:45 +0100
ftrace.h: Use common pr_info fmt string
Reduces fmt string space a bit.
LKML-Reference: <[email protected]>
--- include/trace/ftrace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/trace/ftrace.h +1 -1
@@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ ret = register_trace_##call(ftrace_raw_event_##call); \ if (ret) \ pr_info("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \ return ret; \ } \ \
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 36 lines · Steven Rostedt
Quoted 25 lines · tip-bot for Joe Perches
Commit-ID: 4819568f23a8bef0ca99b740ca60fe2450ab0aac Gitweb: http://git.kernel.org/tip/4819568f23a8bef0ca99b740ca60fe2450ab0aac Author: Joe Perches <[email protected]> AuthorDate: Sat, 12 Dec 2009 13:06:13 -0800 Committer: Ingo Molnar <[email protected]> CommitDate: Sun, 13 Dec 2009 08:14:45 +0100
ftrace.h: Use commonpr_infofmt stringReduces fmt string space a bit.
Signed-off-by Joe Perches <[email protected]>Cc Frederic Weisbecker <[email protected]>Cc Steven Rostedt <[email protected]>LKML-Reference: <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>--- include/trace/ftrace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/trace/ftrace.h +0
-0include/trace/ftrace.h static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ · line 736
Quoted 5 lines
include/trace/ftrace.h +1
-1@@ -733,7 +733,7 @@ static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ ret = register_trace_##call(ftrace_raw_event_##call); \ if (ret) \ pr_info("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \This reduces format string space a bit, but doesn't it just add another string to the string tables #func == "func" as well as add code to pass in another parameter?
Quoted 1 line
-- Steve
Yeah, I don't understand the purpose of this patch either...
Quoted 8 lines · Frederic Weisbecker
Quoted 6 lines · Steven Rostedt
include/trace/ftrace.h static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ · line 736
Quoted 3 lines
include/trace/ftrace.h +1
-1pr_info ("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \This reduces format string space a bit, but doesn't it just add another string to the string tables #func == "func" as well as add code to pass in another parameter?
Yeah, I don't understand the purpose of this patch either...
For sched, it reduces size by ~1k.
Quoted 8 lines · Frederic Weisbecker
Quoted 6 lines · Steven Rostedt
include/trace/ftrace.h static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ · line 736
Quoted 3 lines
include/trace/ftrace.h +1
-1pr_info ("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \This reduces format string space a bit, but doesn't it just add another string to the string tables #func == "func" as well as add code to pass in another parameter?
Yeah, I don't understand the purpose of this patch either...
The patch from Li Zefan you've already queued is better
http://lkml.org/lkml/2009/12/13/60
Subject: [PATCH 03/13] tracing: Move a printk out of ftrace_raw_reg_event_foo()
Date: Sun, 13 Dec 2009 14:08:04 +0100
From: Li Zefan <[email protected]>
Move the printk from each ftrace_raw_reg_event_foo() to its caller ftrace_event_enable_disable(). This avoids each regfunc trace event callbacks to handle a same error report that can be carried from the caller.
Quoted 8 lines · Joe Perches
Quoted 7 lines · Frederic Weisbecker
Quoted 6 lines · Steven Rostedt
include/trace/ftrace.h static int ftrace_raw_reg_event_##call(struct ftrace_event_call *unused)\ · line 736
Quoted 3 lines
include/trace/ftrace.h +1
-1pr_info ("event trace: Could not activate trace point " \ - "probe to " #call "\n"); \ + "probe to %s\n", #call); \This reduces format string space a bit, but doesn't it just add another string to the string tables #func == "func" as well as add code to pass in another parameter?
Quoted 5 lines
Quoted 1 line
Yeah, I don't understand the purpose of this patch either...
The patch from Li Zefan you've already queued is better
Ok. Thanks.