Skip to contentSkip to conversation

Fix-a-typo-in-battery.c

PATCH In review Justin P. Mattock 2 participants 6 messages Dec 13, 2009 – Dec 14, 2009 ACPI

lore
Share & tools
lore
#0 lore raw

Fix a typo in a comment in
drivers/acpi/battery.c

 drivers/acpi/battery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
#1 lore raw

PATCH 1/1 Fix a typo in drivers/acpi/battery.c

---
 drivers/acpi/battery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/battery.c +1 -1
index 3f4602b..cada73f 100644
@@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
 					dev_name(&device->dev), event,
 					acpi_battery_present(battery));
 #ifdef CONFIG_ACPI_SYSFS_POWER
-	/* acpi_batter_update could remove power_supply object */
+	/* acpi_battery_update could remove power_supply object */
 	if (battery->bat.dev)
 		kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
 #endif
Signature · 1 line
1.6.5.5
#2 lore raw

Re: [PATCH] Fix a typo in drivers/acpi/battery.c

Quoted 11 lines · On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:
---
 drivers/acpi/battery.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/battery.c +0 -0
index 3f4602b..cada73f 100644

drivers/acpi/battery.c static void acpi_battery_notify(struct acpi_device *device, u32 event) · line 837

Quoted 8 lines
drivers/acpi/battery.c +1 -1
@@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
 					dev_name(&device->dev), event,
 					acpi_battery_present(battery));
 #ifdef CONFIG_ACPI_SYSFS_POWER
-	/* acpi_batter_update could remove power_supply object */
+	/* acpi_battery_update could remove power_supply object */
 	if (battery->bat.dev)
 		kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
 #endif

Hi,

You don't need an intro patch email and then the patch email for such a simple patch.

Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl) that acpi patches go to [email protected] .

---
~Randy

#3 lore raw

Re: [PATCH] Fix a typo in drivers/acpi/battery.c

Quoted 24 lines · Randy Dunlap
Quoted 10 lines · On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:
---
  drivers/acpi/battery.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/battery.c +0 -0
index 3f4602b..cada73f 100644

drivers/acpi/battery.c static void acpi_battery_notify(struct acpi_device *device, u32 event)

Quoted 9 lines
drivers/acpi/battery.c +1 -2
@@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
  					dev_name(&device->dev), event,
  					acpi_battery_present(battery));
  #ifdef CONFIG_ACPI_SYSFS_POWER
-	/* acpi_batter_update could remove power_supply object */
+	/* acpi_battery_update could remove power_supply object */
  	if (battery->bat.dev)
  		kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
  #endif
--

Hi,

Quoted 9 lines

You don't need an intro patch email and then the patch email for such a simple patch.

Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl) that acpi patches go to [email protected] .

---
~Randy

So should I resend this to acpi then, or just
take note of this the next time?

Justin P. Mattock

#4 lore raw

Re: [PATCH] Fix a typo in drivers/acpi/battery.c

Quoted 31 lines · On Sun, 13 Dec 2009 16:23:18 -0800 Justin P. Mattock wrote:
Quoted 30 lines · Randy Dunlap
Quoted 10 lines · On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:
---
  drivers/acpi/battery.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/battery.c +0 -0
index 3f4602b..cada73f 100644

drivers/acpi/battery.c static void acpi_battery_notify(struct acpi_device *device, u32 event)

Quoted 9 lines
drivers/acpi/battery.c +1 -2
@@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
  					dev_name(&device->dev), event,
  					acpi_battery_present(battery));
  #ifdef CONFIG_ACPI_SYSFS_POWER
-	/* acpi_batter_update could remove power_supply object */
+	/* acpi_battery_update could remove power_supply object */
  	if (battery->bat.dev)
  		kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
  #endif
--

Hi,

You don't need an intro patch email and then the patch email for such a simple patch.

Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl) that acpi patches go to [email protected] .

Quoted 6 lines
Quoted 3 lines

---
~Randy

So should I resend this to acpi then, or just
take note of this the next time?

I'd say resend to linux-acpi and cc: the acpi maintainer.

---
~Randy

#5 lore raw

Re: [PATCH] Fix a typo in drivers/acpi/battery.c

Quoted 37 lines · Randy Dunlap
Quoted 35 lines · On Sun, 13 Dec 2009 16:23:18 -0800 Justin P. Mattock wrote:
Quoted 33 lines · Randy Dunlap
Quoted 10 lines · On Sun, 13 Dec 2009 14:48:56 -0800 Justin P. Mattock wrote:
---
   drivers/acpi/battery.c |    2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/battery.c +0 -0
index 3f4602b..cada73f 100644

drivers/acpi/battery.c static void acpi_battery_notify(struct acpi_device *device, u32 event)

Quoted 9 lines
drivers/acpi/battery.c +1 -2
@@ -831,7 +831,7 @@ static void acpi_battery_notify(struct acpi_device *device, u32 event)
   					dev_name(&device->dev), event,
   					acpi_battery_present(battery));
   #ifdef CONFIG_ACPI_SYSFS_POWER
-	/* acpi_batter_update could remove power_supply object */
+	/* acpi_battery_update could remove power_supply object */
   	if (battery->bat.dev)
   		kobject_uevent(&battery->bat.dev->kobj, KOBJ_CHANGE);
   #endif
--

Hi,

You don't need an intro patch email and then the patch email for such a simple patch.

Also, please note (from "MAINTAINERS" or from scripts/get_maintainer.pl) that acpi patches go to [email protected] .

---
~Randy

Quoted 8 lines
Quoted 2 lines

So should I resend this to acpi then, or just
take note of this the next time?

I'd say resend to linux-acpi and cc: the acpi maintainer.

---
~Randy

there you have it.
cc'd len brown
(not sure who the acpi maintainers are)

Justin P. Mattock