Skip to contentSkip to conversation

regulator: refresh 88pm8607 driver with updated api

PATCH New Haojian Zhuang 3 participants 5 messages Dec 9, 2009 – Dec 15, 2009

lore
Share & tools
lore
#0 lore raw

PATCH v2 9/9 regulator: refresh 88pm8607 driver with updated api

#1 lore raw

PATCH v2 9/9 regulator: refresh 88pm8607 driver with updated api

Quoted 4 lines · Haojian Zhuang

Since i2c API of mfd 88pm860x driver is changed, refresh 88pm8607 driver. Remove the support of 88PM8607 A0/A1 stepping.

Might be nice to split the removal of the old devices into a separate patch but that is definitely a win. One blocker below, though.

Review

Quoted 3 lines
(quoted diff) +3 -0
+		ret = (index < 3) ? (index * 50000 + 1800000) :
+			((index < 7) ? (index * 50000 + 2550000) :
+			3300000);

I know the previous code did this but I'm really not loving the multiple ternery operators here for legibility.

Review

Quoted 4 lines
(quoted diff) +1 -1
 	return 0;
 }
-subsys_initcall(pm8607_regulator_init);
+module_init(pm8607_regulator_init);

This should be left at subsys_initcall() to try to ensure that the regulators are initialsied before the things that use them, otherwise the handling of init sequencing gets too complex.

#2 lore raw

PATCH v2 9/9 regulator: refresh 88pm8607 driver with updated api

Quoted 17 lines · Mark Brown
Quoted 4 lines · Haojian Zhuang

Since i2c API of mfd 88pm860x driver is changed, refresh 88pm8607 driver. Remove the support of 88PM8607 A0/A1 stepping.

Might be nice to split the removal of the old devices into a separate patch but that is definitely a win. ?One blocker below, though.

Quoted 3 lines

+ ? ? ? ? ? ? ret = (index < 3) ? (index * 50000 + 1800000) :
+ ? ? ? ? ? ? ? ? ? ? ((index < 7) ? (index * 50000 + 2550000) :
+ ? ? ? ? ? ? ? ? ? ? 3300000);

I know the previous code did this but I'm really not loving the multiple ternery operators here for legibility.

Quoted 9 lines

Review

Quoted 4 lines

? ? ? return 0;
?}

(quoted diff) +1 -1
-subsys_initcall(pm8607_regulator_init);
+module_init(pm8607_regulator_init);

This should be left at subsys_initcall() to try to ensure that the regulators are initialsied before the things that use them, otherwise the handling of init sequencing gets too complex.

Now split this patch into two. Thanks :)

Best Regards
Haojian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-regulator-refresh-88pm8607-driver-with-updated-api.patch
Type: text/x-patch
Size: 5509 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091209/00e76454/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-regulator-unsupport-88pm8607-A0-and-A1.patch
Type: text/x-patch
Size: 9843 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091209/00e76454/attachment-0003.bin>

#4 lore raw

PATCH v2 9/9 regulator: refresh 88pm8607 driver with updated api

In reply to Haojian Zhuang
Quoted 29 lines · Haojian Zhuang
Quoted 17 lines · Mark Brown
Quoted 4 lines · Haojian Zhuang

Since i2c API of mfd 88pm860x driver is changed, refresh 88pm8607 driver. Remove the support of 88PM8607 A0/A1 stepping.

Might be nice to split the removal of the old devices into a separate patch but that is definitely a win. One blocker below, though.

Review

Quoted 3 lines
(quoted diff) +3 -0
+             ret = (index < 3) ? (index * 50000 + 1800000) :
+                     ((index < 7) ? (index * 50000 + 2550000) :
+                     3300000);

I know the previous code did this but I'm really not loving the multiple ternery operators here for legibility.

Quoted 9 lines

Review

Quoted 4 lines
      return 0;

}

(quoted diff) +1 -1
-subsys_initcall(pm8607_regulator_init);
+module_init(pm8607_regulator_init);

This should be left at subsys_initcall() to try to ensure that the regulators are initialsied before the things that use them, otherwise the handling of init sequencing gets too complex.

Quoted 1 line

Now split this patch into two. Thanks :)

Applied both.

Thanks

Liam