regulator: wm831x_reg_read() failure unnoticed in wm831x_aldo_get_mode()
PATCH 1/1 regulator: wm831x_reg_read() failure unnoticed in wm831x_aldo_get_mode()
ret should be signed to notice a failure in wm831x_reg_read().
Signed-off-by Roel Kluin <[email protected]>
---
Found using coccinelle: http://coccinelle.lip6.fr/
drivers/regulator/wm831x-ldo.c +1 -1
@@ -470,7 +470,7 @@ static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev)struct wm831x_ldo *ldo =rdev_get_drvdata (rdev);struct wm831x *wm831x = ldo->wm831x;int on_reg = ldo->base +WM831X_LDO_ON_CONTROL ; -unsigned int ret; +int ret; ret =wm831x_reg_read (wm831x, on_reg);if (ret <0 )
Quoted 3 lines · Roel Kluin
ret should be signed to notice a failure in
wm831x_reg_read().Signed-off-by Roel Kluin <[email protected]>
Thanks
Acked-by Mark Brown <[email protected]>
Liam Girdwood
AppliedQuoted 11 lines · Roel Kluin
ret should be signed to notice a failure in
wm831x_reg_read().Signed-off-by Roel Kluin <[email protected]>---
Found using coccinelle: http://coccinelle.lip6.fr/drivers/regulator/wm831x-ldo.c +0
-0
drivers/regulator/wm831x-ldo.c static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev) · line 476
Quoted 8 lines
drivers/regulator/wm831x-ldo.c +1
-1@@ -470,7 +470,7 @@ static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev)struct wm831x_ldo *ldo =rdev_get_drvdata (rdev);struct wm831x *wm831x = ldo->wm831x;int on_reg = ldo->base +WM831X_LDO_ON_CONTROL ; -unsigned int ret; +int ret; ret =wm831x_reg_read (wm831x, on_reg);if (ret <0 )
Applied.
Thanks
Liam