hw-breakpoint: Fix hardware breakpoints -> perf events dependency
PATCH 1/1 hw-breakpoint: Fix hardware breakpoints -> perf events dependency
The kbuild's select command doesn't propagate through the config dependencies.
Hence the current rules of hardware breakpoint's config can't ensure perf can never be disabled under us.
We have:
config X86
selects HAVE_HW_BREAKPOINTS
config HAVE_HW_BREAKPOINTS
select PERF_EVENTS
config PERF_EVENTS
[...]
x86 will select the breakpoints but that won't propagate to perf events. The user can still disable the latter, but it is necessary for the breakpoints.
What we need is:
- x86 selects HAVE_HW_BREAKPOINTS and PERF_EVENTS
- HAVE_HW_BREAKPOINTS depends on PERF_EVENTS
so that we ensure PERF_EVENTS is enabled and frozen for x86.
This fixes the following kind of build errors:
In file included from arch/x86/kernel/hw_breakpoint.c:31:include/linux/hw_breakpoint.h: In function 'hw_breakpoint_addr':include/linux/hw_breakpoint.h:39: error: 'struct perf_event' has no member named 'attr' include/linux/hw_breakpoint.h: In function 'hw_breakpoint_type':include/linux/hw_breakpoint.h:44: error: 'struct perf_event' has no member named 'attr' include/linux/hw_breakpoint.h: In function 'hw_breakpoint_len':include/linux/hw_breakpoint.h:49: error: 'struct perf_event' has no member named 'attr' include/linux/hw_breakpoint.h: In function 'counter_arch_bp':include/linux/hw_breakpoint.h:85: error: 'struct perf_event' has no member named 'hw'
--- arch/Kconfig | 4 +--- arch/x86/Kconfig | 1 + 2 files changed, 2 insertions(+), 3 deletions(-)
arch/Kconfig +1 -3
@@ -138,9 +138,7 @@ config HAVE_USER_RETURN_NOTIFIER config HAVE_HW_BREAKPOINT bool - depends on HAVE_PERF_EVENTS - select ANON_INODES - select PERF_EVENTS + depends on PERF_EVENTS source "kernel/gcov/Kconfig"
arch/x86/Kconfig +1 -0
@@ -50,6 +50,7 @@ config X86 select HAVE_KERNEL_BZIP2 select HAVE_KERNEL_LZMA select HAVE_HW_BREAKPOINT + select PERF_EVENTS select HAVE_ARCH_KMEMCHECK select HAVE_USER_RETURN_NOTIFIER
Signature · 1 line
1.6.2.3
PATCH v2 1/1 hw-breakpoint: Fix hardware breakpoints -> perf events dependency
The kbuild's select command doesn't propagate through the config dependencies.
Hence the current rules of hardware breakpoint's config can't ensure perf can never be disabled under us.
We have:
config X86
selects HAVE_HW_BREAKPOINTS
config HAVE_HW_BREAKPOINTS
select PERF_EVENTS
config PERF_EVENTS
[...]
x86 will select the breakpoints but that won't propagate to perf events. The user can still disable the latter, but it is necessary for the breakpoints.
What we need is:
- x86 selects HAVE_HW_BREAKPOINTS and PERF_EVENTS
- HAVE_HW_BREAKPOINTS depends on PERF_EVENTS
so that we ensure PERF_EVENTS is enabled and frozen for x86.
This fixes the following kind of build errors:
In file included from arch/x86/kernel/hw_breakpoint.c:31:include/linux/hw_breakpoint.h: In function 'hw_breakpoint_addr':include/linux/hw_breakpoint.h:39: error: 'struct perf_event' has no member named 'attr' include/linux/hw_breakpoint.h: In function 'hw_breakpoint_type':include/linux/hw_breakpoint.h:44: error: 'struct perf_event' has no member named 'attr' include/linux/hw_breakpoint.h: In function 'hw_breakpoint_len':include/linux/hw_breakpoint.h:49: error: 'struct perf_event' has no member named 'attr' include/linux/hw_breakpoint.h: In function 'counter_arch_bp':include/linux/hw_breakpoint.h:85: error: 'struct perf_event' has no member named 'hw'
v2: Select also ANON_INODES from x86, required for perf
--- arch/Kconfig | 4 +--- arch/x86/Kconfig | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-)
arch/Kconfig +1 -3
@@ -138,9 +138,7 @@ config HAVE_USER_RETURN_NOTIFIER config HAVE_HW_BREAKPOINT bool - depends on HAVE_PERF_EVENTS - select ANON_INODES - select PERF_EVENTS + depends on PERF_EVENTS source "kernel/gcov/Kconfig"
arch/x86/Kconfig +2 -0
@@ -50,6 +50,8 @@ config X86 select HAVE_KERNEL_BZIP2 select HAVE_KERNEL_LZMA select HAVE_HW_BREAKPOINT + select PERF_EVENTS + select ANON_INODES select HAVE_ARCH_KMEMCHECK select HAVE_USER_RETURN_NOTIFIER
Signature · 1 line
1.6.2.3
On Thu, Dec 17, 2009 at 01:33:54AM +0100, Frederic Weisbecker wrote:
...
Quoted 13 lines
This fixes the following kind of build errors:
In file included from
arch/x86/kernel/hw_breakpoint.c:31:include/linux/hw_breakpoint.h: In function 'hw_breakpoint_addr':include/linux/hw_breakpoint.h:39: error: 'structperf_event' has no member named 'attr'include/linux/hw_breakpoint.h: In function 'hw_breakpoint_type':include/linux/hw_breakpoint.h:44: error: 'structperf_event' has no member named 'attr'include/linux/hw_breakpoint.h: In function 'hw_breakpoint_len':include/linux/hw_breakpoint.h:49: error: 'structperf_event' has no member named 'attr'include/linux/hw_breakpoint.h: In function 'counter_arch_bp':include/linux/hw_breakpoint.h:85: error: 'structperf_event' has no member named 'hw'
Quoted 2 lines
v2: Select also
ANON_INODESfrom x86, required for perf
...
Thanks Frederic! It did trick for me.
-- Cyrill
[tip:perf/urgent] hw-breakpoints: Fix hardware breakpoints -> perf events dependency
In reply to Frederic WeisbeckerCommit-ID: 99e8c5a3b875a34d894a711c9a3669858d6adf45 Gitweb: http://git.kernel.org/tip/99e8c5a3b875a34d894a711c9a3669858d6adf45 Author: Frederic Weisbecker <[email protected]> AuthorDate: Thu, 17 Dec 2009 01:33:54 +0100 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 18 Dec 2009 13:11:51 +0100
hw-breakpoints: Fix hardware breakpoints -> perf events dependency
The kbuild's select command doesn't propagate through the config dependencies.
Hence the current rules of hardware breakpoint's config can't ensure perf can never be disabled under us.
We have:
config X86
selects HAVE_HW_BREAKPOINTS
config HAVE_HW_BREAKPOINTS
select PERF_EVENTS
config PERF_EVENTS
[...]
x86 will select the breakpoints but that won't propagate to perf events. The user can still disable the latter, but it is necessary for the breakpoints.
What we need is:
- x86 selects HAVE_HW_BREAKPOINTS and PERF_EVENTS
- HAVE_HW_BREAKPOINTS depends on PERF_EVENTS
so that we ensure PERF_EVENTS is enabled and frozen for x86.
This fixes the following kind of build errors:
In file included from arch/x86/kernel/hw_breakpoint.c:31:
include/linux/hw_breakpoint.h: In function 'hw_breakpoint_addr':
include/linux/hw_breakpoint.h:39: error: 'struct perf_event' has no member named 'attr'
v2: Select also ANON_INODES from x86, required for perf
LKML-Reference: <[email protected]>
--- arch/Kconfig | 4 +--- arch/x86/Kconfig | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-)
arch/Kconfig +1 -3
@@ -135,9 +135,7 @@ config HAVE_DEFAULT_NO_SPIN_MUTEXES config HAVE_HW_BREAKPOINT bool - depends on HAVE_PERF_EVENTS - select ANON_INODES - select PERF_EVENTS + depends on PERF_EVENTS config HAVE_USER_RETURN_NOTIFIER bool
arch/x86/Kconfig +2 -0
@@ -50,6 +50,8 @@ config X86 select HAVE_KERNEL_BZIP2 select HAVE_KERNEL_LZMA select HAVE_HW_BREAKPOINT + select PERF_EVENTS + select ANON_INODES select HAVE_ARCH_KMEMCHECK select HAVE_USER_RETURN_NOTIFIER