Skip to contentSkip to conversation

S390: Fail on unknown instructions

PATCH New Alexander Graf 1 participant 1 message Dec 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 S390: Fail on unknown instructions

We were being a bit too nice and didn't give the guest an invalid instruction interrupt.

While that works, it's not exactly the fastest thing to do, since now the guest doesn't know that we're not really implementing that instruction, so it continues doing it.

We run into this with the set_page_unstable hint instruction. So let's bail out in these cases.

---
 target-s390x/kvm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
target-s390x/kvm.c +1 -1
index b6aac42..0992563 100644
@@ -405,7 +405,7 @@ static int handle_instruction(CPUState *env, struct kvm_run *run)
     unsigned int ipa0 = (run->s390_sieic.ipa & 0xff00);
     uint8_t ipa1 = run->s390_sieic.ipa & 0x00ff;
     int ipb_code = (run->s390_sieic.ipb & 0x0fff0000) >> 16;
-    int r = 0;
+    int r = -1;
 
     dprintf("handle_instruction 0x%x 0x%x\n", run->s390_sieic.ipa, run->s390_sieic.ipb);
     switch (ipa0) {
Signature · 1 line
1.6.0.2