Skip to contentSkip to conversation

lvconvert fix

PATCH New Jonathan Brassow 1 participant 1 message Dec 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lvconvert fix

brassow

The patch fixes some lvconvert issues (WRT mirror <-> mirror).

The default log option for a mirror is 'disk'. If the log type is not explicitly stated on the command line when converting from an X-way mirror to a Y-way mirror, 'disk' is chosen. So, if you have a 'core' log mirror and you convert, your result will contain a 'disk' log.

This patch remembers what the old log type was. If the user is merely trying to switch the number of mirror images, the log type is now kept the same.

There is one historical behaviour I left in place... If you have a 2-way, core-log mirror and you use lvconvert to specify you want a 2-way mirror - without specifying the log type - you will get a 2-way, disk-log mirror.

tools/lvconvert.c +11 -0
Index: LVM2/tools/lvconvert.c
===================================================================
@@ -577,6 +577,17 @@ static int _lvconvert_mirrors(struct cmd
 		return 0;
 	}
 
+	/*
+	 * If we are converting from one type of mirror to another, and
+	 * the type of log wasn't specified, then let's keep the log type
+	 * the same.
+	 */
+	if (existing_mirrors && lp->mirrors &&
+	    (lp->mirrors != existing_mirrors) &&
+	    !arg_count(cmd, mirrorlog_ARG) && !arg_count(cmd, corelog_ARG)) {
+		corelog = first_seg(lv)->log_lv ? 0 : 1;
+	}
+
 	if (repair) {
 		cmd->handles_missing_pvs = 1;
 		cmd->partial_activation = 1;