Skip to contentSkip to conversation

Cleanup for handle constraint from DSP

PATCH New Omar Ramirez Luna 1 participant 3 messages Dec 22, 2009

lore
Share & tools
lore
#0 lore raw

cover Cleanup for handle constraint from DSP

Omar Ramirez Luna (2):
DSPBRIDGE: Avoid saving mailbox settings on constraint request
DSPBRIDGE: remove useless return statement

 drivers/dsp/bridge/wmd/tiomap3430_pwr.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
#1 lore raw

PATCH 1/2 DSPBRIDGE: Avoid saving mailbox settings on constraint request

There is no need to save the mailbox settings if a request to set the OPP constraint comes from the DSP.

---
 drivers/dsp/bridge/wmd/tiomap3430_pwr.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/dsp/bridge/wmd/tiomap3430_pwr.c +0 -5
index fd6097d..68b6993 100644
@@ -80,18 +80,13 @@ DSP_STATUS handle_constraints_set(struct WMD_DEV_CONTEXT *pDevContext,
 {
 #ifdef CONFIG_BRIDGE_DVFS
 	u32 *pConstraintVal;
-	DSP_STATUS status = DSP_SOK;
-	struct CFG_HOSTRES resources;
 	struct dspbridge_platform_data *pdata =
 		omap_dspbridge_dev->dev.platform_data;
-	status = CFG_GetHostResources(
-		(struct CFG_DEVNODE *)DRV_GetFirstDevExtension(), &resources);
 
 	pConstraintVal = (u32 *)(pArgs);
 	/* Read the target value requested by DSP  */
 	DBG_Trace(DBG_LEVEL7, "handle_constraints_set:"
 		"opp requested = 0x%x\n", (u32)*(pConstraintVal+1));
-	status = HW_MBOX_saveSettings(resources.dwMboxBase);
 
 	/* Set the new opp value */
 	if (pdata->dsp_set_min_opp)
Signature · 1 line
1.6.2.4
#2 lore raw

PATCH 2/2 DSPBRIDGE: remove useless return statement

Remove useless return in function to set an OPP constraint.

---
 drivers/dsp/bridge/wmd/tiomap3430_pwr.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/dsp/bridge/wmd/tiomap3430_pwr.c +0 -1
index 68b6993..d7ed894 100644
@@ -91,7 +91,6 @@ DSP_STATUS handle_constraints_set(struct WMD_DEV_CONTEXT *pDevContext,
 	/* Set the new opp value */
 	if (pdata->dsp_set_min_opp)
 		(*pdata->dsp_set_min_opp)((u32)*(pConstraintVal+1));
-	return DSP_SOK;
 #endif /* #ifdef CONFIG_BRIDGE_DVFS */
 	return DSP_SOK;
 }
Signature · 1 line
1.6.2.4