Skip to contentSkip to conversation

omap3: Remove extern declarations from headers

PATCH New Sanjeev Premi 3 participants 3 messages Dec 23, 2009 – Dec 24, 2009

lore
Share & tools
lore
#0 lore raw

cover omap3: Remove extern declarations from headers

All configurations based on OMAP3 contained extern declarations.

This set contains two patches that move these declarations and fix the side-effects of the move.

Sanjeev Premi (2):
omap3: Remove externs from config files
omap3: Remove multiple extern decls for gpmc_cfg

 board/ti/evm/evm.c                       |    3 +-
 cpu/arm_cortexa8/omap3/sys_info.c        |    1 +
 include/asm-arm/arch-omap3/omap3_flash.h |   34 ++++++++++++++++++++++++++++++
 include/asm-arm/arch-omap3/omap_gpmc.h   |    5 ++++
 include/configs/omap3_beagle.h           |   12 +++-------
 include/configs/omap3_evm.h              |   14 ++++--------
 include/configs/omap3_overo.h            |   14 ++++--------
 include/configs/omap3_pandora.h          |   12 +++-------
 include/configs/omap3_sdp3430.h          |   13 +++--------
 include/configs/omap3_zoom1.h            |   13 ++++-------
 include/configs/omap3_zoom2.h            |   13 ++++-------
 11 files changed, 74 insertions(+), 60 deletions(-)
 create mode 100644 include/asm-arm/arch-omap3/omap3_flash.h
#1 lore raw

cover omap3: Remove extern declarations from headers

Quoted 22 lines · Sanjeev Premi

All configurations based on OMAP3 contained extern declarations.

This set contains two patches that move these declarations and fix the side-effects of the move.

Sanjeev Premi (2):
omap3: Remove externs from config files
omap3: Remove multiple extern decls for gpmc_cfg

  board/ti/evm/evm.c                       |    3 +-
  cpu/arm_cortexa8/omap3/sys_info.c        |    1 +
  include/asm-arm/arch-omap3/omap3_flash.h |   34 ++++++++++++++++++++++++++++++
  include/asm-arm/arch-omap3/omap_gpmc.h   |    5 ++++
  include/configs/omap3_beagle.h           |   12 +++-------
  include/configs/omap3_evm.h              |   14 ++++--------
  include/configs/omap3_overo.h            |   14 ++++--------
  include/configs/omap3_pandora.h          |   12 +++-------
  include/configs/omap3_sdp3430.h          |   13 +++--------
  include/configs/omap3_zoom1.h            |   13 ++++-------
  include/configs/omap3_zoom2.h            |   13 ++++-------
  11 files changed, 74 insertions(+), 60 deletions(-)
Quoted 1 line

create mode 100644 include/asm-arm/arch-omap3/omap3_flash.h

Could you kindly elaborate on what's the advantage of this and why it is necessary?

Many thanks

Dirk

#2 lore raw

cover omap3: Remove extern declarations from headers

Quoted 34 lines

-----Original Message-----
From: Dirk Behme [mailto:dirk.behme at googlemail.com]
Sent: Thursday, December 24, 2009 11:28 AM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 0/2] omap3: Remove extern declarations from headers

Quoted 6 lines · Sanjeev Premi

All configurations based on OMAP3 contained extern declarations.

This set contains two patches that move these declarations and fix the side-effects of the move.

Quoted 7 lines

Sanjeev Premi (2):
omap3: Remove externs from config files
omap3: Remove multiple extern decls for gpmc_cfg

  board/ti/evm/evm.c                       |    3 +-
  cpu/arm_cortexa8/omap3/sys_info.c        |    1 +
  include/asm-arm/arch-omap3/omap3_flash.h |   34 

++++++++++++++++++++++++++++++

Quoted 10 lines
  include/asm-arm/arch-omap3/omap_gpmc.h   |    5 ++++
  include/configs/omap3_beagle.h           |   12 +++-------
  include/configs/omap3_evm.h              |   14 ++++--------
  include/configs/omap3_overo.h            |   14 ++++--------
  include/configs/omap3_pandora.h          |   12 +++-------
  include/configs/omap3_sdp3430.h          |   13 +++--------
  include/configs/omap3_zoom1.h            |   13 ++++-------
  include/configs/omap3_zoom2.h            |   13 ++++-------
  11 files changed, 74 insertions(+), 60 deletions(-)

create mode 100644 include/asm-arm/arch-omap3/omap3_flash.h

Quoted 2 lines

Could you kindly elaborate on what's the advantage of this and why it is necessary?

While submitting the patches for AM3517, Wolfgang had mentioned that etxerns should not be declated in the configs. He and Tom insisted that mistake cannot be propagated further. And fix had to be found now.

See thread:
http://www.mail-archive.com/u-boot at lists.denx.de/msg25749.html

Specifically:
http://www.mail-archive.com/u-boot at lists.denx.de/msg26154.html
http://www.mail-archive.com/u-boot at lists.denx.de/msg25772.html

This patch is a must before the AM3517 could be supported.

Best regards,
Sanjeev

Quoted 5 lines

Many thanks

Dirk