Skip to contentSkip to conversation

L4 interconnect memory mapping

DISCUSSION Felipe Balbi 4 participants 7 messages Dec 29, 2009 – Dec 30, 2009

lore
Share & tools
lore
#0 lore raw

Hi Tony and Paul,

maybe a silly question, but here it goes:

Do we have any piece of code handling the L4 interconnect memory space ? I mean, looking at omap3 TRM pages 212 - 219, I see that e.g. for the musb block we have:

HS USB OTG 0x480AB000 - 0x480ABFFF 4KB Module

		0x480AC000 - 0x480ACFFF	4KB	L4 interconnect

So the first 4K is what we pass down to drivers via struct resource and the second 4K ? What do we do with that ?

Signature · 1 line
balbi
#1 lore raw

Hi,

Quoted 8 lines · Felipe Balbi

Hi Tony and Paul,

maybe a silly question, but here it goes:

Do we have any piece of code handling the L4 interconnect memory space ? I mean, looking at omap3 TRM pages 212 - 219, I see that e.g. for the musb block we have:

Quoted 5 lines

HS USB OTG 0x480AB000 - 0x480ABFFF 4KB Module

		0x480AC000 - 0x480ACFFF	4KB	L4 interconnect

So the first 4K is what we pass down to drivers via struct resource and the second 4K ? What do we do with that ?

no with Paul's address correct.

Signature · 1 line
balbi
#2 lore raw
Quoted 11 lines · Felipe Balbi

Hi,

Quoted 8 lines · Felipe Balbi

Hi Tony and Paul,

maybe a silly question, but here it goes:

Do we have any piece of code handling the L4 interconnect memory space ? I mean, looking at omap3 TRM pages 212 - 219, I see that e.g. for the musb block we have:

Quoted 7 lines
Quoted 5 lines

HS USB OTG 0x480AB000 - 0x480ABFFF 4KB Module

		0x480AC000 - 0x480ACFFF	4KB	L4 interconnect

So the first 4K is what we pass down to drivers via struct resource and the second 4K ? What do we do with that ?

no with Paul's address correct.

Looks like you might want to update your earlier patch to just comment that the 8K address space for musb is 4K + 4K for L4 interconnect :)

Tony

#3 lore raw
Quoted 15 lines · Tony Lindgren
Quoted 14 lines · Felipe Balbi

Hi,

Quoted 11 lines · Felipe Balbi

Hi Tony and Paul,

maybe a silly question, but here it goes:

Do we have any piece of code handling the L4 interconnect memory space ? I mean, looking at omap3 TRM pages 212 - 219, I see that e.g. for the musb block we have:

HS USB OTG 0x480AB000 - 0x480ABFFF 4KB Module

		0x480AC000 - 0x480ACFFF	4KB	L4 interconnect
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

So the first 4K is what we pass down to drivers via struct resource and the second 4K ? What do we do with that ?

no with Paul's address correct.

Looks like you might want to update your earlier patch to just comment that the 8K address space for musb is 4K + 4K for L4 interconnect :)

was thinking about that just now heh, but what do we do with the extra 4k ? It's the same for all other modules. Is omap_hwmod taking care of that ?

Signature · 1 line
balbi
#4 lore raw
Quoted 27 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Felipe Balbi
Sent: Wednesday, December 30, 2009 5:20 AM
To: Tony Lindgren
Cc: [email protected]; [email protected]
Subject: Re: L4 interconnect memory mapping

Quoted 18 lines · Tony Lindgren
Quoted 17 lines · Felipe Balbi

Hi,

Quoted 13 lines · Felipe Balbi

Hi Tony and Paul,

maybe a silly question, but here it goes:

Do we have any piece of code handling the L4 interconnect memory space ? I mean, looking at omap3 TRM pages 212 - 219, I see that e.g. for the musb block we have:

HS USB OTG 0x480AB000 - 0x480ABFFF 4KB Module

		0x480AC000 - 0x480ACFFF	4KB	L4 interconnect

So the first 4K is what we pass down to drivers via struct resource and the second 4K ? What do we do with that ?

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

no with Paul's address correct.

Looks like you might want to update your earlier patch to just comment that the 8K address space for musb is 4K + 4K for L4 interconnect :)

was thinking about that just now heh, but what do we do with the extra 4k ? It's the same for all other modules. Is omap_hwmod taking care of that ?

I don't think you need to map 8k if there is no additional register in upper 4K.
All memory spaces described as modules provide direct access to the module registers outside the L4 interconnect. All other accesses are internal to the L4 interconnect ( L4_CFG, L4_PER).

Regards,
Santosh

#5 lore raw
In reply to Felipe Balbi
Quoted 19 lines · Felipe Balbi
Quoted 18 lines · Tony Lindgren
Quoted 17 lines · Felipe Balbi

Hi,

Quoted 13 lines · Felipe Balbi

Hi Tony and Paul,

maybe a silly question, but here it goes:

Do we have any piece of code handling the L4 interconnect memory space ? I mean, looking at omap3 TRM pages 212 - 219, I see that e.g. for the musb block we have:

HS USB OTG 0x480AB000 - 0x480ABFFF 4KB Module

		0x480AC000 - 0x480ACFFF	4KB	L4 interconnect

So the first 4K is what we pass down to drivers via struct resource and the second 4K ? What do we do with that ?

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

no with Paul's address correct.

Looks like you might want to update your earlier patch to just comment that the 8K address space for musb is 4K + 4K for L4 interconnect :)

was thinking about that just now heh, but what do we do with the extra 4k ? It's the same for all other modules. Is omap_hwmod taking care of that ?

That second 4KiB range is the interconnect target agent between the interconnect and the HS USB OTG IP block. No need to deal with it. At some point either omap_hwmod or an interconnect driver will probably reserve it for bookkeeping purposes.

- Paul

#6 lore raw

Hi,

Quoted 4 lines · Paul Walmsley

That second 4KiB range is the interconnect target agent between the interconnect and the HS USB OTG IP block. No need to deal with it. At some point either omap_hwmod or an interconnect driver will probably reserve it for bookkeeping purposes.

Ok, got it. Thanks for the info.

Signature · 1 line
balbi