Skip to contentSkip to conversation

drm/radeon/radeon_fence.c: move a dereference below the NULL test

PATCH New Darren Jenkins 1 participant 1 message Dec 30, 2009 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon/radeon_fence.c: move a dereference below the NULL test

If a NULL value is possible, the dereference should only occur after the NULL test.

Coverity CID: 13334

gpu/drm/radeon/radeon_fence.c +3 -3
index 4cdd8b4..f3a8380 100644
@@ -140,14 +140,14 @@ int radeon_fence_create(struct radeon_device *rdev, struct radeon_fence **fence)
 
 bool radeon_fence_signaled(struct radeon_fence *fence)
 {
-	struct radeon_device *rdev = fence->rdev;
 	unsigned long irq_flags;
 	bool signaled = false;
 
-	if (rdev->gpu_lockup) {
+	if (fence = NULL) {
 		return true;
 	}
-	if (fence = NULL) {
+
+	if (fence->rdev->gpu_lockup) {
 		return true;
 	}
 	write_lock_irqsave(&fence->rdev->fence_drv.lock, irq_flags);