drm/radeon/radeon_cp.c: fix resource leak on error

PATCH In review Darren Jenkins 2 participants 2 messages Dec 30, 2009 – Jan 7, 2010 Kernel janitors

lore

Share & tools

lore

Darren Jenkins

author

2009-12-30 01:25 UTC #0 lore raw

PATCH 1/1 drm/radeon/radeon_cp.c: fix resource leak on error

If drm_addmap() fails master_priv is leaked.

Coverity CID: 13195

Signed-off-by Darren Jenkins <[email protected]>

gpu/drm/radeon/radeon_cp.c +1 -0

index 0b2f9c2..06123ba 100644
@@ -2145,6 +2145,7 @@ int radeon_master_create(struct drm_device *dev, struct drm_master *master)
 			 &master_priv->sarea);
 	if (ret) {
 		DRM_ERROR("SAREA setup failed\n");
+		kfree(master_priv);
 		return ret;
 	}
 	master_priv->sarea_priv = master_priv->sarea->handle + sizeof(struct drm_sarea);

Dave Airlie

2010-01-07 03:47 UTC #1 lore raw

Quoted 2 lines · Darren Jenkins

If drm_addmap() fails master_priv is leaked.

I got a patch from Roel Kluin to fix this already, will push it out soon.

Dave.