Two small patches
PATCH 1/1 Two small patches
Hi,
2 patches:
- use defined variable is_proximity
-remove duplicate comment from xf86WacomDefs.h
Those two are not important, but I don't want to leave it till later - "the later" it might never happen.
--
Przemo
Quoted 1 line
From
a1865a5f06f165a398d9a87d34c96b59b1d8660cMon Sep 17 00:00:00 2001
From: Przemo Firszt <[email protected]>
Date: Mon, 4 Jan 2010 19:25:20 +0000
Subject: [PATCH 2/3] is_proximity is defined, so let's use it
--- src/wcmCommon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
src/wcmCommon.c +1 -1
@@ -779,7 +779,7 @@ void xf86WcmSendEvents(LocalDevicePtr local, const WacomDeviceState* ds) }/* don't move the cursor when going out-prox */ -if (!ds->proximity) +if (!is_proximity) { x = priv->oldX; y = priv->oldY;
Signature · 1 line
1.6.5.7
Quoted 1 line
From
714b4b3b989ae5a36b839bd4fe229999233cd192Mon Sep 17 00:00:00 2001
From: Przemo Firszt <[email protected]>
Date: Mon, 4 Jan 2010 23:13:06 +0000
Subject: [PATCH 3/3] Remove duplicate comment in xf86WacomDefs.h
--- src/xf86WacomDefs.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
src/xf86WacomDefs.h +0 -4
@@ -324,10 +324,6 @@ struct _WacomChannelWacomDeviceState work;/* next state */ -/* the following struct contains the current known state of the -* device channel, as well as the previous MAX_SAMPLES states -* for use in detecting hardware defects, jitter, trends, etc. */ -/* the following union contains the current known state of the * device channel, as well as the previous MAX_SAMPLES states * for use in detecting hardware defects, jitter, trends, etc. */
Signature · 1 line
1.6.5.7
Peter Hutterer
AppliedQuoted 36 lines · Przemysław Firszt
Hi,
2 patches:
- use defined variableis_proximity
-remove duplicate comment fromxf86WacomDefs.hThose two are not important, but I don't want to leave it till later - "the later" it might never happen.
--
PrzemoFrom
a1865a5f06f165a398d9a87d34c96b59b1d8660cMon Sep 17 00:00:00 2001
From: Przemo Firszt <[email protected]>
Date: Mon, 4 Jan 2010 19:25:20 +0000
Subject: [PATCH 2/3]is_proximityis defined, so let's use itSigned-off-by Przemo Firszt <[email protected]>--- src/wcmCommon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)src/wcmCommon.c +1
-1@@ -779,7 +779,7 @@ void xf86WcmSendEvents(LocalDevicePtr local, const WacomDeviceState* ds) }/* don't move the cursor when going out-prox */ -if (!ds->proximity) +if (!is_proximity) { x = priv->oldX; y = priv->oldY;Signature · 1 line
1.6.5.7
I'd prefer a more verbose explanation here. Why not just use ds->proximity and remove is_proximity? (I know the answer, but it'd be nice to get it from the patch, not from the code)
Quoted 27 lines
From
714b4b3b989ae5a36b839bd4fe229999233cd192Mon Sep 17 00:00:00 2001
From: Przemo Firszt <[email protected]>
Date: Mon, 4 Jan 2010 23:13:06 +0000
Subject: [PATCH 3/3] Remove duplicate comment inxf86WacomDefs.hSigned-off-by Przemo Firszt <[email protected]>--- src/xf86WacomDefs.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)src/xf86WacomDefs.h +0
-4@@ -324,10 +324,6 @@ struct _WacomChannelWacomDeviceState work;/* next state */ -/* the following struct contains the current known state of the -* device channel, as well as the previous MAX_SAMPLES states -* for use in detecting hardware defects, jitter, trends, etc. */ -/* the following union contains the current known state of the * device channel, as well as the previous MAX_SAMPLES states * for use in detecting hardware defects, jitter, trends, etc. */ Signature · 1 line
1.6.5.7
merged, thanks.
Cheers,
Peter
Marcel Holtmann
maintainerHi Przemo,
Quoted 6 lines
2 patches:
- use defined variableis_proximity
-remove duplicate comment fromxf86WacomDefs.hThose two are not important, but I don't want to leave it till later - "the later" it might never happen.
I think the Bluetooth mailing list is the wrong on here. Better use some X.org related mailing list or similar.
Regards
Marcel
Dnia 2010-01-04, pon o godzinie 15:34 -0800, Marcel Holtmann pisze:
[..]
Quoted 2 lines
I think the Bluetooth mailing list is the wrong on here. Better use some X.org related mailing list or similar.
Ooops, sorry for the noise - wrong list.
Przemo