cdc-ether: Assume link is up initially

The bug report <http://bugzilla.kernel.org/show_bug.cgi?id=14791>
implies that at least some devices will not send a Network Connection notification if the link is initially up. Further, the CDC-ECM specification states that '[n]etworking devices are typically "Always Connected", spending all of their time with the "link up"'. So it appears to be safer to assume the link is up and to rely on the device to tell us otherwise.

This is a partial revert of:

commit 37e8273cd30592d3a82bcb70cbb1bdc4eaeb6b71

Author: Ben Hutchings <ben-/[email protected]>
Date:   Wed Nov 4 15:29:52 2009 +0000

usbnet: Set link down initially for drivers that update link state

---
This should be tested by someone with one of these devices, preferably you since you reported the bug.

Ben.

 drivers/net/usb/cdc_ether.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

index 21e183a..4f27f02 100644
@@ -419,7 +419,7 @@ static int cdc_manage_power(struct usbnet *dev, int on)
 
 static const struct driver_info	cdc_info = {
 	.description =	"CDC Ethernet Device",
-	.flags =	FLAG_ETHER | FLAG_LINK_INTR,
+	.flags =	FLAG_ETHER,
 	// .check_connect = cdc_check_connect,
 	.bind =		cdc_bind,
 	.unbind =	usbnet_cdc_unbind,

1.6.5.7

Mail to reporter bounces, so someone else had better check this.

Ben.

Ben Hutchings
Horngren's Observation:
                   Among economists, the real world is often a special case.

From: Ben Hutchings <ben-/[email protected]>
Date: Wed, 06 Jan 2010 01:47:15 +0000

I'm tossing this patch until someone can reproduce and test the fix.

Otherwise we're just going to endlessly monkey around with this link status issue.