Skip to contentSkip to conversation

UBI: add more checks to chdev open

PATCH New Artem Bityutskiy 1 participant 1 message Jan 6, 2010

Subsystems (2)
Memory technology devices (MTD) Unsorted block images (UBI)
lore
Share & tools
lore

Artem Bityutskiy

author
#0 lore raw

PATCH 1/3 UBI: add more checks to chdev open

From: Artem Bityutskiy <[email protected]>

When opening UBI volumes by their character device names, make sure we are opening character devices, not block devices or any other inode type.

Signed-off-by Artem Bityutskiy <[email protected]>
---
 drivers/mtd/ubi/kapi.c |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)
drivers/mtd/ubi/kapi.c +7 -8
index 277786e..1361574 100644
@@ -291,8 +291,7 @@ EXPORT_SYMBOL_GPL(ubi_open_volume_nm);
  */
 struct ubi_volume_desc *ubi_open_volume_path(const char *pathname, int mode)
 {
-	int error, ubi_num, vol_id;
-	struct ubi_volume_desc *ret;
+	int error, ubi_num, vol_id, mod;
 	struct inode *inode;
 	struct path path;
 

@@ -306,16 +305,16 @@ struct ubi_volume_desc *ubi_open_volume_path(const char *pathname, int mode)
 		return ERR_PTR(error);
 
 	inode = path.dentry->d_inode;
+	mod = inode->i_mode;
 	ubi_num = ubi_major2num(imajor(inode));
 	vol_id = iminor(inode) - 1;
+	path_put(&path);
 
+	if (!S_ISCHR(mod))
+		return ERR_PTR(-EINVAL);
 	if (vol_id >= 0 && ubi_num >= 0)
-		ret = ubi_open_volume(ubi_num, vol_id, mode);
-	else
-		ret = ERR_PTR(-ENODEV);
-
-	path_put(&path);
-	return ret;
+		return ubi_open_volume(ubi_num, vol_id, mode);
+	return ERR_PTR(-ENODEV);
 }
 EXPORT_SYMBOL_GPL(ubi_open_volume_path);
Signature · 1 line
1.6.2.5