x86, irq: check move_in_progress before freeing the vector mapping
PATCH 1/1 x86, irq: check move_in_progress before freeing the vector mapping
x86 folks, please queue this fix for 2.6.33.
thanks,
suresh
---
From: Suresh Siddha <[email protected]>
Subject: [patch] x86, irq: check move_in_progress before freeing the vector mapping
With the recent irq migration fixes (post 2.6.32), Gary Hade has noticed "No IRQ handler for vector" messages during the 2.6.33-rc1 kernel boot on IBM AMD platforms and root caused the issue to this commit:
Quoted 5 lines
commit
23359a88e7eca3c4f402562b102f23014db3c2aaAuthor: Suresh Siddha <[email protected]> Date: Mon Oct 26 14:24:33 2009 -0800x86: Remove
move_cleanup_countfromirq_cfg
As part of this patch, we have removed the move_cleanup_count check in smp_irq_move_cleanup_interrupt(). With this change, we can run into a situation where an irq cleanup interrupt on a cpu can cleanup the vector mappings associated with multiple irqs, of which one of the irq's migration might be still in progress. As such when that irq hits the old cpu, we get the "No IRQ handler" messages.
Fix this by checking for the irq_cfg's move_in_progress and if the move is still in progress delay the vector cleanup to another irq cleanup interrupt request (which will happen when the irq starts arriving at the new cpu destination).
---
arch/x86/kernel/apic/io_apic.c +7 -0
@@ -2434,6 +2434,13 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void) cfg =irq_cfg (irq);raw_spin_lock (&desc->lock); +/* +* Check if the irq migration is in progress. If so, we +* haven't received the cleanup request yet for this irq. +*/ +if (cfg->move_in_progress) + goto unlock; +if (vector == cfg->vector &&cpumask_test_cpu (me, cfg->domain)) goto unlock;
[tip:x86/urgent] x86, irq: Check move_in_progress before freeing the vector mapping
Commit-ID: 7f41c2e1523f628cc248e34192162aec5728bed7 Gitweb: http://git.kernel.org/tip/7f41c2e1523f628cc248e34192162aec5728bed7 Author: Suresh Siddha <[email protected]> AuthorDate: Wed, 6 Jan 2010 10:56:31 -0800 Committer: H. Peter Anvin <[email protected]> CommitDate: Wed, 6 Jan 2010 12:08:43 -0800
x86, irq: Check move_in_progress before freeing the vector mapping
With the recent irq migration fixes (post 2.6.32), Gary Hade has noticed "No IRQ handler for vector" messages during the 2.6.33-rc1 kernel boot on IBM AMD platforms and root caused the issue to this commit:
Quoted 5 lines
commit
23359a88e7eca3c4f402562b102f23014db3c2aaAuthor: Suresh Siddha <[email protected]> Date: Mon Oct 26 14:24:33 2009 -0800x86: Remove
move_cleanup_countfromirq_cfg
As part of this patch, we have removed the move_cleanup_count check in smp_irq_move_cleanup_interrupt(). With this change, we can run into a situation where an irq cleanup interrupt on a cpu can cleanup the vector mappings associated with multiple irqs, of which one of the irq's migration might be still in progress. As such when that irq hits the old cpu, we get the "No IRQ handler" messages.
Fix this by checking for the irq_cfg's move_in_progress and if the move is still in progress delay the vector cleanup to another irq cleanup interrupt request (which will happen when the irq starts arriving at the new cpu destination).
LKML-Reference: <[email protected]>
--- arch/x86/kernel/apic/io_apic.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
arch/x86/kernel/apic/io_apic.c +7 -0
@@ -2434,6 +2434,13 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void) cfg =irq_cfg (irq);raw_spin_lock (&desc->lock); +/* +* Check if the irq migration is in progress. If so, we +* haven't received the cleanup request yet for this irq. +*/ +if (cfg->move_in_progress) + goto unlock; +if (vector == cfg->vector &&cpumask_test_cpu (me, cfg->domain)) goto unlock;