Skip to contentSkip to conversation

2.6.33-rc3 regression: leds_alix2: can't allocate I/O for GPIO

DISCUSSION Applied Arnd Hannemann 3 participants 13 messages Jan 7, 2010 – Jan 18, 2010 LED

lore
Share & tools
lore
#0 lore raw

Hi,

with 2.6.33-rc3 the LEDs are not working anymore on my Geode embedded board:
If I remember correctly this was working fine with 2.6.32, but certainly with 2.6.31

relevant dmesg output of 2.6.33-rc3:

[    0.709643] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.207947] leds_alix2: system is recognized as "PC Engines ALIX.2 v0.99h"
[    2.228678] leds_alix2: can't allocate I/O for GPIO

For reference dmesg of 2.6.31.3:

[    0.611953] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.379114] leds_alix2: system is recognized as "PC Engines ALIX.2"
[    2.399097] Registered led device: alix:1
[    2.411404] Registered led device: alix:2
[    2.423720] Registered led device: alix:3

Best regards,
Arnd

#1 lore raw
Quoted 11 lines · Arnd Hannemann

with 2.6.33-rc3 the LEDs are not working anymore on my Geode embedded board:
If I remember correctly this was working fine with 2.6.32, but certainly with 2.6.31

relevant dmesg output of 2.6.33-rc3:

[    0.709643] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.207947] leds_alix2: system is recognized as "PC Engines ALIX.2 v0.99h"
[    2.228678] leds_alix2: can't allocate I/O for GPIO
Quoted 8 lines

For reference dmesg of 2.6.31.3:

[    0.611953] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.379114] leds_alix2: system is recognized as "PC Engines ALIX.2"
[    2.399097] Registered led device: alix:1
[    2.411404] Registered led device: alix:2
[    2.423720] Registered led device: alix:3

Its likely to be commit 7f131cf3ed96c969d7b092bf629e25c3df50901e. It looks like the request_region() call is failing. Daniel, any idea why?

Cheers,

Richard

#2 lore raw
Quoted 16 lines · Richard Purdie
Quoted 15 lines · Arnd Hannemann

with 2.6.33-rc3 the LEDs are not working anymore on my Geode embedded board:
If I remember correctly this was working fine with 2.6.32, but certainly with 2.6.31

relevant dmesg output of 2.6.33-rc3:

[    0.709643] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.207947] leds_alix2: system is recognized as "PC Engines ALIX.2 v0.99h"
[    2.228678] leds_alix2: can't allocate I/O for GPIO

For reference dmesg of 2.6.31.3:

[    0.611953] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
Quoted 7 lines
Quoted 4 lines
[    2.379114] leds_alix2: system is recognized as "PC Engines ALIX.2"
[    2.399097] Registered led device: alix:1
[    2.411404] Registered led device: alix:2
[    2.423720] Registered led device: alix:3

Its likely to be commit 7f131cf3ed96c969d7b092bf629e25c3df50901e. It looks like the request_region() call is failing. Daniel, any idea why?

Some additional debug information:

elara:~# rdmsr 0x5140000C
f00100006100

/proc/ioports says:
6100-61ff : 0000:00:0f.0
6100-61ff : cs5535_gpio

BTW: why is request_region() needed there after all?

Best regards,
Arnd

#3 lore raw
Quoted 26 lines · Arnd Hannemann
Quoted 14 lines · Richard Purdie
Quoted 13 lines · Arnd Hannemann

with 2.6.33-rc3 the LEDs are not working anymore on my Geode embedded board:
If I remember correctly this was working fine with 2.6.32, but certainly with 2.6.31

relevant dmesg output of 2.6.33-rc3:

[    0.709643] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.207947] leds_alix2: system is recognized as "PC Engines ALIX.2 v0.99h"
[    2.228678] leds_alix2: can't allocate I/O for GPIO

For reference dmesg of 2.6.31.3:

Quoted 8 lines
Quoted 6 lines
[    0.611953] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.379114] leds_alix2: system is recognized as "PC Engines ALIX.2"
[    2.399097] Registered led device: alix:1
[    2.411404] Registered led device: alix:2
[    2.423720] Registered led device: alix:3

Its likely to be commit 7f131cf3ed96c969d7b092bf629e25c3df50901e. It looks like the request_region() call is failing. Daniel, any idea why?

Some additional debug information:

Quoted 8 lines
elara:~# rdmsr 0x5140000C
f00100006100

/proc/ioports says:
6100-61ff : 0000:00:0f.0
6100-61ff : cs5535_gpio

BTW: why is request_region() needed there after all?

Oh, maybe using cs5535_gpio AND leds_alix2 together was never supposed to work?

Best regards,
Arnd

#4 lore raw
Quoted 30 lines · Arnd Hannemann
Quoted 29 lines · Arnd Hannemann
Quoted 14 lines · Richard Purdie
Quoted 13 lines · Arnd Hannemann

with 2.6.33-rc3 the LEDs are not working anymore on my Geode embedded board:
If I remember correctly this was working fine with 2.6.32, but certainly with 2.6.31

relevant dmesg output of 2.6.33-rc3:

[    0.709643] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.207947] leds_alix2: system is recognized as "PC Engines ALIX.2 v0.99h"
[    2.228678] leds_alix2: can't allocate I/O for GPIO

For reference dmesg of 2.6.31.3:

Quoted 8 lines
Quoted 6 lines
[    0.611953] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.379114] leds_alix2: system is recognized as "PC Engines ALIX.2"
[    2.399097] Registered led device: alix:1
[    2.411404] Registered led device: alix:2
[    2.423720] Registered led device: alix:3

Its likely to be commit 7f131cf3ed96c969d7b092bf629e25c3df50901e. It looks like the request_region() call is failing. Daniel, any idea why?

Some additional debug information:

elara:~# rdmsr 0x5140000C
f00100006100
Quoted 7 lines
Quoted 5 lines

/proc/ioports says:
6100-61ff : 0000:00:0f.0
6100-61ff : cs5535_gpio

BTW: why is request_region() needed there after all?

Oh, maybe using cs5535_gpio AND leds_alix2 together was never supposed to work?

That is the problem indeed. The problem is that three of these GPIOs are connected to LEDs, so if both drivers are enabled, they will both alter the same GPIOs. Hmm, don't know how to handle this. Maybe the LED driver should use the GPIO interface and that's it?

Daniel

#5 lore raw

Hi,

Quoted 34 lines · Daniel Mack
Quoted 33 lines · Arnd Hannemann
Quoted 32 lines · Arnd Hannemann
Quoted 14 lines · Richard Purdie
Quoted 13 lines · Arnd Hannemann

with 2.6.33-rc3 the LEDs are not working anymore on my Geode embedded board:
If I remember correctly this was working fine with 2.6.32, but certainly with 2.6.31

relevant dmesg output of 2.6.33-rc3:

[    0.709643] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.207947] leds_alix2: system is recognized as "PC Engines ALIX.2 v0.99h"
[    2.228678] leds_alix2: can't allocate I/O for GPIO

For reference dmesg of 2.6.31.3:

Quoted 8 lines
Quoted 6 lines
[    0.611953] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.379114] leds_alix2: system is recognized as "PC Engines ALIX.2"
[    2.399097] Registered led device: alix:1
[    2.411404] Registered led device: alix:2
[    2.423720] Registered led device: alix:3

Its likely to be commit 7f131cf3ed96c969d7b092bf629e25c3df50901e. It looks like the request_region() call is failing. Daniel, any idea why?

Some additional debug information:

elara:~# rdmsr 0x5140000C
f00100006100

/proc/ioports says:
6100-61ff : 0000:00:0f.0
6100-61ff : cs5535_gpio

Quoted 7 lines
Quoted 2 lines
Quoted 1 line

BTW: why is request_region() needed there after all?

Oh, maybe using cs5535_gpio AND leds_alix2 together was never supposed to work?

That is the problem indeed. The problem is that three of these GPIOs are connected to LEDs, so if both drivers are enabled, they will both alter the same GPIOs. Hmm, don't know how to handle this. Maybe the LED driver should use the GPIO interface and that's it?

I'm not sure that this configuration needs to be supported at all,
so disallowing that both drivers are configured via Kconfig could be a simple solution.

If I understand correctly, for off-the-shelf ALIX2 boards, beside the LEDs, there is only one other GPIO pin being usable (the "mode switch"), anyway.

Best regards,
Arnd

#6 lore raw

Hi,

Quoted 38 lines · Arnd Hannemann
Quoted 37 lines · Daniel Mack
Quoted 35 lines · Arnd Hannemann
Quoted 25 lines · Arnd Hannemann
Quoted 14 lines · Richard Purdie
Quoted 13 lines · Arnd Hannemann

with 2.6.33-rc3 the LEDs are not working anymore on my Geode embedded board:
If I remember correctly this was working fine with 2.6.32, but certainly with 2.6.31

relevant dmesg output of 2.6.33-rc3:

[    0.709643] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.207947] leds_alix2: system is recognized as "PC Engines ALIX.2 v0.99h"
[    2.228678] leds_alix2: can't allocate I/O for GPIO

For reference dmesg of 2.6.31.3:

Quoted 8 lines
Quoted 6 lines
[    0.611953] cs5535_gpio: base=0x6100 mask=0xb003c66 major=253
[    2.379114] leds_alix2: system is recognized as "PC Engines ALIX.2"
[    2.399097] Registered led device: alix:1
[    2.411404] Registered led device: alix:2
[    2.423720] Registered led device: alix:3

Its likely to be commit 7f131cf3ed96c969d7b092bf629e25c3df50901e. It looks like the request_region() call is failing. Daniel, any idea why?

Some additional debug information:

Quoted 8 lines
elara:~# rdmsr 0x5140000C
f00100006100

/proc/ioports says:
6100-61ff : 0000:00:0f.0
6100-61ff : cs5535_gpio

BTW: why is request_region() needed there after all?

Oh, maybe using cs5535_gpio AND leds_alix2 together was never supposed to work?

Quoted 7 lines
Quoted 4 lines

That is the problem indeed. The problem is that three of these GPIOs are connected to LEDs, so if both drivers are enabled, they will both alter the same GPIOs. Hmm, don't know how to handle this. Maybe the LED driver should use the GPIO interface and that's it?

I'm not sure that this configuration needs to be supported at all,
so disallowing that both drivers are configured via Kconfig could be a simple solution.

True.

Quoted 2 lines

If I understand correctly, for off-the-shelf ALIX2 boards, beside the LEDs, there is only one other GPIO pin being usable (the "mode switch"), anyway.

Yes. I also wrote a simple polled input device driver to support this switch, but it was too much of a hack as it ended up being part of the LED driver. The idea discussed back then was to clean up the code so that the entire MSR lookup thing is only done once, and a platform support for ALIX board then adds support for the LEDs via the leds-gpio LED driver and for the button via gpio-buttons input driver. That would be much nicer, but I haven't found the time yet to implement it.

Daniel

#7 lore raw
In reply to Arnd Hannemann
Quoted 5 lines · Arnd Hannemann
Quoted 4 lines · Daniel Mack
Quoted 2 lines · Arnd Hannemann

Arnd Hannemann schrieb:
Oh, maybe using cs5535_gpio AND leds_alix2 together was never supposed to work?

Quoted 7 lines
Quoted 4 lines

That is the problem indeed. The problem is that three of these GPIOs are connected to LEDs, so if both drivers are enabled, they will both alter the same GPIOs. Hmm, don't know how to handle this. Maybe the LED driver should use the GPIO interface and that's it?

I'm not sure that this configuration needs to be supported at all,
so disallowing that both drivers are configured via Kconfig could be a simple solution.

Agreed, Kconfig dependencies for this until the code is improved look like the best option. Does someone want to send me a patch?

Cheers,

Richard

Signature · 2 lines
Richard Purdie
Intel Open Source Technology Centre
#8 lore raw
Quoted 11 lines · Richard Purdie
Quoted 10 lines · Arnd Hannemann
Quoted 8 lines · Daniel Mack
Quoted 2 lines · Arnd Hannemann

Arnd Hannemann schrieb:
Oh, maybe using cs5535_gpio AND leds_alix2 together was never supposed to work?

That is the problem indeed. The problem is that three of these GPIOs are connected to LEDs, so if both drivers are enabled, they will both alter the same GPIOs. Hmm, don't know how to handle this. Maybe the LED driver should use the GPIO interface and that's it?

Quoted 5 lines
Quoted 2 lines

I'm not sure that this configuration needs to be supported at all,
so disallowing that both drivers are configured via Kconfig could be a simple solution.

Agreed, Kconfig dependencies for this until the code is improved look like the best option. Does someone want to send me a patch?

Does the one below look ok?

Thanks,
Daniel

Quoted 1 line

From ebb89d7d1908e85587f3e64bcea0dd77a92cc744 Mon Sep 17 00:00:00 2001

From: Daniel Mack <[email protected]>
Date: Fri, 8 Jan 2010 02:22:10 +0800
Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO driver share the same I/O range which causes a conflict if they're both enabled. Fix this for now by adding a Kconfig dependency. While at it, also drop the EXPERIMENTAL flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for this board should be added which handles the LEDs via the leds-gpio driver.

Cc Richard Purdie <[email protected]>
Cc Arnd Hannemann <[email protected]>
---
 drivers/leds/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/Kconfig +1 -1
index 8a0e1ec..7f292ae 100644
@@ -72,7 +72,7 @@ config LEDS_WRAP
 
 config LEDS_ALIX2
 	tristate "LED Support for ALIX.2 and ALIX.3 series"
-	depends on LEDS_CLASS && X86 && EXPERIMENTAL
+	depends on LEDS_CLASS && X86 && !GPIO_CS5535
 	help
 	  This option enables support for the PCEngines ALIX.2 and ALIX.3 LEDs.
 	  You have to set leds-alix2.force=1 for boards with Award BIOS.
Signature · 1 line
1.6.3.3
#9 lore raw
Quoted 47 lines · Daniel Mack
Quoted 5 lines · Richard Purdie
Quoted 4 lines · Arnd Hannemann
Quoted 3 lines · Daniel Mack
Quoted 2 lines · Arnd Hannemann

Arnd Hannemann schrieb:
Oh, maybe using cs5535_gpio AND leds_alix2 together was never supposed to work?

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

That is the problem indeed. The problem is that three of these GPIOs are connected to LEDs, so if both drivers are enabled, they will both alter the same GPIOs. Hmm, don't know how to handle this. Maybe the LED driver should use the GPIO interface and that's it?

I'm not sure that this configuration needs to be supported at all,
so disallowing that both drivers are configured via Kconfig could be a simple solution.

Agreed, Kconfig dependencies for this until the code is improved look like the best option. Does someone want to send me a patch?

Does the one below look ok?

Thanks,
Daniel

From ebb89d7d1908e85587f3e64bcea0dd77a92cc744 Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Fri, 8 Jan 2010 02:22:10 +0800
Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO driver share the same I/O range which causes a conflict if they're both enabled. Fix this for now by adding a Kconfig dependency. While at it, also drop the EXPERIMENTAL flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for this board should be added which handles the LEDs via the leds-gpio driver.

Cc Richard Purdie <[email protected]>
Cc Arnd Hannemann <[email protected]>
---
 drivers/leds/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/Kconfig +0 -0
index 8a0e1ec..7f292ae 100644

drivers/leds/Kconfig config LEDS_WRAP · line 75

Quoted 5 lines
drivers/leds/Kconfig +1 -1
@@ -72,7 +72,7 @@ config LEDS_WRAP
 
 config LEDS_ALIX2
 	tristate "LED Support for ALIX.2 and ALIX.3 series"
-	depends on LEDS_CLASS && X86 && EXPERIMENTAL
+	depends on LEDS_CLASS && X86 && !GPIO_CS5535

You should add && !CS5535_GPIO, too. In fact CS5535_GPIO was the one that I had issues with. Though, I wonder why there are multiple drivers... Buts thats another issue.

drivers/leds/Kconfig config LEDS_WRAP · line 78

Quoted 3 lines
drivers/leds/Kconfig +0 -0
 	help
 	  This option enables support for the PCEngines ALIX.2 and ALIX.3 LEDs.
 	  You have to set leds-alix2.force=1 for boards with Award BIOS.

Best regards,
Arnd

#10 lore raw
Quoted 1 line · Arnd Hannemann

Daniel Mack schrieb:

[...]

Quoted 27 lines
Quoted 27 lines

From ebb89d7d1908e85587f3e64bcea0dd77a92cc744 Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Fri, 8 Jan 2010 02:22:10 +0800
Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO driver share the same I/O range which causes a conflict if they're both enabled. Fix this for now by adding a Kconfig dependency. While at it, also drop the EXPERIMENTAL flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for this board should be added which handles the LEDs via the leds-gpio driver.

Cc Richard Purdie <[email protected]>
Cc Arnd Hannemann <[email protected]>
---
 drivers/leds/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/Kconfig +0 -0
index 8a0e1ec..7f292ae 100644
@@ -72,7 +72,7 @@ config LEDS_WRAP
 
Quoted 8 lines

drivers/leds/Kconfig config LEDS_WRAP · line 75

Quoted 4 lines
drivers/leds/Kconfig +1 -1
 config LEDS_ALIX2
 	tristate "LED Support for ALIX.2 and ALIX.3 series"
-	depends on LEDS_CLASS && X86 && EXPERIMENTAL
+	depends on LEDS_CLASS && X86 && !GPIO_CS5535

You should add && !CS5535_GPIO, too. In fact CS5535_GPIO was the one that I had issues with. Though, I wonder why there are multiple drivers... Buts thats another issue.

Ah, right, thanks for noticing. New patch below.

Daniel

Quoted 1 line

From 0ce35578c6705dd1c44d076529df6dba889b7b76 Mon Sep 17 00:00:00 2001

From: Daniel Mack <[email protected]>
Date: Fri, 8 Jan 2010 02:22:10 +0800
Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO drivers share the same I/O range which causes a conflict if they're both enabled. Fix this for now by adding Kconfig dependencies. While at it, also drop the EXPERIMENTAL flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for this board should be added which handles the LEDs via the leds-gpio driver.

Cc Richard Purdie <[email protected]>
Cc Arnd Hannemann <[email protected]>
---
 drivers/leds/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/Kconfig +1 -1
index 8a0e1ec..fef1cf4 100644
@@ -72,7 +72,7 @@ config LEDS_WRAP
 
 config LEDS_ALIX2
 	tristate "LED Support for ALIX.2 and ALIX.3 series"
-	depends on LEDS_CLASS && X86 && EXPERIMENTAL
+	depends on LEDS_CLASS && X86 && !GPIO_CS5535 && !CS5535_GPIO
 	help
 	  This option enables support for the PCEngines ALIX.2 and ALIX.3 LEDs.
 	  You have to set leds-alix2.force=1 for boards with Award BIOS.
Signature · 1 line
1.6.3.3
#11 lore raw

ping?

Quoted 83 lines · Daniel Mack
Quoted 1 line · Arnd Hannemann

Daniel Mack schrieb:

[...]

Quoted 27 lines
Quoted 27 lines

From ebb89d7d1908e85587f3e64bcea0dd77a92cc744 Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Fri, 8 Jan 2010 02:22:10 +0800
Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO driver share the same I/O range which causes a conflict if they're both enabled. Fix this for now by adding a Kconfig dependency. While at it, also drop the EXPERIMENTAL flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for this board should be added which handles the LEDs via the leds-gpio driver.

Cc Richard Purdie <[email protected]>
Cc Arnd Hannemann <[email protected]>
---
 drivers/leds/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/Kconfig +0 -0
index 8a0e1ec..7f292ae 100644
@@ -72,7 +72,7 @@ config LEDS_WRAP
 
Quoted 8 lines

drivers/leds/Kconfig config LEDS_WRAP

Quoted 4 lines
drivers/leds/Kconfig +1 -1
 config LEDS_ALIX2
 	tristate "LED Support for ALIX.2 and ALIX.3 series"
-	depends on LEDS_CLASS && X86 && EXPERIMENTAL
+	depends on LEDS_CLASS && X86 && !GPIO_CS5535

You should add && !CS5535_GPIO, too. In fact CS5535_GPIO was the one that I had issues with. Though, I wonder why there are multiple drivers... Buts thats another issue.

Ah, right, thanks for noticing. New patch below.

Daniel

From 0ce35578c6705dd1c44d076529df6dba889b7b76 Mon Sep 17 00:00:00 2001
From: Daniel Mack <[email protected]>
Date: Fri, 8 Jan 2010 02:22:10 +0800
Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO drivers share the same I/O range which causes a conflict if they're both enabled. Fix this for now by adding Kconfig dependencies. While at it, also drop the EXPERIMENTAL flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for this board should be added which handles the LEDs via the leds-gpio driver.

Cc Richard Purdie <[email protected]>
Cc Arnd Hannemann <[email protected]>
---
 drivers/leds/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/leds/Kconfig +1 -1
index 8a0e1ec..fef1cf4 100644
@@ -72,7 +72,7 @@ config LEDS_WRAP
 
 config LEDS_ALIX2
 	tristate "LED Support for ALIX.2 and ALIX.3 series"
-	depends on LEDS_CLASS && X86 && EXPERIMENTAL
+	depends on LEDS_CLASS && X86 && !GPIO_CS5535 && !CS5535_GPIO
 	help
 	  This option enables support for the PCEngines ALIX.2 and ALIX.3 LEDs.
 	  You have to set leds-alix2.force=1 for boards with Award BIOS.
Signature · 1 line
1.6.3.3
#12 lore raw
In reply to Daniel Mack
Quoted 10 lines · Daniel Mack

Subject: [PATCH] LEDS: ALIX2: Add dependency to !GPIO_CS5335

The ALIX2 LED driver and the CS5535 GPIO drivers share the same I/O range which causes a conflict if they're both enabled. Fix this for now by adding Kconfig dependencies. While at it, also drop the EXPERIMENTAL flag, as the code has been around for awhile already.

Note that this is a hack. At some point, a real platform support for this board should be added which handles the LEDs via the leds-gpio driver.

Queued in the LED tree, thanks. I'll push this one to Linus shortly for 2.6.33.

Richard

Signature · 2 lines
Richard Purdie
Intel Open Source Technology Centre