Skip to contentSkip to conversation

Driver-Core: require valid action string in uevent trigger

PATCH Kay Sievers 1 participant 1 message Jan 14, 2010 Driver core

lore
Share & tools
lore
#0 lore raw

From: Kay Sievers <[email protected]>
Subject: Driver-Core: require valid action string in uevent trigger

No longer fall back to "add" and warn, but always require a valid action-string written to the "uevent" file.

---
 drivers/base/core.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/base/core.c +3 -8
@@ -306,15 +306,10 @@ static ssize_t store_uevent(struct devic
 {
 	enum kobject_action action;
 
-	if (kobject_action_type(buf, count, &action) == 0) {
+	if (kobject_action_type(buf, count, &action) == 0)
 		kobject_uevent(&dev->kobj, action);
-		goto out;
-	}
-
-	dev_err(dev, "uevent: unsupported action-string; this will "
-		     "be ignored in a future kernel version\n");
-	kobject_uevent(&dev->kobj, KOBJ_ADD);
-out:
+	else
+		dev_err(dev, "uevent: unknown action-string\n");
 	return count;
 }