Skip to contentSkip to conversation

Compro S350 GPIO change

PATCH In review JD Louw 2 participants 3 messages Jan 17, 2010 – Jan 18, 2010 Media (V4L/DVB)

lore
Share & tools
lore

JD Louw

author
#0 lore raw

PATCH 1/1 Compro S350 GPIO change

Hi,

This patch enables LNB power on newer revision d1 Compro S350 and S300
DVB-S cards. While I don't have these cards to test with I'm confident
that this works. See
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/7471 and http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/14296
and new windows driver as reference.

diff -r 59e746a1c5d1 linux/drivers/media/video/saa7134/saa7134-cards.c
--- a/linux/drivers/media/video/saa7134/saa7134-cards.c Wed Dec 30
09:10:33 2009 -0200
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Sun Jan 17
14:51:07 2010 +0200
@@ -7037,8 +7037,8 @@ int saa7134_board_init1(struct saa7134_d
break;
case SAA7134_BOARD_VIDEOMATE_S350:
dev->has_remote = SAA7134_REMOTE_GPIO;
- saa_andorl(SAA7134_GPIO_GPMODE0 >> 2, 0x00008000, 0x00008000);
- saa_andorl(SAA7134_GPIO_GPSTATUS0 >> 2, 0x00008000, 0x00008000);
+ saa_andorl(SAA7134_GPIO_GPMODE0 >> 2, 0x0000C000, 0x0000C000);
+ saa_andorl(SAA7134_GPIO_GPSTATUS0 >> 2, 0x0000C000, 0x0000C000);
break;
}
return 0;

#1 lore raw

2010/1/17 JD Louw <[email protected]>:

Quoted 28 lines

Hi,

This patch enables LNB power on newer revision d1 Compro S350 and S300
DVB-S cards. While I don't have these cards to test with I'm confident
that this works. See
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/7471 and http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/14296
and new windows driver as reference.

diff -r 59e746a1c5d1 linux/drivers/media/video/saa7134/saa7134-cards.c --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Wed Dec 30 09:10:33 2009 -0200
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Sun Jan 17 14:51:07 2010 +0200

(quoted diff) +0 -0
@@ -7037,8 +7037,8 @@ int saa7134_board_init1(struct saa7134_d
                break;

       case SAA7134_BOARD_VIDEOMATE_S350:
               dev->has_remote = SAA7134_REMOTE_GPIO;
-               saa_andorl(SAA7134_GPIO_GPMODE0 >> 2,   0x00008000, 0x00008000);
-               saa_andorl(SAA7134_GPIO_GPSTATUS0 >> 2, 0x00008000, 0x00008000);
+               saa_andorl(SAA7134_GPIO_GPMODE0 >> 2,   0x0000C000, 0x0000C000);
+               saa_andorl(SAA7134_GPIO_GPSTATUS0 >> 2, 0x0000C000, 0x0000C000); break;
       }
       return 0;

Quoted 1 line

--

Hi Jan,

This does not fix the problem where the card is suppose to suspend and the Voltage drops to 0V? Do you still require the windows registry reference for this part?

author
#2 lore raw
Quoted 29 lines · Theunis Potgieter

2010/1/17 JD Louw <[email protected]>:

Quoted 28 lines

Hi,

This patch enables LNB power on newer revision d1 Compro S350 and S300
DVB-S cards. While I don't have these cards to test with I'm confident
that this works. See
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/7471 and http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/14296
and new windows driver as reference.

diff -r 59e746a1c5d1 linux/drivers/media/video/saa7134/saa7134-cards.c --- a/linux/drivers/media/video/saa7134/saa7134-cards.c Wed Dec 30 09:10:33 2009 -0200
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c Sun Jan 17 14:51:07 2010 +0200

(quoted diff) +2 -2
@@ -7037,8 +7037,8 @@ int saa7134_board_init1(struct saa7134_d
               break;
       case SAA7134_BOARD_VIDEOMATE_S350:
               dev->has_remote = SAA7134_REMOTE_GPIO;
-               saa_andorl(SAA7134_GPIO_GPMODE0 >> 2,   0x00008000, 0x00008000);
-               saa_andorl(SAA7134_GPIO_GPSTATUS0 >> 2, 0x00008000, 0x00008000);
+               saa_andorl(SAA7134_GPIO_GPMODE0 >> 2,   0x0000C000, 0x0000C000);
+               saa_andorl(SAA7134_GPIO_GPSTATUS0 >> 2, 0x0000C000, 0x0000C000);
               break;
       }
       return 0;
Quoted 6 lines
Quoted 1 line

--

Hi Jan,

This does not fix the problem where the card is suppose to suspend and the Voltage drops to 0V? Do you still require the windows registry reference for this part?

Hi,

No, the aim of the patch is just to get the basic driver support for all S300/S350 revisions. A windows regspy capture on a d1 revision card may still be useful in double checking the GPIO values, but I already know which GPIO controls LNB voltage:

GPIO15 = modulator reset
GPIO14 = LNB power