Skip to contentSkip to conversation

Issue in drivers/mmc/mmc.c

U-Boot Quentin Armitage 2 participants 2 messages Jan 18, 2010 – Mar 11, 2010 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · Wolfgang Denk

Can you please resent this patch, with your Signed-off-by: line added?

Herewith patch resubmitted with Signed-off-by line added:

There appears to be a path through mmc_read in drivers/mmc/mmc.c where malloc'd memory is not freed before exiting mmc_read, although this may be a hypothetical situation. It occurs if mmc_set_blocklen() returns a non-zero value.

The following patch appears to resolve the issue:

mmc/mmc.c renamed from drivers/mmc/mmc.c +1 -1
@@ -172,7 +172,7 @@ int mmc_read(struct mmc *mmc, u64 src, u
 	err = mmc_set_blocklen(mmc, mmc->read_bl_len);
 
 	if (err)
-		return err;
+		goto free_buffer;
 
 	for (i = startblock; i <= endblock; i++) {
 		int segment_size;

With regards,
Quentin Armitage

#1 lore raw

Dear Quentin Armitage,

Quoted 2 lines · In message <[email protected]> you wrote:

Herewith patch resubmitted with Signed-off-by line added:

Ah. Found it. I just wish you had used the required standard format for patches (i. e. git based). Thanks anyway.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Prepare for tomorrow -- get ready.
	-- Edith Keeler, "The City On the Edge of Forever",
	   stardate unknown