Skip to contentSkip to conversation

Rename rar_driver to rar_register

PATCH In review Mark Allyn 4 participants 6 messages Jan 18, 2010 – Jan 19, 2010 Staging

lore
Share & tools
lore

Mark Allyn

author
#0 lore raw

PATCH 1/1 Rename rar_driver to rar_register

The purpose of this patch is to change the name of rar_register source files (both the .c and .h files) to rar_register.

This is the first of seven patches for the rar_register driver for Sunday, January 17, 2009

This is to clarify that this driver is for the rar_register.

This patch only changes the names. It does not make any changes in any code.

Any checkpatch errors on this code were from the original code. They will be addressed in future patches.

The rar stands for restricted access region. The restricted access region is an area of memory that can be locked from access by the x86 processor.

The purpose of the restricted access region is to safeguard confidential information from any unauthorized software running on the x86 processor.

The purpose of this driver is to enable other drivers to obtain the address ranges of the restricted regions as well as lock them.

This patch is referenced off the linux-next repository as pulled on Sunday, January 17, 2010

Date: January 17, 2010

---
 drivers/staging/rar/Makefile       |    2 +-
 drivers/staging/rar/rar_driver.c   |  444 ------------------------------------
 drivers/staging/rar/rar_driver.h   |   99 --------
 drivers/staging/rar/rar_register.c |  444 ++++++++++++++++++++++++++++++++++++
 drivers/staging/rar/rar_register.h |   99 ++++++++
 5 files changed, 544 insertions(+), 544 deletions(-)
 delete mode 100644 drivers/staging/rar/rar_driver.c
 delete mode 100644 drivers/staging/rar/rar_driver.h
 create mode 100644 drivers/staging/rar/rar_register.c
 create mode 100644 drivers/staging/rar/rar_register.h
drivers/staging/rar/Makefile +1 -1
index 5422ed0..d5954cc 100644
@@ -1,2 +1,2 @@
 EXTRA_CFLAGS += -DLITTLE__ENDIAN
-obj-$(CONFIG_RAR_REGISTER) += rar_driver.o
+obj-$(CONFIG_RAR_REGISTER) += rar_register.o
drivers/staging/rar/rar_driver.c deleted +0 -444

444 lines not on this page · raw message

drivers/staging/rar/rar_driver.h deleted +0 -99

99 lines not on this page · raw message

drivers/staging/rar/rar_register.c new file +444 -0

444 lines not on this page · raw message

drivers/staging/rar/rar_register.h new file +99 -0

99 lines not on this page · raw message

Signature · 1 line
1.6.0.6
#1 lore raw

Hi Mark,

Quoted 18 lines

The purpose of this patch is to change the name of rar_register source files (both the .c and .h files) to rar_register.

This is the first of seven patches for the rar_register driver for Sunday, January 17, 2009

This is to clarify that this driver is for the rar_register.

This patch only changes the names. It does not make any changes in any code.

Any checkpatch errors on this code were from the original code. They will be addressed in future patches.

The rar stands for restricted access region. The restricted access region is an area of memory that can be locked from access by the x86 processor.

Quoted 8 lines

The purpose of the restricted access region is to safeguard confidential information from any unauthorized software running on the x86 processor.

The purpose of this driver is to enable other drivers to obtain the address ranges of the restricted regions as well as lock them.

This patch is referenced off the linux-next repository as pulled on Sunday, January 17, 2010

this is a lot of boilerplate that you repeat for every patch in this series. It distracts from the actual change you are making. I would prefer if you send an introductory/summary email and then focus the commit message on the actual change you are making.

Regards

Marcel

#2 lore raw
Quoted 26 lines · Marcel Holtmann

Hi Mark,

Quoted 24 lines

The purpose of this patch is to change the name of rar_register source files (both the .c and .h files) to rar_register.

This is the first of seven patches for the rar_register driver for Sunday, January 17, 2009

This is to clarify that this driver is for the rar_register.

This patch only changes the names. It does not make any changes in any code.

Any checkpatch errors on this code were from the original code. They will be addressed in future patches.

The rar stands for restricted access region. The restricted access region is an area of memory that can be locked from access by the x86 processor.

The purpose of the restricted access region is to safeguard confidential information from any unauthorized software running on the x86 processor.

The purpose of this driver is to enable other drivers to obtain the address ranges of the restricted regions as well as lock them.

Quoted 7 lines
Quoted 2 lines

This patch is referenced off the linux-next repository as pulled on Sunday, January 17, 2010

this is a lot of boilerplate that you repeat for every patch in this series. It distracts from the actual change you are making. I would prefer if you send an introductory/summary email and then focus the commit message on the actual change you are making.

As the person who has to edit these commit messages down to nothing, I totally agree. Please follow the proper submission guidelines for patches as described in the Documentation/ directory.

Can you resend all of these please based on that?

thanks,

greg k-h

#3 lore raw
In reply to Mark Allyn
Quoted 7 lines · Mark Allyn

The purpose of this patch is to change the name of rar_register source files (both the .c and .h files) to rar_register.

This is the first of seven patches for the rar_register driver for Sunday, January 17, 2009

This is to clarify that this driver is for the rar_register.

What does that mean? Why does the name matter?

confused,

greg k-h

#4 lore raw
Quoted 10 lines · On Mon, 18 Jan 2010 16:12:43 -0800 Greg KH <[email protected]> wrote:
Quoted 7 lines · Mark Allyn

The purpose of this patch is to change the name of rar_register source files (both the .c and .h files) to rar_register.

This is the first of seven patches for the rar_register driver for Sunday, January 17, 2009

This is to clarify that this driver is for the rar_register.

What does that mean? Why does the name matter?

RAR are the registers. The code handles the registers. There are things that use the registers which are drivers but are not this code. It could almost be "librar" except it's not quite used as a library

#5 lore raw
Quoted 10 lines · Alan Cox
Quoted 7 lines · On Mon, 18 Jan 2010 16:12:43 -0800 Greg KH <[email protected]> wrote:
Quoted 6 lines · Mark Allyn

The purpose of this patch is to change the name of rar_register source files (both the .c and .h files) to rar_register.

This is the first of seven patches for the rar_register driver for Sunday, January 17, 2009

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

This is to clarify that this driver is for the rar_register.

What does that mean? Why does the name matter?

RAR are the registers. The code handles the registers. There are things that use the registers which are drivers but are not this code. It could almost be "librar" except it's not quite used as a library

Ok, thanks for the info, it would be good to have this in the changelog entry for the next patch series submission.

thanks,

greg k-h